Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems 'prob_leave_bandit' in 'state_transition' not used. #28

Open
yoongi0428 opened this issue Aug 4, 2020 · 1 comment
Open

Seems 'prob_leave_bandit' in 'state_transition' not used. #28

yoongi0428 opened this issue Aug 4, 2020 · 1 comment

Comments

@yoongi0428
Copy link

yoongi0428 commented Aug 4, 2020

For both RecoGym environment (RecoEnv0, RecoEnv1), they initialize 'state_transition' using default arguments passed through config.
It seems that the second row, which correspond to bandit, use 'self.config.prob_leave_organic' instead of 'self.config.prob_leave_bandit'.
The default value of both is the same as 0.1 but I think it might cause unintentional behavior in some cases.
Is this code intended or just a typo?

def set_static_params(self):
# Initialise the state transition matrix which is 3 by 3
# high level transitions between organic, bandit and leave.
self.state_transition = np.array([
[0, self.config.prob_organic_to_bandit, self.config.prob_leave_organic],
[self.config.prob_bandit_to_organic, 0, self.config.prob_leave_organic],
[0.0, 0.0, 1.]
])

@ihtiihti
Copy link
Contributor

You are right, it should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants