New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The transition matrix of states seems wrong when we set "prob_leave_bandit" #29

Open

yxliu-ntu opened this issue Sep 7, 2020 · 1 comment

yxliu-ntu commented Sep 7, 2020 •

edited

Loading

reco-gym/recogym/envs/reco_env_v1.py

Lines 55 to 57 in f8553d1

    
           [0, self.config.prob_organic_to_bandit, self.config.prob_leave_organic], 
        
           [self.config.prob_bandit_to_organic, 0, self.config.prob_leave_organic], 
        
           [0.0, 0.0, 1.]

Should the line 56th of the file "reco_env_v1.py" be
[self.config.prob_bandit_to_organic, 0, self.config.prob_leave_bandit] ?

The text was updated successfully, but these errors were encountered:

Contributor

ihtiihti commented Sep 10, 2020

Yes, please, fix it.

yxliu-ntu mentioned this issue

fix a minior bug for seting prob_leave_bandit of trainsition matrix #30

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment