Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not be treated as noFillError() when Criteo is initialized for the very first time in CriteoAdapter #54

Open
coldcode001 opened this issue Feb 14, 2023 · 0 comments

Comments

@coldcode001
Copy link

https://github.com/criteo/android-publisher-sdk-google-adapters/blob/0a8d2f5ab8499c7fe7854b9049847ea8b79211bc/mediation/src/main/java/com/criteo/mediation/google/CriteoAdapter.kt#L188,L197

In case of not initialized in CriteoAdapter#initialize with param tagForChildDirectedTreatment, it will call Criteo.Builder().init(). When it's initialized successfully here then it should return true to continue loading the ads, otherwise it will always fail for the first time.
Not sure if I misunderstand this piece of code, or is there any thing to prevent from doing that way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant