Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with later versions of Node? (ReferenceError: primordials is not defined) #144

Closed
posita opened this issue May 29, 2020 · 0 comments · Fixed by #146
Closed

Comments

@posita
Copy link
Collaborator

posita commented May 29, 2020

% git clone https://github.com/crobi/rpg-cards.git
…
% cd rpg-cards
% node --version
v14.3.0
% npm --version
6.14.5
% npm install
…
% node ./resources/tools/update-icons.js
fs.js:39
} = primordials;
    ^

ReferenceError: primordials is not defined
    at fs.js:39:5
    at req_ (/…/rpg-cards/node_modules/natives/index.js:143:24)
    at Object.req [as require] (/…/rpg-cards/node_modules/natives/index.js:55:10)
    at Object.<anonymous> (/…/rpg-cards/node_modules/fstream/node_modules/graceful-fs/fs.js:1:37)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
% npm install 'graceful-fs@^4.0.0'  # doesn't monkeypatch
…
% node ./resources/tools/update-icons.js
fs.js:39
} = primordials;
    ^

ReferenceError: primordials is not defined
    at fs.js:39:5
…

It looks like this is being picked up from unzip:

% npm list
…
├─┬ unzip@0.1.11
…
│ ├─┬ fstream@0.1.31
│ │ ├─┬ graceful-fs@3.0.12
…

See nodejs/node#27422 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant