Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wamp.session.kill_by_authrole does not follow spec #2082

Open
ecorm opened this issue May 27, 2023 · 0 comments
Open

wamp.session.kill_by_authrole does not follow spec #2082

ecorm opened this issue May 27, 2023 · 0 comments

Comments

@ecorm
Copy link

ecorm commented May 27, 2023

wamp.session.kill_by_authrole closes the session of the caller issuing that meta procedure, but the WAMP spec forbids this:

If the caller's own session has the specified authrole, the caller's session is excluded from the closed sessions.

See trace from the client issuing the meta procedure call:

["TX","HELLO",[1,"cppwamp.test",{"agent":"cppwamp-0.11.1","roles":"snipped"}]]
["RX","WELCOME",[2,5111111940399149,{"authextra":"redacted","authid":"CNTF-SPVQ-X3XL-PWMU-CPRU-3T6N","authmethod":"anonymous","authprovider":"static","authrole":"anonymous","realm":"cppwamp.test","roles":"snipped","x_cb_node":"redacted","x_cb_peer":"redacted","x_cb_pid":11949,"x_cb_worker":"worker001"}]]
["TX","CALL",[48,1,{},"wamp.session.kill_by_authrole",["anonymous"],{}]]
["RX","GOODBYE",[6,{},"wamp.close.normal"]]
["TX","GOODBYE",[6,{},"wamp.close.goodbye_and_out"]]

In case it matters, this occurred with Crossbar's built-in anonymous authenticator. The session issuing the call had the anonymous authrole.


Furthermore, Crossbar's wamp.session.kill_by_authrole returns an array, whereas the spec mandates that it returns a count integer.

@ecorm ecorm changed the title wamp.session.kill_by_authrole does not exclude the caller wamp.session.kill_by_authrole does not follow spec May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants