Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use own unix::JoinHandleExt trait #651

Closed
taiki-e opened this issue Feb 6, 2021 · 0 comments · Fixed by #999
Closed

Use own unix::JoinHandleExt trait #651

taiki-e opened this issue Feb 6, 2021 · 0 comments · Fixed by #999

Comments

@taiki-e
Copy link
Member

taiki-e commented Feb 6, 2021

The standard library's extension traits are not intended to be implemented for types other than the standard library.
Actually, there are discussions about sealing them: rust-lang/rust#81213, rust-lang/rust#80634
As long as we actually have a crate that depends on it, the standard library won't seal it, but it seems preferable to use our own extension trait anyway.

impl<T> JoinHandleExt for ScopedJoinHandle<'_, T> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant