Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite fails when built without std feature. #840

Closed
plugwash opened this issue May 22, 2022 · 1 comment
Closed

Testsuite fails when built without std feature. #840

plugwash opened this issue May 22, 2022 · 1 comment
Labels

Comments

@plugwash
Copy link

plugwash commented May 22, 2022

Debian's CI runs tests with "--all-targets" and with various feature combinations. We found that crossbeam-epoch's testsuite fails when the "std" feature is not enabled.

https://ci.debian.net/data/autopkgtest/testing/amd64/r/rust-crossbeam-epoch/21986900/log.gz

I ground through the issues until I got the testsuite to pass, the patch can be found at

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/crossbeam-epoch/debian/patches/fix-tests-no-default-features.patch

@taiki-e
Copy link
Member

taiki-e commented May 24, 2022

This is semi-intentional and is fine since we don't have mutually exclusive features. See rust-lang/futures-rs#2216 for more. (Given how the cargo v1 resolver we use works, there isn't even a way to reliably test cases where specific (additive) features are disabled (dev or build dependencies may enable the features, and it will be shared with normal dependencies). Our nightly feature is not strictly additive, but our CI tests both cases where it is enabled and where it is not.)

If build errors of the test suite are a problem, I would accept PR to add cfg(feature = "std") to all tests at the module level.

@taiki-e taiki-e closed this as completed May 24, 2022
@taiki-e taiki-e closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants