Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AKS agent pools #262

Open
jbw976 opened this issue Jun 11, 2021 · 2 comments · May be fixed by #279
Open

Add support for AKS agent pools #262

jbw976 opened this issue Jun 11, 2021 · 2 comments · May be fixed by #279
Labels
enhancement New feature or request services

Comments

@jbw976
Copy link
Member

jbw976 commented Jun 11, 2021 •
edited

What problem are you facing?

AKS clusters currently have no way via Crossplane to use multiple node pools. Users that are running diverse workloads with specific needs are not able to partition them into separate classes of nodes/machines.

The docs for provider-azure show some fields for number of nodes and node size, but not for setting more details for the “agent pool” or declaring multiple of them: https://doc.crds.dev/github.com/crossplane/provider-azure/compute.azure.crossplane.io/AKSCluster/v1alpha3@v0.16.1

How could Crossplane help solve your problem?

We could create an agent pool managed resource to configure and manage a set of agent pools for the cluster, then the AKSCluster type could refer to these pools. This article describes some of the operational steps for reference: https://docs.microsoft.com/en-us/azure/aks/use-multiple-node-pools
@jbw976 jbw976 added the enhancement New feature or request label Jun 11, 2021
@bergerx
Copy link

bergerx commented Jun 11, 2021

The AKSCluster type could expose fields to configure and manage a set of agent pools for the cluster.

This statement could be misleading, and implementing the solution this way would be against how the crossplane aims to manage external resources. Even though some nodepool details are needed to create an AKS Cluster, nodepool is a different managed resource itself.

Here is a quote from the related thread in the slack:

I would expect the kind name for the managed resource to follow the azure go SDK's terminology. I find the "AKSCluster" name a bit weird in this respect (azure SDK for go uses ManagedCluster for AKSclusters and AgentPool for nodepools following the Azure Rest API).

@jbw976
Copy link
Member Author

jbw976 commented Jun 12, 2021

Good point @bergerx, thanks for calling that out! I've updated the description to make that more clear :)

@jbw976 jbw976 mentioned this issue Jun 30, 2021
Closed
@vaspahomov vaspahomov mentioned this issue Jul 27, 2021
Open
@vaspahomov vaspahomov linked a pull request Aug 3, 2021 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add AgentPool support vaspahomov/provider-azure
3 participants
@bergerx @luebken @jbw976