-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Maybe we can check whether we can use a dotted name such as gcp.jet
so that in other providers we can consider consistent short names such as aws.jet
, azure.jet
.
Just tested
|
It appears to be 3 more instances left that needs to be replaced:
I'll fix in a follow up PR. |
Thanks @turkenh. Could you please also update the description of this PR (and even maybe include the full instructions in the new one) so that as references they will be complete? |
@ulucinar done! |
This PR renames
tf
suffix asjet
to indicate this is a provider generated with Terrajet.As a reference for others who wants to do the same, here is the steps that I've applied:
And we also need to change the shortname, I preferred to change it from
tfgcp
togcpjet
but happy to discuss.