Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FederatedIdentityCredential fails to process patched parentId value correctly: parsing error #418

Open
lorsal opened this issue Mar 29, 2023 · 4 comments
Labels
bug Something isn't working needs:triage-stale

Comments

@lorsal
Copy link

lorsal commented Mar 29, 2023

What happened?

Creation of a FederatedIdentityCredential resource as part of a composition fails initially due to an error related to patching the spec.forProvider.parentId field (or processing the patched value, at least). However, after manually deleting the non-ready FederatedIdentityCredential object on the crossplane instance, the object is recreated and then successfully processes the patched parentId value.

Error:
observe failed: cannot run refresh: refresh failed: parsing "parentId/federatedIdentityCredentials/test1-fic": expected 10 segments within the Resource ID but got 3 for "parentId/federatedIdentityCredentials/test1-fic": parsing "parentId/federatedIdentityCredentials/test1-fic": expected 10 segments within the Resource ID but got 3 for "parentId/federatedIdentityCredentials/test1-fic"

How can we reproduce it?

  1. Create Azure provider config named azure-provider-config-team1
  2. Apply composition FedIdTest.yaml and XRD XFedIdTest.yaml
  3. Apply claim-fedidtest.yaml
  4. kubectl describe federatedidentitycredentials.managedidentity.azure.upbound.io test1-fic to see error message; note that the value is apparently already successfully patched to the parentId field
  5. kubectl delete federatedidentitycredentials.managedidentity.azure.upbound.io test1-fic
  6. watch kubectl get federatedidentitycredentials.managedidentity.azure.upbound.io test1-fic; object will be recreated and reach ready: true status

What environment did it happen in?

  • Universal Crossplane Version: 1.11.2-up.1
  • Provider Version: 0.29
  • Kubernetes version (use kubectl version): 1.25.5

FedIdTest.yaml.txt
XFedIdTest.yaml.txt
claim-fedidtest.yaml.txt

@sschne
Copy link

sschne commented Mar 28, 2024

This is still happening with current version:
Universal Crossplane Version: v1.15.1
Provider Version: 1.0.0
Kubernetes version (use kubectl version): 1.28.5

Anything i can help to get this issue forward?

      observe failed: failed to observe the resource: [{0 parsing "<no value>/federatedIdentityCredentials/test-j7gnh": parsing the FederatedIdentityCredential ID: the number of segments didn't match

      Expected a FederatedIdentityCredential ID that matched (containing 10 segments):

      > /subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/example-resource-group/providers/Microsoft.ManagedIdentity/userAssignedIdentities/userAssignedIdentityValue/federatedIdentityCredentials/federatedIdentityCredentialValue

      However this value was provided (which was parsed into 0 segments):

      > <no value>/federatedIdentityCredentials/test-j7gnh

@turkenf turkenf removed the community label May 7, 2024
Copy link

github-actions bot commented Aug 6, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 6, 2024
Copy link

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
@jusdor
Copy link

jusdor commented Aug 23, 2024

Please re-open. This is still relevant.

@mergenci mergenci reopened this Aug 26, 2024
@github-actions github-actions bot removed the stale label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:triage-stale
Projects
None yet
Development

No branches or pull requests

6 participants