Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userAssignedIdentity reference to AKS cluster #800

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

twobiers
Copy link

Description of your changes

This adds a missing cross reference to UserAssignedIdentities within AKS.
Fixes #662

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I couldn't test it, because I could not make make uptest work (installing: No such file or directory).
Hope that the CI pipeline can give me feedback.

Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
@turkenf
Copy link
Collaborator

turkenf commented Aug 21, 2024

/test-examples="examples/containerservice/v1beta2/kubernetescluster.yaml"

Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @twobiers, I left a few comments. After making your changes please run make generate and push them.

config/containerservice/config.go Outdated Show resolved Hide resolved
examples/containerservice/v1beta2/kubernetescluster.yaml Outdated Show resolved Hide resolved
examples/containerservice/v1beta2/kubernetescluster.yaml Outdated Show resolved Hide resolved
@twobiers
Copy link
Author

Thanks for the comments, I will look into that. Do you have any documentation regarding the development process (e.g. what should be run before filing a PR)? I cannot find detailed instructions how to contribute to the providers and make generate is not a valid target for me.
This would be helpful for the future.

@turkenf
Copy link
Collaborator

turkenf commented Aug 22, 2024

You can check this guide. It is a document about adding new resources, but it covers many scenarios (e.g., step 5 and testing Instructions).

Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
@twobiers
Copy link
Author

Thanks for the link and your comments. I managed to address and understand them now. Also I managed to make the makefile work. I missed initializing the build git submodule.

The next contribution will be smoother.

@twobiers
Copy link
Author

/test-examples="examples/containerservice/v1beta2/kubernetescluster-with-identity.yaml"

1 similar comment
@turkenf
Copy link
Collaborator

turkenf commented Aug 22, 2024

/test-examples="examples/containerservice/v1beta2/kubernetescluster-with-identity.yaml"

Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
@turkenf
Copy link
Collaborator

turkenf commented Aug 23, 2024

/test-examples="examples/containerservice/v1beta2/kubernetescluster-with-identity.yaml"

@twobiers
Copy link
Author

I don't understand what I'm missing out. It looks like in the e2e test crossplane is silently omitting the identityIdsSelector.

@turkenf
Copy link
Collaborator

turkenf commented Aug 27, 2024

I don't understand what I'm missing out. It looks like in the e2e test crossplane is silently omitting the identityIdsSelector.

It would be good to test it manually to understand exactly what is causing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants