-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add userAssignedIdentity reference to AKS cluster #800
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
856f415
to
3ef5af5
Compare
/test-examples="examples/containerservice/v1beta2/kubernetescluster.yaml" |
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
8770f5f
to
b94e019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @twobiers, I left a few comments. After making your changes please run make generate
and push them.
Thanks for the comments, I will look into that. Do you have any documentation regarding the development process (e.g. what should be run before filing a PR)? I cannot find detailed instructions how to contribute to the providers and |
You can check this guide. It is a document about adding new resources, but it covers many scenarios (e.g., step 5 and testing Instructions). |
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Thanks for the link and your comments. I managed to address and understand them now. Also I managed to make the makefile work. I missed initializing the The next contribution will be smoother. |
/test-examples="examples/containerservice/v1beta2/kubernetescluster-with-identity.yaml" |
1 similar comment
/test-examples="examples/containerservice/v1beta2/kubernetescluster-with-identity.yaml" |
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
/test-examples="examples/containerservice/v1beta2/kubernetescluster-with-identity.yaml" |
I don't understand what I'm missing out. It looks like in the e2e test crossplane is silently omitting the |
It would be good to test it manually to understand exactly what is causing it. |
Description of your changes
This adds a missing cross reference to UserAssignedIdentities within AKS.
Fixes #662
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
I couldn't test it, because I could not make
make uptest
work (installing: No such file or directory).Hope that the CI pipeline can give me feedback.