385: send event when resource is available to use #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: malachi.obadeyi <malachi.obadeyi@sainsburys.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is a suggested approach for issue #385. The change uses annotation to track if an event notifying that the external resource is available, has been created/sent . If a resource is "Available" and an event has not been sent the reconcile will create/send an event. I have not had any feedback regarding issue 385 so I thought this may be a good way of getting the discussion going if the issue was not clear.
Fixes #385:
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have added new tests testing that the annotation is added on the creation and the event is sent in the correct scenarios.