Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the reference pointer helper functions #762

Closed
jbw976 opened this issue Aug 30, 2024 · 0 comments · Fixed by #780
Closed

Deprecate the reference pointer helper functions #762

jbw976 opened this issue Aug 30, 2024 · 0 comments · Fixed by #780
Labels
release/api-deprecation release/breaking-api-change This PR will include a breaking change to the API when released.

Comments

@jbw976
Copy link
Member

jbw976 commented Aug 30, 2024

From @negz comment in: #754 (comment), copied here for convenience:

Huh, I actually forgot we had these pointer helpers in runtime.

We usually use https://pkg.go.dev/k8s.io/utils/ptr instead these days. I'd suggest that. We should probably deprecate the ones we have in runtime, but that can happen in a separate PR.

Source location: https://github.com/crossplane/crossplane-runtime/blob/master/pkg/reference/reference.go
@jbw976 jbw976 added release/breaking-api-change This PR will include a breaking change to the API when released. release/api-deprecation labels Aug 30, 2024
@jbw976 jbw976 moved this to Backlog in Crossplane Roadmap Aug 30, 2024
@cychiang cychiang mentioned this issue Oct 30, 2024
Merged
5 tasks
@negz negz closed this as completed in #780 Nov 4, 2024
@negz negz closed this as completed in 3cdde89 Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Crossplane Roadmap Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release/api-deprecation release/breaking-api-change This PR will include a breaking change to the API when released.
Projects
Crossplane Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate the reference pointer helper functions cychiang/crossplane-runtime
1 participant
@jbw976