This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #276 from turkenh/timeouts-to-state
Respect custom timeouts during refresh
- Loading branch information
Showing
4 changed files
with
379 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| /* | ||
| Copyright 2022 The Crossplane Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package terraform | ||
|
|
||
| import ( | ||
| "github.com/crossplane/crossplane-runtime/pkg/errors" | ||
|
|
||
| "github.com/crossplane/terrajet/pkg/config" | ||
| "github.com/crossplane/terrajet/pkg/resource/json" | ||
| ) | ||
|
|
||
| // "e2bfb730-ecaa-11e6-8f88-34363bc7c4c0" is a hardcoded string for Terraform | ||
| // timeout key in private raw, i.e. provider specific metadata: | ||
| // https://github.com/hashicorp/terraform-plugin-sdk/blob/112e2164c381d80e8ada3170dac9a8a5db01079a/helper/schema/resource_timeout.go#L14 | ||
| const tfMetaTimeoutKey = "e2bfb730-ecaa-11e6-8f88-34363bc7c4c0" | ||
|
|
||
| type timeouts config.OperationTimeouts | ||
|
|
||
| func (ts timeouts) asParameter() map[string]string { | ||
| param := make(map[string]string) | ||
| if t := ts.Read.String(); t != "0s" { | ||
| param["read"] = t | ||
| } | ||
| if t := ts.Create.String(); t != "0s" { | ||
| param["create"] = t | ||
| } | ||
| if t := ts.Update.String(); t != "0s" { | ||
| param["update"] = t | ||
| } | ||
| if t := ts.Delete.String(); t != "0s" { | ||
| param["delete"] = t | ||
| } | ||
| return param | ||
| } | ||
|
|
||
| func (ts timeouts) asMetadata() map[string]interface{} { | ||
| // See how timeouts encoded as metadata on Terraform side: | ||
| // https://github.com/hashicorp/terraform-plugin-sdk/blob/112e2164c381d80e8ada3170dac9a8a5db01079a/helper/schema/resource_timeout.go#L170 | ||
| meta := make(map[string]interface{}) | ||
| if t := ts.Read.String(); t != "0s" { | ||
| meta["read"] = ts.Read.Nanoseconds() | ||
| } | ||
| if t := ts.Create.String(); t != "0s" { | ||
| meta["create"] = ts.Create.Nanoseconds() | ||
| } | ||
| if t := ts.Update.String(); t != "0s" { | ||
| meta["update"] = ts.Update.Nanoseconds() | ||
| } | ||
| if t := ts.Delete.String(); t != "0s" { | ||
| meta["delete"] = ts.Delete.Nanoseconds() | ||
| } | ||
| return meta | ||
| } | ||
|
|
||
| func insertTimeoutsMeta(existingMeta []byte, to timeouts) ([]byte, error) { | ||
| customTimeouts := to.asMetadata() | ||
| if len(customTimeouts) == 0 { | ||
| // No custom timeout configured, nothing to do. | ||
| return existingMeta, nil | ||
| } | ||
| meta := make(map[string]interface{}) | ||
| if len(existingMeta) == 0 { | ||
| // No existing data, just initialize a new meta with custom timeouts. | ||
| meta[tfMetaTimeoutKey] = customTimeouts | ||
| return json.JSParser.Marshal(meta) | ||
| } | ||
| // There are some existing metadata, let's parse it to insert custom | ||
| // timeouts properly. | ||
| if err := json.JSParser.Unmarshal(existingMeta, &meta); err != nil { | ||
| return nil, errors.Wrap(err, "cannot parse existing metadata") | ||
| } | ||
| if existingTimeouts, ok := meta[tfMetaTimeoutKey].(map[string]interface{}); ok { | ||
| // There are some timeout configuration exists in existing metadata. | ||
| // Only override custom timeouts. | ||
| for k, v := range customTimeouts { | ||
| existingTimeouts[k] = v | ||
| } | ||
| return json.JSParser.Marshal(meta) | ||
| } | ||
| // No existing timeout configuration, initialize it with custom timeouts. | ||
| meta[tfMetaTimeoutKey] = customTimeouts | ||
| return json.JSParser.Marshal(meta) | ||
| } |
Oops, something went wrong.