Upgrade crossplane-runtime to v1.17.0 #437
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smcavallo smcavallo@hotmail.com
Description of your changes
Upgrade crossplane-runtime to v1.17.0 with associated new implementations
See - https://github.com/crossplane/crossplane-runtime/releases/tag/v1.17.0
Implements
Disconnect
onExternalClient
interfaceSee - crossplane/crossplane-runtime#754
Implements
ExternalDelete
return type on methodExternalClient.Delete()
See - crossplane/crossplane-runtime#296
Upgrades go per error below:
go: module github.com/crossplane/crossplane-runtime@v1.17.0 requires go >= 1.22.0; switching to go1.22.7
When attempting to upgrade an upjet-based provider to
v1.17.0
ofcrossplane-runtime
the below error is generated.This PR should resolve that and allow consumers to upgrade to the newer runtime.
This is a breaking change in that any consumer who uses the newer version of
upjet
will also be forced to upgrade the newer version ofcrossplane-runtime
(and also go >= 1.22.0)Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested