Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference usage example and fix broken links in configuring a resource doc #403

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented May 15, 2024

Description of your changes

In this PR, the example regarding manual reference addition has been updated with the TerraformName field and broken links have been corrected.

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Copy link
Member

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf 🙏 I especially value documentation updates. I have one suggestion below, if you would like to consider.

docs/configuring-a-resource.md Outdated Show resolved Hide resolved
docs/configuring-a-resource.md Show resolved Hide resolved
@turkenf turkenf force-pushed the update-resource-config-doc branch from 158cfa9 to a042b4e Compare May 30, 2024 13:24
@turkenf turkenf closed this May 30, 2024
@turkenf turkenf reopened this May 30, 2024
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.

docs/configuring-a-resource.md Outdated Show resolved Hide resolved
@turkenf turkenf force-pushed the update-resource-config-doc branch 2 times, most recently from 90d8be9 to 121c1f2 Compare June 5, 2024 10:34
@turkenf turkenf closed this Jun 5, 2024
@turkenf turkenf reopened this Jun 5, 2024
…resource doc

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf force-pushed the update-resource-config-doc branch from 121c1f2 to d10aa6e Compare June 6, 2024 07:39
@ulucinar ulucinar merged commit 58f4ba3 into crossplane:main Jun 10, 2024
6 checks passed
@turkenf turkenf deleted the update-resource-config-doc branch June 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants