Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color serialization/deserialization doesn't support "Reset" value #823

Closed
Destroy666x opened this issue Sep 20, 2023 · 0 comments · Fixed by #824
Closed

Color serialization/deserialization doesn't support "Reset" value #823

Destroy666x opened this issue Sep 20, 2023 · 0 comments · Fixed by #824

Comments

@Destroy666x
Copy link
Contributor

Destroy666x commented Sep 20, 2023

Is your feature request related to a problem? Please describe.
Color serialization/deserialization doesn't support Reset value:

These mappings/tests lack it:

"black" => Ok(Color::Black),

Color::Black => "black",

assert_eq!("grey".parse(), Ok(Color::Grey));

serde_json::from_str::<Color>("\"Red\"").unwrap(),

etc.

I don't see why it's missing, other than someone just forgetting to add it, but maybe I'm missing something - if so let me know.

Describe the solution you'd like
Serialize/deserialize Reset value too.

Describe alternatives you've considered if any
-

Additional context
Would fix e.g. lsd-rs/lsd#896 / lsd-rs/lsd#607 without any need for workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant