Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect y-axis time values in helicorder examples #32

Closed
rbeerster opened this issue Dec 19, 2023 · 2 comments
Closed

Incorrect y-axis time values in helicorder examples #32

rbeerster opened this issue Dec 19, 2023 · 2 comments

Comments

@rbeerster
Copy link
Contributor

In both helicorder examples, https://crotwell.github.io/seisplotjs/gallery/helicorder.html and https://crotwell.github.io/seisplotjs/examples/helicorder/index.html, the y-axis time values (yLabel and yLabelRight) are incorrect. Here is a diff from the .mjs file for seismographconfig.ts file that made it work, but I am not confident that this is the correct fix:

53951c53951
<     return this.__cache__.yLabelHandlebarsCompiled(context, runtimeOptions);
---
>     return  this.__cache__.yLabelHandlebarsCompiled = Handlebars.compile(this._yLabel);
53993,53995c53993
<         this.__cache__.yLabelRightHandlebarsCompiled = Handlebars.compile(
<           this._yLabelRight
<         );
---
>         this.__cache__.yLabelRightHandlebarsCompiled = Handlebars.compile(this._yLabelRight);
54001c53999,54000
<     return this.__cache__.yLabelRightHandlebarsCompiled(context, runtimeOptions);
---
>     // return this.__cache__.yLabelRightHandlebarsCompiled(context, runtimeOptions);
>     return this.__cache__.yLabelRightHandlebarsCompiled = Handlebars.compile(this._yLabelRight);

I hope this helps track down the real issue.

@crotwell
Copy link
Owner

a cache was not being cleared, believe fixed in 2b14fb1 but please test

thanks for bug report

@rbeerster
Copy link
Contributor Author

This seems to have corrected the yLabel and yLabelRight values.

@crotwell crotwell closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants