Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAPI] Pass request context to all database queries #3089

Open
LaurenceJJones opened this issue Jun 19, 2024 · 3 comments
Open

[LAPI] Pass request context to all database queries #3089

LaurenceJJones opened this issue Jun 19, 2024 · 3 comments

Comments

@LaurenceJJones
Copy link
Contributor

Currently when a user requests an endpoint that does a SQL query the underlying context that is passed is the context of the database client, however, if the user cancels the request the SQL query is not abandoned.

https://github.com/crowdsecurity/crowdsec/blob/4521a98ecc34cf4beeee653f1eb5914f1879f42d/pkg/apiserver/controllers/v1/alerts.go#L278C22-L293

This may be something we want to aim for LAPI v2 as it might be a big refactor

@LaurenceJJones LaurenceJJones changed the title [APIC] Pass request context to all database queries [LAPI] Pass request context to all database queries Jun 19, 2024
Copy link

@LaurenceJJones: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

  1. Check Crowdsec Documentation to see if your issue can be self resolved.
  2. You can also join our Discord.
  3. Check Releases to make sure your agent is on the latest version.
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind bug
  • /kind packaging
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor

mmetc commented Jun 19, 2024

#3073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants