Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ignore non json responses in xhr notification interceptor #55

Merged

Conversation

dmurat
Copy link
Member

@dmurat dmurat commented Jan 19, 2024

Basic information

  • @croz/nrich-notification-core version: v1.1.1
  • Module:
    • @croz/nrich-notification-core

Description

The xhrNotificationInterceptor throws an error when dealing with non-JSON responses.

Summary

Update xhrNotificationInterceptor to ignore non-JSON responses

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 3298e99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@croz/nrich-notification-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c44b45) 99.43% compared to head (3298e99) 99.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          25       25           
  Lines         177      178    +1     
  Branches       24       24           
=======================================
+ Hits          176      177    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtomic-croz jtomic-croz merged commit 88aef81 into master Jan 22, 2024
1 check passed
@jtomic-croz jtomic-croz deleted the feature_ignoreNonJsonResponsesInXhrNotificationInterceptor branch January 22, 2024 08:32
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants