Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing config file check does not create PR when main branch becomes available #255

Closed
ilveroluca opened this issue Nov 4, 2022 · 1 comment
Assignees
Labels
bug Something isn't working high-priority

Comments

@ilveroluca
Copy link
Member

I installed the LM app on a completely empty repository. The first check that runs is the "Missing config file" check. It noticed that the LM configuration file was missing. I suppose because there was no branch onto which to open a PR, it opened an issue with the text:

No lifemonitor.yaml configuration file found on this repository.
The lifemonitor.yaml should be placed on the root of this repository.

I later created a main branch, but the check did not open a PR with a configuration template.

Suggested fix.

  • If reasonably feasible, the check should notice that the branch has been created after its first run and create a PR with the configuration template. It would also be nice if the check could add a comment to the original issue referencing the new PR, or alternatively if it could close the issue.
  • If this is too hard, we should at least extend the text of the issue to provide a link to a template file for the configuration and maybe even to the documentation on how to complete it.
@kikkomep
Copy link
Member

fixed in #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

2 participants