Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release configuration #104

Open
aalmiray opened this issue Apr 24, 2023 · 3 comments
Open

Release configuration #104

aalmiray opened this issue Apr 24, 2023 · 3 comments

Comments

@aalmiray
Copy link

At first glance I would have expected the following configuration to throw an exception

artifact {
distributionType = 'BINARY'
path = "changelogs/${canonicalVersion}.txt"
extraProperties.put('universal', true)
transform = 'changelog.txt'
}

The distributionType property is owned by the distribution (named app) and not by the artifact DSL element.

@crschnick
Copy link
Owner

crschnick commented Apr 24, 2023

I guess it works fine because no task depends the distribution type property as I only use the GitHub release. The jreleaser configuration here is very old and bad as I had no idea what I was doing back when I first created it. It should probably be updated sometime.

@aalmiray
Copy link
Author

OK. Moreover, I suppose releases are done offline. Here's a way to run releases on GitHub targeting multiple platforms

https://github.com/kordamp/ikonli/blob/master/jreleaser.yml
https://github.com/kordamp/ikonli/blob/master/.github/workflows/release.yml

The project is a JavaFX application that also relies on beryx's plugins to build the jlink runtimes and native installers via jpackage.

@crschnick
Copy link
Owner

crschnick commented Apr 24, 2023

They are done on CI by running each OS separately and updating the body of the release. I already use your linked workflow approach in xpipe, it's just that I didn't also implement it here. This is mostly because the current approach also works even though it's a little bit ugly. I will probably do a complete rewrite of the jreleaser configuration someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants