Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load database silently #36

Closed
Robinlovelace opened this issue Aug 7, 2018 · 5 comments
Closed

Load database silently #36

Robinlovelace opened this issue Aug 7, 2018 · 5 comments

Comments

@Robinlovelace
Copy link
Contributor

Robinlovelace commented Aug 7, 2018

Here's an idea related to #23 : instead of loading the database in the shiny app (which freezes the entire RStudio session) could you not make that part of it happen in silent, either in the current R session (with a loading bar?) before launching the app, or in a new process created by the future pkg or similar on the first time the link is made?

@crsh
Copy link
Owner

crsh commented Aug 7, 2018

Yes, that's definitely a good idea. I'm currently a little overwhelmed with other projects, but improving the speed of the Zotero connection is high up on my priority list for this package.

One thing I'm wondering about: In the development version it's possible to access shared group libraries in addition to the personal Zotero library. It may not always be desirable to import all libraries (and in my use case this can take a long time). The addin therefore allows users to specify which libraries to load. If the Zotero database is loaded before the addin is executed it would have to import all libraries. If this happens in a separate session, I guess that may be feasible. In addition the libraries could be stored separately and merged and accessed only if specified in the addin. However, I'm not sure how to handle the situation when the libraries are still being imported when the addin is called. Any suggestions?

@Robinlovelace
Copy link
Contributor Author

I see your points re capacity (know the feeling!) and libraries. However I think that loading all citations is a good default: think of the person starting a project. It's most useful to have access to all available citations when you're doing a search. The 'silent load' option wouldn't actually need to make it any faster, would just delay the launch of the app, allowing the user to continue writing prose while the R session does its business before launching into shiny. Please wait, loading DB would be useful too.

@crsh
Copy link
Owner

crsh commented Aug 7, 2018

Ah, I see what you are suggesting. That makes sense. I'll look into it. Thanks!

@crsh
Copy link
Owner

crsh commented Oct 16, 2019

Closing in favor of #55

@crsh crsh closed this as completed Oct 16, 2019
@Robinlovelace
Copy link
Contributor Author

Agreed, sorry for duplicating my own issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants