diff --git a/cstrml/staking/src/benchmarking.rs b/cstrml/staking/src/benchmarking.rs index bd669db6..2610ec12 100644 --- a/cstrml/staking/src/benchmarking.rs +++ b/cstrml/staking/src/benchmarking.rs @@ -42,9 +42,8 @@ pub fn create_stash_controller(n: u32) -> Result<(T::AccountId, T::Ac let stash = create_funded_user::("stash", n); let controller = create_funded_user::("controller", n); let controller_lookup: ::Source = T::Lookup::unlookup(controller.clone()); - let reward_destination = RewardDestination::Staked; let amount = T::Currency::minimum_balance() * ACCOUNT_BALANCE_RATIO.into(); - Staking::::bond(RawOrigin::Signed(stash.clone()).into(), controller_lookup, amount, reward_destination)?; + Staking::::bond(RawOrigin::Signed(stash.clone()).into(), controller_lookup, amount)?; return Ok((stash, controller)) } @@ -113,9 +112,8 @@ benchmarks! { let stash = create_funded_user::("stash",100); let controller = create_funded_user::("controller", 100); let controller_lookup: ::Source = T::Lookup::unlookup(controller); - let reward_destination = RewardDestination::Staked; let amount = T::Currency::minimum_balance() * 10u32.into(); - }: _(RawOrigin::Signed(stash), controller_lookup, amount, reward_destination) + }: _(RawOrigin::Signed(stash), controller_lookup, amount) bond_extra { @@ -131,9 +129,8 @@ benchmarks! { let controller = create_funded_user::("controller", 100); let controller_lookup: ::Source = T::Lookup::unlookup(controller.clone()); let max_additional = T::Currency::minimum_balance() * 10u32.into(); - let reward_destination = RewardDestination::Staked; let amount = T::Currency::minimum_balance() * 10u32.into(); - Staking::::bond(RawOrigin::Signed(stash.clone()).into(), controller_lookup, amount, reward_destination)?; + Staking::::bond(RawOrigin::Signed(stash.clone()).into(), controller_lookup, amount)?; }: _(RawOrigin::Signed(controller), max_additional) @@ -143,9 +140,8 @@ benchmarks! { let controller = create_funded_user::("controller", 100); let controller_lookup: ::Source = T::Lookup::unlookup(controller.clone()); let max_additional = T::Currency::minimum_balance() * 10u32.into(); - let reward_destination = RewardDestination::Staked; let amount = T::Currency::minimum_balance() * 10u32.into(); - Staking::::bond(RawOrigin::Signed(stash.clone()).into(), controller_lookup, amount, reward_destination)?; + Staking::::bond(RawOrigin::Signed(stash.clone()).into(), controller_lookup, amount)?; Staking::::unbond(RawOrigin::Signed(controller.clone()).into(), max_additional)?; }: _(RawOrigin::Signed(controller.clone())) @@ -175,14 +171,6 @@ benchmarks! { let (_, controller) = create_stash_controller::(100)?; }: _(RawOrigin::Signed(controller)) - set_payee { - let (stash, controller) = create_stash_controller::(100)?; - assert_eq!(Payee::::get(&stash), RewardDestination::Staked); - }: _(RawOrigin::Signed(controller), RewardDestination::Controller) - verify { - assert_eq!(Payee::::get(&stash), RewardDestination::Controller); - } - set_controller { let (stash, _) = create_stash_controller::(100)?; let new_controller = create_funded_user::("new_controller", 100); @@ -252,7 +240,6 @@ mod tests { assert_ok!(test_benchmark_new_era::()); assert_ok!(test_benchmark_select_and_update_validators::()); assert_ok!(test_benchmark_chill::()); - assert_ok!(test_benchmark_set_payee::()); assert_ok!(test_benchmark_set_controller::()); assert_ok!(test_benchmark_withdraw_unbonded::()); }); diff --git a/cstrml/staking/src/lib.rs b/cstrml/staking/src/lib.rs index f1305218..27e12f74 100644 --- a/cstrml/staking/src/lib.rs +++ b/cstrml/staking/src/lib.rs @@ -668,8 +668,7 @@ decl_storage! { let _ = >::bond( T::Origin::from(Some(stash.clone()).into()), T::Lookup::unlookup(controller.clone()), - balance, - RewardDestination::Staked, + balance ); gensis_total_stakes += balance; @@ -847,8 +846,7 @@ decl_module! { #[weight = T::WeightInfo::bond()] fn bond(origin, controller: ::Source, - #[compact] value: BalanceOf, - payee: RewardDestination + #[compact] value: BalanceOf ) { let stash = ensure_signed(origin)?; @@ -870,7 +868,7 @@ decl_module! { // You're auto-bonded forever, here. We might improve this by only bonding when // you actually validate/guarantee and remove once you unbond __everything__. >::insert(&stash, &controller); - >::insert(&stash, payee); + >::insert(&stash, RewardDestination::Staked); let current_era = CurrentEra::get().unwrap_or(0); let history_depth = Self::history_depth(); @@ -1220,29 +1218,6 @@ decl_module! { Self::deposit_event(RawEvent::ChillSuccess(controller, ledger.stash)); } - /// (Re-)set the payment target for a controller. - /// - /// Effects will be felt at the beginning of the next era. - /// - /// The dispatch origin for this call must be _Signed_ by the controller, not the stash. - /// - /// # - /// - Independent of the arguments. Insignificant complexity. - /// - Contains a limited number of reads. - /// - Writes are limited to the `origin` account key. - /// --------- - /// - DB Weight: - /// - Read: Ledger - /// - Write: Payee - /// # - #[weight = T::WeightInfo::set_payee()] - fn set_payee(origin, payee: RewardDestination) { - let controller = ensure_signed(origin)?; - let ledger = Self::ledger(&controller).ok_or(Error::::NotController)?; - let stash = &ledger.stash; - >::insert(stash, payee); - } - /// (Re-)set the controller of a stash. /// /// Effects will be felt at the beginning of the next era. diff --git a/cstrml/staking/src/mock.rs b/cstrml/staking/src/mock.rs index d2bca69c..f00763ed 100644 --- a/cstrml/staking/src/mock.rs +++ b/cstrml/staking/src/mock.rs @@ -609,9 +609,9 @@ pub fn bond_validator(acc: u128, val: Balance) { assert_ok!(Staking::bond( Origin::signed(acc + 1), acc, - val, - RewardDestination::Controller + val )); + assert_ok!(set_payee(acc, RewardDestination::Controller)); Staking::upsert_stake_limit(&(acc + 1), u128::max_value()); assert_ok!(Staking::validate(Origin::signed(acc), ValidatorPrefs::default())); } @@ -623,9 +623,9 @@ pub fn bond_guarantor(acc: u128, val: Balance, targets: Vec<(u128, Balance)>) { assert_ok!(Staking::bond( Origin::signed(acc + 1), acc, - val, - RewardDestination::Controller + val )); + assert_ok!(set_payee(acc, RewardDestination::Controller)); for target in targets { assert_ok!(Staking::guarantee(Origin::signed(acc), target)); } @@ -769,4 +769,11 @@ pub fn staking_rewards_in_era(era_index: EraIndex) -> BalanceOf { let total_reward = Staking::total_rewards_in_era(era_index); let authoring_reward = authoring_rewards_in_era(era_index); total_reward.saturating_sub(authoring_reward) +} + +pub fn set_payee(controller: u128, payee: RewardDestination) -> Result<(), ()> { + let ledger = Staking::ledger(&controller).unwrap(); + let stash = &ledger.stash; + >::insert(stash, payee); + Ok(()) } \ No newline at end of file diff --git a/cstrml/staking/src/tests.rs b/cstrml/staking/src/tests.rs index caec6687..b2852484 100644 --- a/cstrml/staking/src/tests.rs +++ b/cstrml/staking/src/tests.rs @@ -220,9 +220,9 @@ fn validate_punishment_should_work() { assert_ok!(Staking::bond( Origin::signed(5), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); Staking::upsert_stake_limit(&5, 3000); assert_eq!(>::contains_key(5, 5), false); @@ -272,13 +272,13 @@ fn rewards_should_work() { let init_balance_20 = Balances::total_balance(&20); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(20), + assert_ok!(set_payee( + 20, RewardDestination::Controller )); @@ -385,8 +385,8 @@ fn multi_era_reward_should_work() { let init_balance_21 = Balances::total_balance(&21); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -461,8 +461,8 @@ fn era_reward_with_dsm_staking_pot_should_work() { let init_balance_21 = Balances::total_balance(&21); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -538,8 +538,8 @@ fn era_reward_with_used_fee_should_work() { let init_balance_21 = Balances::total_balance(&21); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -620,9 +620,9 @@ fn staking_should_work() { assert_ok!(Staking::bond( Origin::signed(3), 4, - 2500, - RewardDestination::Controller + 2500 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); Staking::upsert_stake_limit(&3, 3000); assert_ok!(Staking::validate(Origin::signed(4), ValidatorPrefs::default())); @@ -752,20 +752,20 @@ fn guaranteeing_and_rewards_should_work() { assert_eq_uvec!(validator_controllers(), vec![10, 20]); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); - assert_ok!(Staking::set_payee( - Origin::signed(20), + assert_ok!(set_payee( + 20, RewardDestination::Controller )); - assert_ok!(Staking::set_payee( - Origin::signed(30), + assert_ok!(set_payee( + 30, RewardDestination::Controller )); - assert_ok!(Staking::set_payee( - Origin::signed(40), + assert_ok!(set_payee( + 40, RewardDestination::Controller )); @@ -780,9 +780,9 @@ fn guaranteeing_and_rewards_should_work() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::guarantee( Origin::signed(2), (31, 333) @@ -799,9 +799,9 @@ fn guaranteeing_and_rewards_should_work() { assert_ok!(Staking::bond( Origin::signed(3), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::guarantee( Origin::signed(4), (31, 333) @@ -1021,8 +1021,8 @@ fn guarantors_also_get_slashed() { assert_eq!(Staking::validator_count(), 2); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(20), + assert_ok!(set_payee( + 20, RewardDestination::Controller )); @@ -1037,8 +1037,7 @@ fn guarantors_also_get_slashed() { assert_ok!(Staking::bond( Origin::signed(1), 2, - guarantor_stake, - RewardDestination::default() + guarantor_stake )); // but it won't work, cause 10&20 are not validators assert_noop!( @@ -1113,16 +1112,14 @@ fn double_staking_should_fail() { assert_ok!(Staking::bond( Origin::signed(1), 2, - arbitrary_value, - RewardDestination::default() + arbitrary_value )); // 4 = not used so far, 1 stashed => not allowed. assert_noop!( Staking::bond( Origin::signed(1), 4, - arbitrary_value, - RewardDestination::default() + arbitrary_value ), Error::::AlreadyBonded, ); @@ -1162,16 +1159,14 @@ fn double_controlling_should_fail() { assert_ok!(Staking::bond( Origin::signed(1), 2, - arbitrary_value, - RewardDestination::default(), + arbitrary_value )); // 2 = controller, 3 stashed (Note that 2 is reused.) => no-op assert_noop!( Staking::bond( Origin::signed(3), 2, - arbitrary_value, - RewardDestination::default() + arbitrary_value ), Error::::AlreadyPaired, ); @@ -1794,8 +1789,8 @@ fn bond_extra_and_withdraw_unbonded_works() { .build() .execute_with(|| { // Set payee to controller. avoids confusion - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -1980,8 +1975,8 @@ fn rebond_works() { .build() .execute_with(|| { // Set payee to controller. avoids confusion - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -2125,8 +2120,8 @@ fn rebond_is_fifo() { .build() .execute_with(|| { // Set payee to controller. avoids confusion - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -2386,8 +2381,8 @@ fn on_free_balance_zero_stash_removes_validator() { // Set some storage items which we expect to be cleaned up // Set payee information - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Stash )); @@ -2446,8 +2441,8 @@ fn on_free_balance_zero_stash_removes_guarantor() { assert_eq!(Balances::free_balance(&11), 256000); // Set payee information - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Stash )); @@ -2501,8 +2496,8 @@ fn switching_roles() { // Reset reward destination for i in &[10, 20] { - assert_ok!(Staking::set_payee( - Origin::signed(*i), + assert_ok!(set_payee( + *i, RewardDestination::Controller )); } @@ -2518,18 +2513,18 @@ fn switching_roles() { assert_ok!(Staking::bond( Origin::signed(5), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(6), ValidatorPrefs::default())); // add 2 guarantors assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::guarantee( Origin::signed(2), (11, 1000) @@ -2542,9 +2537,9 @@ fn switching_roles() { assert_ok!(Staking::bond( Origin::signed(3), 4, - 500, - RewardDestination::Controller + 500 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::guarantee( Origin::signed(4), (21, 250) @@ -2618,8 +2613,7 @@ fn wrong_vote_is_null() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::default() + 2000 )); assert_ok!(Staking::guarantee( Origin::signed(2), @@ -2674,16 +2668,16 @@ fn bond_with_no_staked_value() { .execute_with(|| { // Can't bond with 1 assert_noop!( - Staking::bond(Origin::signed(1), 2, 1, RewardDestination::Controller), + Staking::bond(Origin::signed(1), 2, 1), Error::::InsufficientValue, ); // bonded with absolute minimum value possible. assert_ok!(Staking::bond( Origin::signed(1), 2, - 5, - RewardDestination::Controller + 5 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_eq!(Balances::locks(&1)[0].amount, 5); // unbonding even 1 will cause all to be unbonded. @@ -2729,8 +2723,8 @@ fn bond_with_little_staked_value_bounded_by_total_stakes() { .execute_with(|| { // setup assert_ok!(Staking::chill(Origin::signed(30))); - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); let init_balance_2 = Balances::free_balance(&2); @@ -2740,9 +2734,9 @@ fn bond_with_little_staked_value_bounded_by_total_stakes() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 2, - RewardDestination::Controller + 2 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); Staking::upsert_stake_limit(&1, u128::max_value()); assert_ok!(Staking::validate(Origin::signed(2), ValidatorPrefs::default())); @@ -2825,8 +2819,8 @@ fn reward_with_no_stake_limit() { .execute_with(|| { // setup assert_ok!(Staking::chill(Origin::signed(30))); - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); let _ = Balances::make_free_balance_be(&7, 100); @@ -2837,9 +2831,9 @@ fn reward_with_no_stake_limit() { assert_ok!(Staking::bond( Origin::signed(7), 8, - 100, - RewardDestination::Controller + 100 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(8), ValidatorPrefs::default())); let total_authoring_payout = authoring_rewards_in_era(Staking::current_era().unwrap_or(0)); @@ -2982,8 +2976,7 @@ fn reward_validator_slashing_validator_doesnt_overflow() { Staking::bond( Origin::signed(2), 20000, - stake - 1, - RewardDestination::default(), + stake - 1 ) .unwrap(); >::insert( @@ -3892,30 +3885,30 @@ fn update_stakers_should_work_new_era() { assert_ok!(Staking::bond( Origin::signed(5), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(3), 2, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(7), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(9), 8, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); Staking::upsert_stake_limit(&5, 3000); assert_ok!(Staking::validate(Origin::signed(4), ValidatorPrefs::default())); @@ -3986,43 +3979,43 @@ fn eras_stakers_clipped_should_work_new_era() { assert_ok!(Staking::bond( Origin::signed(5), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(111), 110, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(110, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(113), 112, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(112, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(115), 114, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(114, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(117), 116, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(116, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(119), 118, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(118, RewardDestination::Controller)); Staking::upsert_stake_limit(&5, 4000); assert_ok!(Staking::validate(Origin::signed(4), ValidatorPrefs::default())); @@ -4121,18 +4114,18 @@ fn guarantee_should_work() { assert_ok!(Staking::bond( Origin::signed(5), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(6), ValidatorPrefs::default())); // add guarantor, bond with 2000 assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); // New guarantee ✅ assert_ok!(Staking::guarantee(Origin::signed(2), (5, 1000))); @@ -4251,9 +4244,9 @@ fn multi_guarantees_should_work() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::guarantee(Origin::signed(2), (11, 250))); assert_ok!(Staking::guarantee(Origin::signed(2), (11, 250))); @@ -4261,9 +4254,9 @@ fn multi_guarantees_should_work() { assert_ok!(Staking::bond( Origin::signed(3), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::guarantee(Origin::signed(4), (11, 2000))); // guarantor's info guarantors should ✅ @@ -4364,34 +4357,34 @@ fn cut_guarantee_should_work() { assert_ok!(Staking::bond( Origin::signed(5), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(6), ValidatorPrefs::default())); assert_ok!(Staking::bond( Origin::signed(7), 8, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(8), ValidatorPrefs::default())); // Add guarantor 1 assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); // Add guarantor 3 assert_ok!(Staking::bond( Origin::signed(3), 4, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); // Guarantor's info guarantors should ✅ assert_eq!( @@ -4525,27 +4518,27 @@ fn new_era_with_stake_limit_should_work() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::guarantee(Origin::signed(2), (11, 2000))); // Add guarantor assert_ok!(Staking::bond( Origin::signed(3), 4, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::guarantee(Origin::signed(4), (11, 3000))); // Add validator without stake limit assert_ok!(Staking::bond( Origin::signed(7), 8, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(8), ValidatorPrefs::default())); start_era_with_new_workloads(5, false, 1, 200000000); @@ -4602,34 +4595,34 @@ fn chill_stash_should_work() { assert_ok!(Staking::bond( Origin::signed(5), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(6), ValidatorPrefs::default())); // add a new validator candidate assert_ok!(Staking::bond( Origin::signed(7), 8, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(8), ValidatorPrefs::default())); // add guarantor assert_ok!(Staking::bond( Origin::signed(1), 2, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); // add guarantor assert_ok!(Staking::bond( Origin::signed(3), 4, - 2000, - RewardDestination::Controller + 2000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::guarantee(Origin::signed(2), (5, 250))); assert_ok!(Staking::guarantee(Origin::signed(2), (5, 250))); @@ -4738,8 +4731,8 @@ fn double_claim_rewards_should_fail() { let init_balance_31 = Balances::total_balance(&31); // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(10), + assert_ok!(set_payee( + 10, RewardDestination::Controller )); @@ -4809,8 +4802,8 @@ fn era_clean_should_work() { .build() .execute_with(|| { // Set payee to controller - assert_ok!(Staking::set_payee( - Origin::signed(20), + assert_ok!(set_payee( + 20, RewardDestination::Controller )); >::reward_by_ids(vec![(21, 1)]); @@ -4843,7 +4836,7 @@ fn payout_to_any_account_works() { bond_guarantor(1337, 100, vec![(111, 50)]); // Update payout location - assert_ok!(Staking::set_payee(Origin::signed(1337), RewardDestination::Account(42))); + assert_ok!(set_payee(1337, RewardDestination::Account(42))); // Reward Destination account doesn't exist assert_eq!(Balances::free_balance(42), 0); @@ -4881,27 +4874,27 @@ fn update_stage_one_stake_limit_according_to_mpow_should_work() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(3), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(5), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(7), 8, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(2), ValidatorPrefs::default())); assert_ok!(Staking::validate(Origin::signed(4), ValidatorPrefs::default())); assert_ok!(Staking::validate(Origin::signed(6), ValidatorPrefs::default())); @@ -4942,27 +4935,27 @@ fn update_stage_two_stake_limit_according_to_mpow_should_work() { assert_ok!(Staking::bond( Origin::signed(1), 2, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(2, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(3), 4, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(4, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(5), 6, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(6, RewardDestination::Controller)); assert_ok!(Staking::bond( Origin::signed(7), 8, - 1000, - RewardDestination::Controller + 1000 )); + assert_ok!(set_payee(8, RewardDestination::Controller)); assert_ok!(Staking::validate(Origin::signed(2), ValidatorPrefs::default())); assert_ok!(Staking::validate(Origin::signed(4), ValidatorPrefs::default())); assert_ok!(Staking::validate(Origin::signed(6), ValidatorPrefs::default()));