Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoopAuthManager reports authentication scheme as Basic #729

Closed
jan-law opened this issue Oct 18, 2021 · 0 comments · Fixed by #730
Closed

NoopAuthManager reports authentication scheme as Basic #729

jan-law opened this issue Oct 18, 2021 · 0 comments · Fixed by #730
Assignees
@jan-law
Labels
bug Something isn't working

Comments

@jan-law
Copy link
Contributor

jan-law commented Oct 18, 2021

The NoopAuthManager reports its authenticate scheme (X-WWW-Authenticate response header) as Basic - we could change this on the backend to be some other value to differentiate it from Basic auth. It could respond with None, for example, which is also what the Apache HTTP server responds with in a similar scenario. I think we could then implement a NoopAuth frontend component that just immediately calls its onSubmit prop on load. What do you think?

Originally posted by @andrewazores in cryostatio/cryostat-web#321 (comment)
@andrewazores andrewazores added the bug Something isn't working label Oct 18, 2021
@jan-law jan-law self-assigned this Oct 18, 2021
@jan-law jan-law mentioned this issue Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-law jan-law

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(auth): Fix Noop authentication scheme jan-law/cryostat
2 participants
@andrewazores @jan-law