Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all ApiService request functions return a useable boolean where it makes sense #336

Closed
hareetd opened this issue Nov 4, 2021 · 0 comments · Fixed by #352
Closed

Ensure all ApiService request functions return a useable boolean where it makes sense #336

hareetd opened this issue Nov 4, 2021 · 0 comments · Fixed by #352
Assignees
@hareetd
Labels
chore Refactor, rename, cleanup, etc.

Comments

@hareetd
Copy link
Contributor

hareetd commented Nov 4, 2021

Any functions sending the actual requests in the ApiService should return an Observable-wrapped boolean that can be used by callers to make conditional actions.
@hareetd hareetd added the chore Refactor, rename, cleanup, etc. label Nov 4, 2021
@hareetd hareetd self-assigned this Nov 4, 2021
@hareetd hareetd changed the title Ensure all ApiService request functions return a useable boolean Ensure all ApiService request functions return a useable boolean where it makes sense Dec 13, 2021
@hareetd hareetd mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hareetd hareetd

Labels
chore Refactor, rename, cleanup, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ApiService): Ensure all API requests return a useable boolean where it makes sense
1 participant
@hareetd