Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target-specific archives table displays archived recording for different target after notification #420

Closed
jan-law opened this issue Apr 27, 2022 · 2 comments · Fixed by #422
Assignees
Labels
bug Something isn't working

Comments

@jan-law
Copy link
Contributor

jan-law commented Apr 27, 2022

To reproduce:

  1. Recordings > Select cryostat container cryostat:9091 and go to Archived Recordings table
  2. Open a second web client tab > Recordings > Select quarkus container on cryostat:9096
  3. On second web client, start a recording on cryostat:9096
  4. Archive the recording on cryostat:9096
  5. Open the first web client tab. The archived recording from cryostat:9096 appears on the table, even though the table should only show the archived recordings for cryostat:9091. Refreshing the page shows the correct list of archived recordings.
@jan-law jan-law added the bug Something isn't working label Apr 27, 2022
@andrewazores
Copy link
Member

Nice find. It sounds like the table is listening for notifications to update its state, but it isn't checking that the target field of the notification matches the currently selected target. The table or its parent view must already have a reference to the frontend target service that can tell it what the currently selected target is, so the fix is to just filter the incoming notifications for only those that match the currently selected target.

@andrewazores
Copy link
Member

@jan-law do you want to take a stab at this one yourself? This should go into 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants