Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Target deletion button is clickable on non-custom targets #498

Closed
andrewazores opened this issue Aug 16, 2022 · 0 comments · Fixed by #502
Closed

[Bug] Target deletion button is clickable on non-custom targets #498

andrewazores opened this issue Aug 16, 2022 · 0 comments · Fixed by #502
Assignees
@maxcao13
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Only custom targets, defined by the user, are deletable. Clicking the deletion icon when any other target is selected results in an error message. Instead, the deletion button should simply be disabled if the selected target is not from a custom target definition.

Depends on https://github.com/cryostatio/cryostat/issues/1043
@andrewazores andrewazores added the bug Something isn't working label Aug 16, 2022
@andrewazores andrewazores moved this to Todo in 2.2.0 Release Aug 16, 2022
@maxcao13 maxcao13 mentioned this issue Aug 29, 2022
Merged
@maxcao13 maxcao13 moved this from Todo to In Progress in 2.2.0 Release Sep 1, 2022
@maxcao13 maxcao13 self-assigned this Sep 1, 2022
Repository owner moved this from In Progress to Done in 2.2.0 Release Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxcao13 maxcao13

Labels
bug Something isn't working
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(targets): disable delete button on non-custom targets maxcao13/cryostat-web
2 participants
@andrewazores @maxcao13