Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Target selection should allow filtering #666

Closed
tthvo opened this issue Nov 17, 2022 · 2 comments · Fixed by #891
Closed

[Task] Target selection should allow filtering #666

tthvo opened this issue Nov 17, 2022 · 2 comments · Fixed by #891
Assignees
Labels
design feat New feature or request

Comments

@tthvo
Copy link
Member

tthvo commented Nov 17, 2022

Right now, the target select menu will just show a plain list and will expand as needed. I think we should limit its size and allow filters. Or perhaps a new design for this.

Related to #429

@tthvo tthvo added the feat New feature or request label Nov 17, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 17, 2022
@tthvo
Copy link
Member Author

tthvo commented Nov 17, 2022

Hey @andrewazores, just have a thought about this when looking through the OpenShift console.

Do you think we could have a separate side-card tab for target view (Topology) as here but with some tweaks? Other pages can just use context selector similar to how we select namespace in OpenShift?

Screenshot from 2022-11-17 13-44-39

This way we can have some initial setup for multi-namespace support as we discussed. Also, filters can be supported here too. I guess this would mean all operations on target list (i.e. add, delete, edit) must be done only on this new side-car tab.

@tthvo tthvo added the design label Nov 17, 2022
@andrewazores
Copy link
Member

Sure, I like that idea. It's a good upgrade from where our UX is now at least. I think the question of how to display things when the user wants to select multiple targets, or a higher order node from the tree, is still open ("start a recording on every target below this Deployment"), but at least this way we get a way to visualize those higher order nodes and see some of the relationships between targets.

@tthvo tthvo self-assigned this Nov 17, 2022
@tthvo tthvo mentioned this issue Nov 18, 2022
9 tasks
@tthvo tthvo mentioned this issue Feb 21, 2023
42 tasks
@tthvo tthvo moved this from Todo to In Progress in 2.3.0 release Mar 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2.3.0 release Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants