Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] If multiple matching stored credentials are found, should Cryostat try to use each? #376

Open
andrewazores opened this issue Apr 16, 2024 · 0 comments
Labels
bug Something isn't working feat New feature or request question Further information is requested

Comments

@andrewazores
Copy link
Member

Describe the feature

Cryostat currently selects the "first" matching credential and uses that to attach credentials to outgoing target connections. If each target has 0 or 1 matching stored credentials then this works as expected.

However, the user(s) may have defined multiple credentials whose matchExpressions are a match for any given target.

If there are multiple matching credentials available, should Cryostat try to use each one until one of them succeeds? If that happens then should Cryostat somehow cache this result? What if there are multiple valid credentials because there are multiple defined JMX users with different roles (readonly vs readwrite) for the target's JMX server?

If the user(s) have defined two credentials for target A, one of which is valid and the other is invalid, then Cryostat might always select the invalid credentials for that target and never be able to establish a connection, even though there are valid credentials defined.

For example, defining a credential like { matchExpression: "true", username: "a", password: "b" } is acceptable, but Cryostat is likely to select this credential for targets which have JMX authentication enabled and have other credentials defined. This credential's existence blocks Cryostat from being able to establish any connections to targets using authentication (assuming a:b is not actually what the target expects).

Anything other information?

No response

@andrewazores andrewazores added question Further information is requested feat New feature or request bug Something isn't working labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat New feature or request question Further information is requested
Projects
Status: Backlog
Status: Stretch Goals
Development

No branches or pull requests

1 participant