Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Automated Rules do not re-fire if initial Target connection attempt fails #731

Open
andrewazores opened this issue Dec 2, 2024 · 0 comments · May be fixed by #732
Open

[Bug] Automated Rules do not re-fire if initial Target connection attempt fails #731

andrewazores opened this issue Dec 2, 2024 · 0 comments · May be fixed by #732
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

andrewazores commented Dec 2, 2024

Current Behavior

In the case that Cryostat is up and running with an Automated Rule definition, and a new Target application appears which matches the Rule's MatchExpression, then Cryostat sees the new Target and that the Rule should apply to it, and tries to start a new Flight Recording on the Target.

If this Flight Recording creation attempt fails, ex. in case of socket timeout because the Target is not actually ready yet or there is some network issue, then the Automated Rule will never activate on that Target. The Target would need to be destroyed or recreated, or the Rule deleted/recreated or disabled/enabled, or a dummy Stored Credential needs to be made that causes the Rule to re-trigger.

Expected Behavior

If the Target connection attempt fails, then the Automated Rule service should automatically retry starting a recording on the same Target again. This should follow some scheme like an exponential backoff with a maximum number of retries. Once the maximum number of retries is hit, or the attempt succeeds, then Cryostat should stop retrying.

Steps To Reproduce

No response

Environment

No response

Anything else?

quarkusio/quarkus#24607 could be useful.

@andrewazores andrewazores added the bug Something isn't working label Dec 2, 2024
@andrewazores andrewazores moved this to Backlog in 4.0.0 release Dec 2, 2024
@andrewazores andrewazores self-assigned this Dec 3, 2024
@andrewazores andrewazores moved this from Backlog to In progress in 4.0.0 release Dec 3, 2024
@andrewazores andrewazores linked a pull request Dec 3, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

1 participant