This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: dev-utils generates incorrect app hash #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - dev-utils use `genesis_time` from `genesis.json`, rather than `dev-utils.json` - Remove `genesis_time` field from `dev-utils.json`
yihuang
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
devashishdxt
approved these changes
Dec 19, 2019
calvinaco
approved these changes
Dec 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
=========================================
+ Coverage 70.08% 70.1% +0.01%
=========================================
Files 131 131
Lines 16597 16592 -5
=========================================
- Hits 11632 11631 -1
+ Misses 4965 4961 -4
|
|
bors r+ |
leejw51crypto
approved these changes
Dec 19, 2019
bors bot
added a commit
that referenced
this pull request
Dec 19, 2019
703: Problem: dev-utils generates incorrect app hash r=tomtau a=yihuang Solution: - dev-utils use `genesis_time` from `genesis.json`, rather than `dev-utils.json` - Remove `genesis_time` field from `dev-utils.json` 704: Problem (CRO-668): app hash keep changing on every empty block r=tomtau a=yihuang Solution: - Fix the bug: `last_distribution_time` not updated after rewards distribution. - Added unit testing to prevent this happen again. Co-authored-by: yihuang <yi.codeplayer@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
genesis_timefromgenesis.json, rather thandev-utils.jsongenesis_timefield fromdev-utils.json