This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: client-cli sync hangs after sync complete #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Drop syncer before join progress reporting thread.
yihuang
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
devashishdxt
approved these changes
Dec 24, 2019
|
bors r+ |
calvinaco
approved these changes
Dec 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 69.71% 69.71% +<.01%
==========================================
Files 131 131
Lines 16745 16746 +1
==========================================
+ Hits 11673 11674 +1
Misses 5072 5072
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Drop syncer before join progress reporting thread.