Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: cryptographic library code diverged from "planned" upstream #1143

Closed
tomtau opened this issue Feb 27, 2020 · 0 comments
Closed

Problem: cryptographic library code diverged from "planned" upstream #1143

tomtau opened this issue Feb 27, 2020 · 0 comments
Assignees
@tomtau
Milestone
CRO Sprint 25

Comments

@tomtau
Copy link
Contributor

tomtau commented Feb 27, 2020

Ref #757

while it hasn't been merged to upstream, BIP has been stabilised as: https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki

and there are some notable differences from the old fork we're using, e.g. x-only pubkey representation or tagged hash

can update the fork to "catch up", so there are less surprises
@tomtau tomtau added this to the CRO Sprint 25 milestone Feb 27, 2020
@tomtau tomtau self-assigned this Feb 27, 2020
tomtau added a commit to tomtau/chain that referenced this issue Mar 2, 2020
@tomtau
Problem: cryptographic library code diverged from "planned" upstream (f…
507b5b0 
…ixes crypto-com#1143)

Solution:
- cherry-picked changes from the planned upstream changes to the *temporary* custom secp256k1 fork
- adapted the *temporary* Rust library fork to it
- changed chain-core witness structure to use the BIP-340 encoding of public keys
- adapted client and tests to it

NOTE:
the schnorrsig proposal was stabilized as https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki
the code wasn't yet merged to upstream, so it's possible that underlying cryptographic API
may change (and the corresponding Rust), but the transaction (binary/serialized) payloads
will be the same.
tomtau added a commit to tomtau/chain that referenced this issue Mar 3, 2020
@tomtau
Problem: cryptographic library code diverged from "planned" upstream (f…
28ea5f9 
…ixes crypto-com#1143)

Solution:
- cherry-picked changes from the planned upstream changes to the *temporary* custom secp256k1 fork
- adapted the *temporary* Rust library fork to it
- changed chain-core witness structure to use the BIP-340 encoding of public keys
- adapted client and tests to it

NOTE:
the schnorrsig proposal was stabilized as https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki
the code wasn't yet merged to upstream, so it's possible that underlying cryptographic API
may change (and the corresponding Rust), but the transaction (binary/serialized) payloads
will be the same.
bors bot added a commit that referenced this issue Mar 3, 2020
@bors @tomtau
Merge #1162
ad2d5cd 
1162: Problem: cryptographic library code diverged from "planned" upstream (fixes #1143) r=tomtau a=tomtau

Solution:
- cherry-picked changes from the planned upstream changes to the *temporary* custom secp256k1 fork
- adapted the *temporary* Rust library fork to it
- changed chain-core witness structure to use the BIP-340 encoding of public keys
- adapted client and tests to it

NOTE:
the schnorrsig proposal was stabilized as https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki
the code wasn't yet merged to upstream, so it's possible that underlying cryptographic API
may change (and the corresponding Rust), but the transaction (binary/serialized) payloads
will be the same.


Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@bors bors bot closed this as completed in 59ae2c1 Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomtau tomtau

Labels
None yet
Projects
None yet
Milestone
CRO Sprint 25
Development

No branches or pull requests
1 participant
@tomtau