Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: v0.50.x is outdated #809

Merged
merged 130 commits into from
Sep 30, 2024
Merged

Problem: v0.50.x is outdated #809

merged 130 commits into from
Sep 30, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 30, 2024 •
edited
Loading

Description

for more info

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

dependabot bot and others added 30 commits March 21, 2024 16:09
@dependabot @github-actions
build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (c…
87ad797 
…osmos#19811)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mergify @akaladarshi
@tac0turtle @julienrbrt
feat(x/gov): emit proposer address in submit proposal event (backport c…
a0faab3 
…osmos#19842) (cosmos#19844)

Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @devbull25 @julienrbrt
feat(x/gov): emit depositor in proposal_deposit event (backport cos…
9c53142 
…mos#19853) (cosmos#19859)

Co-authored-by: Kien <kien@notional.ventures>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@yihuang
reuse fromAddrString (minor cleanup) (cosmos#19881)
d78edac
@mergify
feat(client): replace event-query-tx-for with wait-tx (backport c…
8641cd2 
…osmos#19870) (cosmos#19887)
@mergify @julienrbrt
feat(server): add custom start handler (backport cosmos#19854) (cosmo…
7b35e36 
…s#19884)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@dependabot @github-actions
@tac0turtle @julienrbrt
build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810)
405471b 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify
docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (c…
f63e5fd 
…osmos#19925)
@dependabot @github-actions @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#…
4b71767 
…19985)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @julienrbrt
fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin (backport
525b720 
cosmos#19976) (cosmos#20001)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @GAtom22
@tac0turtle @julienrbrt
fix(mempool): use no-op mempool as default (backport cosmos#19970) (c…
f76c659 
…osmos#20008)

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @lucaslopezf @julienrbrt
feat: Conditionally emit metrics based on enablement (backport cosmos…
974a24c 
…#19903) (cosmos#20017)

Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @mmsqe
fix(x/bank): align query with multi denoms for send-enabled (backport c…
452632f 
…osmos#20028) (cosmos#20029)

Co-authored-by: mmsqe <mavis@crypto.com>
@mergify @facundomedica
fix: Implement gogoproto customtype to secp256r1 keys (backport cosmo…
521ebe5 
…s#20027) (cosmos#20031)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
@mergify @mmsqe
fix(client/v2): respect output format from client ctx (backport cosmo…
741b01c 
…s#20033) (cosmos#20046)

Co-authored-by: mmsqe <mavis@crypto.com>
@dependabot @github-actions @julienrbrt
build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042)
d6a0fa1 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify
feat(x/bank): support depinject for send restrictions (backport cosmo…
dafcc78 
…s#20014) (cosmos#20024)
@mergify
fix(baseapp): don't share global gas meter in tx execution (backport c…
9941498 
…osmos#19616) (cosmos#20050)
@mergify @facundomedica
fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069
49c3ae6 
)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
@dependabot
build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to…
a2abf1a 
… 1.0.0-beta.5 (cosmos#20095)
@mergify @julienrbrt
feat(client/v2): implement version filtering using annotation (backport
2a32f42 
cosmos#20083) (cosmos#20099)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt
chore: prepare v0.50.6 (cosmos#19998)
4bd0e02
@mergify @mmsqe
fix: use timestamp for sim log file name (backport cosmos#20108) (cos…
0a682f7 
…mos#20111)

Co-authored-by: mmsqe <mavis@crypto.com>
@julienrbrt
fix(x/authz,x/feegrant): check blocked address (cosmos#20102)
fcb9d84
@julienrbrt
chore: update v0.50.6 release notes (cosmos#20124)
c4d9a49
@julienrbrt
build(deps): bump sdk in modules (cosmos#20126)
a42a85a
@mergify @samricotta
docs(gas/fees): Update block gas documentation (backport cosmos#20128) (
3437fd5 
cosmos#20131)

Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>
@mergify @mmsqe @julienrbrt
fix(baseapp): avoid header height overwrite block height (backport co…
7828a00 
…smos#20107) (cosmos#20129)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify
docs: fix broken link (backport cosmos#20133) (cosmos#20138)
ad8c205
@julienrbrt
build(deps): bump modules in simapp (cosmos#20137)
bb9f451
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2024
View reviewed changes
baseapp/abci.go
halt = true

case app.haltTime > 0 && time.Unix() > int64(app.haltTime):
case app.haltTime > 0 && time.Unix() >= int64(app.haltTime):

Check failure

Code scanning / Golang security checks by gosec

integer overflow conversion uint64 -> uint8 Error

integer overflow conversion uint64 -> int64
x/group/simulation/operations.go
groupID = uint64(simtypes.RandIntBetween(r, int(initialGroupID), int(groupID)))
// select a random ID between (initialGroupID, groupID]
// if there is at least one group information, then the groupID at this time must be greater than or equal to 1
groupID = uint64(simtypes.RandIntBetween(r, int(initialGroupID+1), int(groupID+1)))

Check failure

Code scanning / Golang security checks by gosec

integer overflow conversion uint64 -> uint8 Error

integer overflow conversion uint64 -> int
x/group/simulation/operations.go
groupID = uint64(simtypes.RandIntBetween(r, int(initialGroupID), int(groupID)))
// select a random ID between (initialGroupID, groupID]
// if there is at least one group information, then the groupID at this time must be greater than or equal to 1
groupID = uint64(simtypes.RandIntBetween(r, int(initialGroupID+1), int(groupID+1)))

Check failure

Code scanning / Golang security checks by gosec

integer overflow conversion uint64 -> uint8 Error

integer overflow conversion uint64 -> int
x/tx/signing/aminojson/internal/testpb/test.pulsar.go
break
}
}
fieldNum := int32(wire >> 3)

Check failure

Code scanning / Golang security checks by gosec

integer overflow conversion uint64 -> uint8 Error test

integer overflow conversion uint64 -> int32
x/tx/signing/aminojson/internal/testpb/test.pulsar.go
}
}
fieldNum := int32(wire >> 3)
wireType := int(wire & 0x7)

Check failure

Code scanning / Golang security checks by gosec

integer overflow conversion uint64 -> uint8 Error test

integer overflow conversion uint64 -> int
@mmsqe mmsqe marked this pull request as ready for review September 30, 2024 01:31
@mmsqe mmsqe requested a review from yihuang September 30, 2024 01:31
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2024
View reviewed changes
client/v2/autocli/flag/enum.go
Comment on lines +62 to +64
for k := range e.valMap {
validValues = append(validValues, k)
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
x/tx/signing/aminojson/internal/testpb/test.pulsar.go
x.Field1 = value.Bytes()
default:
if fd.IsExtension() {
panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.WithAJson"))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning test

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
x/tx/signing/aminojson/internal/testpb/test.pulsar.go
if fd.IsExtension() {
panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.WithAJson"))
}
panic(fmt.Errorf("message testpb.WithAJson does not contain field %s", fd.FullName()))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning test

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@mmsqe mmsqe enabled auto-merge (squash) September 30, 2024 01:53
@mmsqe mmsqe merged commit f4ea363 into crypto-org-chain:release/v0.50.x Sep 30, 2024
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yihuang yihuang yihuang approved these changes

Assignees
No one assigned
Labels
C:CLI C:collections C:Confix C:Cosmovisor C:Hubl C:Keys C:orm C:Simulations C:Store C:x/auth C:x/authz C:x/bank C:x/circuit C:x/consensus C:x/evidence C:x/feegrant C:x/genutil C:x/group C:x/nft C:x/staking C:x/tx C:x/upgrade Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmsqe @yihuang @julienrbrt @tac0turtle @facundomedica