Problem: sim tests fails #1394

yihuang · 2024-04-15T23:48:49Z

Solution:

add icahost wiring, but disable in parameters

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

New Features
- Introduced a new, but initially disabled, feature related to "icahost wirings" for enhanced interchain account functionalities.
- Added middleware and routing updates to support the icahost module in interchain accounts.
Refactor
- Updated imports and added new keepers for interchain account management.
Tests
- Enhanced simulation tests to explicitly set the chain ID during context initialization.
Chores
- Implemented mock subspace for parameter handling in the interchain accounts module.
- Updated upgrade handling logic to set parameters and perform actions based on upgrade data.

coderabbitai · 2024-04-15T23:48:58Z

Walkthrough

The recent update introduces a new feature related to "icahost wirings" in the software, focusing on interchain accounts. Although the feature is added across several files, it's not enabled by default. Changes include the addition of new modules, keepers, and middleware, as well as adjustments to existing test setups and upgrade handling mechanisms.

Changes

Files	Change Summary
`CHANGELOG.md`	Added a new feature related to "icahost wirings", disabled by default.
`app/app.go`, `app/icahost.go`	Introduced new imports, keepers, and middleware for the interchain accounts module; added a mock subspace for handling parameters.
`app/sim_test.go`	Modified test setups to explicitly set the chain ID.
`app/upgrades.go`	Enhanced upgrade handling logic, involving setting parameters and reading upgrade information.

🐰✨
In the land of code, where the bits align,
A new feature sprouts, 'tis yet to shine.
With wirings so vast, in silence it waits,
For the flip of a switch, to open the gates.
Hop, hop, hurray, for changes so bright,
In the burrows of data, they bring new light! 🌟
🐰💻

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8bbc74d and d617ac0.

Files selected for processing (1)

app/icahost.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/icahost.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yihuang · 2024-04-15T23:49:03Z

/runsim

github-actions · 2024-04-15T23:49:44Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

github-actions · 2024-04-15T23:52:29Z

❌ /runsim simulation test has failed 😅
Please further check here

coderabbitai

Actionable comments posted: 1

CHANGELOG.md

yihuang · 2024-04-16T00:02:52Z

/runsim

github-actions · 2024-04-16T00:07:02Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

coderabbitai

Actionable comments posted: 1

CHANGELOG.md

github-actions · 2024-04-16T00:08:30Z

❌ /runsim simulation test has failed 😅
Please further check here

codecov · 2024-04-16T00:09:51Z

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 35.38%. Comparing base (eda35d7) to head (d617ac0).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   35.42%   35.38%   -0.05%     
==========================================
  Files         123      124       +1     
  Lines        9422     9440      +18     
==========================================
+ Hits         3338     3340       +2     
- Misses       5727     5741      +14     
- Partials      357      359       +2

Files	Coverage Δ
app/icahost.go	`0.00% <0.00%> (ø)`
app/upgrades.go	`19.04% <11.11%> (-20.96%)`	⬇️

github-actions · 2024-04-16T00:20:52Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

app/app.go

github-actions · 2024-04-16T00:34:04Z

❌ /runsim simulation test has failed 😅
Please further check here

mmsqe · 2024-04-16T01:20:00Z

Might need wait a bit cosmos/ibc-go#6167

yihuang · 2024-04-16T01:22:02Z

/runsim

github-actions · 2024-04-16T01:23:04Z

❌ /runsim simulation test has failed 😅
Please further check here

github-actions · 2024-04-16T01:24:36Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

github-actions · 2024-04-16T01:25:52Z

❌ /runsim simulation test has failed 😅
Please further check here

github-actions · 2024-04-16T01:28:04Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

github-actions · 2024-04-16T01:28:53Z

❌ /runsim simulation test has failed 😅
Please further check here

yihuang · 2024-04-16T01:51:06Z

/runsim

github-actions · 2024-04-16T01:51:42Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

github-actions · 2024-04-16T02:13:25Z

❌ /runsim simulation test has failed 😅
Please further check here

yihuang · 2024-04-16T03:02:41Z

/runsim

github-actions · 2024-04-16T03:03:17Z

Simulation tests get triggered and started by /runsim.
Please check further progress here

github-actions · 2024-04-16T03:24:59Z

✅ /runsim simulation test has succeeded 🎉
Please further check here

coderabbitai

Actionable comments posted: 1

app/icahost.go

Solution: - add icahost wiring, but disable in parameters fix build Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> Update app/app.go Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com> Update app/app.go Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com> fix chain-id fix upgrade add missing file Update app/icahost.go Signed-off-by: yihuang <huang@crypto.com>

coderabbitai

Actionable comments posted: 1

app/icahost.go

yihuang requested a review from a team as a code owner April 15, 2024 23:48

yihuang requested review from calvinaco and leejw51crypto and removed request for a team April 15, 2024 23:48

coderabbitai bot reviewed Apr 15, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

yihuang commented Apr 16, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

coderabbitai bot reviewed Apr 16, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

mmsqe reviewed Apr 16, 2024

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

mmsqe reviewed Apr 16, 2024

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

coderabbitai bot reviewed Apr 16, 2024

View reviewed changes

app/icahost.go Show resolved Hide resolved

mmsqe approved these changes Apr 16, 2024

View reviewed changes

yihuang commented Apr 16, 2024

View reviewed changes

app/icahost.go Outdated Show resolved Hide resolved

yihuang force-pushed the block-stm branch from 84d8c08 to 8bbc74d Compare April 16, 2024 06:49

yihuang enabled auto-merge April 16, 2024 06:49

fix comment

24fb742

coderabbitai bot reviewed Apr 16, 2024

View reviewed changes

app/icahost.go Outdated Show resolved Hide resolved

fix lint

d617ac0

yihuang added this pull request to the merge queue Apr 16, 2024

Merged via the queue into crypto-org-chain:main with commit 90fc8be Apr 16, 2024
36 of 37 checks passed

coderabbitai bot mentioned this pull request Apr 19, 2024

Problem: panic on invalid elasticity_multiplier #1397

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem: sim tests fails #1394

Problem: sim tests fails #1394

yihuang commented Apr 15, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 15, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

yihuang commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

coderabbitai bot left a comment

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

coderabbitai bot left a comment

github-actions bot commented Apr 16, 2024

codecov bot commented Apr 16, 2024 •

edited

Loading

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

mmsqe commented Apr 16, 2024 •

edited

Loading

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

Problem: sim tests fails #1394

Problem: sim tests fails #1394

Conversation

yihuang commented Apr 15, 2024 • edited by coderabbitai bot Loading

PR Checklist:

Summary by CodeRabbit

coderabbitai bot commented Apr 15, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

yihuang commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 16, 2024

codecov bot commented Apr 16, 2024 • edited Loading

Codecov Report

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

mmsqe commented Apr 16, 2024 • edited Loading

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

yihuang commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

github-actions bot commented Apr 16, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

yihuang commented Apr 15, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 15, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 16, 2024 •

edited

Loading

mmsqe commented Apr 16, 2024 •

edited

Loading