-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing transactions while looping through eth_getBlockByNumber
#268
Comments
https://rpc-cronos.crypto.org/block_results?height=114161
There's this tx result in this block, I think it's the same issue that tx is executed successfully, but tx result is an error. |
The transaction details in the
|
will be fixed by this: cosmos/cosmos-sdk#10814 |
the fix will be released in 0.7.0 upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
We are indexing transactions related to
VVS-LP
ownership and found that some of the owners are havingnegative balance
. For example, this wallet0xf6173b4D45B5052650e252499b80F02C24b9d14e
, when we check itsToken Transfers
history, it is able to send out1,889.994 VVS-LP
in transaction0x8228af30adf6a0bade750573b8f05d2d05472b83d4f7b9bb9a3616df6bb76477
(block number:114172
) without any transfers going in before that. By studying thebalanceOf
the wallet in the LP token contract, we found that the balance changed from0
to1889994255148034566603
at block114161
, which leads to the following bug we found.Describe the bug
Previously, when we call
eth_getBlockByNumber(114161)
, we are able to get 47 transactions. When we further query the last 15 transactions, 14 of them are actually in the block with height114162
and one of them (with hash0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b
) doesn't seem to be in any block. This behaviour cannot be reproduced anymore andeth_getBlockByNumber(114161)
now will return 32 transactions. (Note: this is a behaviour in cronos node 0.6.2)However,
0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b
is still missing in any blocks and we are not able to retrieve that by callingeth_getTransactionByHash
. This transaction is important because it is the transaction that the wallet address mentioned above0xf6173b4D45B5052650e252499b80F02C24b9d14e
minting theVVS-LP
token. So we think theeth_getBlockByNumber
andeth_getTransactionByHash
is missing out some transactions.To Reproduce
cronos-node
0.6.2
, calleth_getBlockByNumber('0x1BDF1', true)
and you will be able to see transaction0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b
at index32
cronos-node
0.6.2
, calleth_getTransactionByHash('0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b')
will returnnull
cronos-node
0.6.4
, calleth_getBlockByNumber('0x1BDF1', true)
and the transaction will not appear anymorecronos-node
0.6.4
, calleth_getTransactionByHash('0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b')
will returnnull
Expected behavior
0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b
should appear ineth_getBlockByNumber('0x1BDF1', true)
andeth_getTransactionByHash('0x9f1dd8a13508658db35f21bc00e7c490a79aa8686fc1ba4669eea4b479a7fb3b')
should return transaction details.Screenshots
N/A
Additional context
See
Background
.The text was updated successfully, but these errors were encountered: