Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: inconsistent logic regarding experimental gravity module in genesis import/export #635

Closed
yihuang opened this issue Aug 12, 2022 · 1 comment
Closed

Problem: inconsistent logic regarding experimental gravity module in genesis import/export #635

yihuang opened this issue Aug 12, 2022 · 1 comment

Comments

@yihuang
Copy link
Collaborator

yihuang commented Aug 12, 2022 •
edited
Loading

Found by @JayT106

When not passing --unsafe-experimental flag, the current behavior is like this:

  • init genesis, the genesis file does include gravity section
  • export, the output genesis file doesn't include the gravity section
  • validate-genesis, will fail if it doesn't include the gravity section

The root cause is the global app.ModuleBasics always includes the gravity module disregarding the experimental flag.

Change the validate-genesis and export command to have correct module list according to experimental flag.
@JayT106 JayT106 mentioned this issue Aug 15, 2022
Open
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 18, 2022

fixed by #639

@yihuang yihuang closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yihuang