Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: empty topics in rpc response is not tested #254

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Problem: empty topics in rpc response is not tested #254

merged 1 commit into from
Jan 17, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 14, 2021

Closes: #841

Solution:

  • merge empty topics fix
  • add integration tests to verify

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner December 14, 2021 07:26
@yihuang yihuang requested review from JayT106 and thomas-nguy and removed request for a team December 14, 2021 07:26
calvinaco
calvinaco approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@calvinaco calvinaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 14, 2021 •
edited
Loading

Codecov Report

Merging #254 (8980ba4) into main (3ea70c5) will increase coverage by 3.21%.
The diff coverage is 0.33%.

❗ Current head 8980ba4 differs from pull request most recent head eb00700. Consider uploading reports for the commit eb00700 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   21.51%   24.72%   +3.21%     
==========================================
  Files          27       34       +7     
  Lines        1729     2572     +843     
==========================================
+ Hits          372      636     +264     
- Misses       1324     1888     +564     
- Partials       33       48      +15
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/genesis.go 61.53% <ø> (-38.47%) ⬇️
x/cronos/handler.go 100.00% <ø> (ø)
x/cronos/keeper/evm.go 56.31% <ø> (+4.58%) ⬆️
x/cronos/keeper/evm_hooks.go 80.00% <ø> (ø)
x/cronos/keeper/evm_log_handlers.go 83.50% <ø> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/grpc_query.go 0.00% <ø> (ø)
x/cronos/keeper/ibc.go 83.20% <ø> (+5.01%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e2af7...eb00700. Read the comment docs.

yihuang added a commit to yihuang/cronos that referenced this pull request Dec 14, 2021
@yihuang
Problem: empty topics in rpc response is not tested
64c767d 
backport: crypto-org-chain#254

Solution:
- merge empty topics fix
- add integration tests to verify
@yihuang yihuang mentioned this pull request Dec 14, 2021
Merged
13 tasks
yihuang added a commit to yihuang/cronos that referenced this pull request Dec 14, 2021
@yihuang
Problem: empty topics in rpc response is not tested
36d6972 
backport: crypto-org-chain#254

Solution:
- merge empty topics fix
- add integration tests to verify
yihuang
yihuang commented Dec 14, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
yihuang added a commit to yihuang/cronos that referenced this pull request Dec 14, 2021
@yihuang
Problem: empty topics in rpc response is not tested
7e06738 
backport: crypto-org-chain#254

Solution:
- merge empty topics fix
- add integration tests to verify
yihuang added a commit to yihuang/cronos that referenced this pull request Dec 16, 2021
@yihuang
Problem: empty topics in rpc response is not tested
0f2262e 
backport: crypto-org-chain#254

Solution:
- merge empty topics fix
- add integration tests to verify

Update integration_tests/shell.nix
yihuang added a commit to yihuang/cronos that referenced this pull request Dec 17, 2021
@yihuang
Problem: empty topics in rpc response is not tested
3821950 
backport: crypto-org-chain#254

Solution:
- merge empty topics fix
- add integration tests to verify

Update integration_tests/shell.nix
yihuang added a commit to yihuang/cronos that referenced this pull request Dec 21, 2021
@yihuang
Problem: empty topics in rpc response is not tested
5e42eef 
backport: crypto-org-chain#254

Solution:
- merge empty topics fix
- add integration tests to verify

Update integration_tests/shell.nix

Update CHANGELOG.md
yihuang added a commit that referenced this pull request Dec 21, 2021
@yihuang
Problem: empty topics in rpc response is not tested (#255)
fb7db2e 
backport: #254

Solution:
- merge empty topics fix
- add integration tests to verify

Update integration_tests/shell.nix
@thomas-nguy
Copy link
Collaborator

to make this change more clear, can we separate the ethermint version increase in a different PR?

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 21, 2021

integration test failure is due to this issue: evmos/ethermint#851

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 21, 2021

to make this change more clear, can we separate the ethermint version increase in a different PR?

sounds good.

@yihuang yihuang marked this pull request as draft January 4, 2022 02:47
@yihuang yihuang force-pushed the test-log0 branch 2 times, most recently from 120ac7d to 366d065 Compare January 17, 2022 01:23
@yihuang
Problem: empty topics in rpc response is not tested
eb00700 
Closes: crypto-org-chain#841

Solution:
- merge empty topics fix
- add integration tests to verify
@yihuang yihuang marked this pull request as ready for review January 17, 2022 05:59
@yihuang yihuang merged commit 0f1b3de into crypto-org-chain:main Jan 17, 2022
@yihuang yihuang deleted the test-log0 branch January 17, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinaco calvinaco calvinaco approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

@thomas-nguy thomas-nguy Awaiting requested review from thomas-nguy thomas-nguy is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @thomas-nguy @calvinaco