forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid channel get changed when concurrent subscribe happens (backport: #1773) #247
Merged
mmsqe
merged 6 commits into
crypto-org-chain:release/v0.20.x-cronos
from
mmsqe:release/v0.20.x-cronos-backport-1773
May 18, 2023
Merged
fix: avoid channel get changed when concurrent subscribe happens (backport: #1773) #247
mmsqe
merged 6 commits into
crypto-org-chain:release/v0.20.x-cronos
from
mmsqe:release/v0.20.x-cronos-backport-1773
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/v0.20.x-cronos #247 +/- ##
==========================================================
- Coverage 56.68% 52.56% -4.13%
==========================================================
Files 108 113 +5
Lines 10243 11073 +830
==========================================================
+ Hits 5806 5820 +14
- Misses 4190 5006 +816
Partials 247 247
|
yihuang
approved these changes
May 18, 2023
mmsqe
commented
May 18, 2023
mmsqe
added a commit
that referenced
this pull request
Jun 14, 2023
…kport: evmos#1773) (#247) * fix leveldb for more info, syndtr/goleveldb@afa5311 * avoid channel get changed when concurrent subscribe happens * add test * add change doc * update tm-db * fix err msg due to empty version check fix for more info, see https://github.com/cosmos/cosmos-sdk/pull/13355/files
mmsqe
added a commit
that referenced
this pull request
Jun 14, 2023
…kport: evmos#1773) (#274) * fix: avoid channel get changed when concurrent subscribe happens (backport: evmos#1773) (#247) * fix leveldb for more info, syndtr/goleveldb@afa5311 * avoid channel get changed when concurrent subscribe happens * add test * add change doc * update tm-db * fix err msg due to empty version check fix for more info, see https://github.com/cosmos/cosmos-sdk/pull/13355/files * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more info: evmos#1773
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)