Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid channel get changed when concurrent subscribe happens (backport: #1773) #247

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented May 18, 2023

for more info: evmos#1773

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang May 18, 2023 01:23
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #247 (86c6a7e) into release/v0.20.x-cronos (bad31ab) will decrease coverage by 4.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #247      +/-   ##
==========================================================
- Coverage                   56.68%   52.56%   -4.13%     
==========================================================
  Files                         108      113       +5     
  Lines                       10243    11073     +830     
==========================================================
+ Hits                         5806     5820      +14     
- Misses                       4190     5006     +816     
  Partials                      247      247              
Impacted Files Coverage Δ
...c/namespaces/ethereum/eth/filters/filter_system.go 7.90% <100.00%> (ø)

... and 4 files with indirect coverage changes

@mmsqe mmsqe merged commit 72bbe0a into crypto-org-chain:release/v0.20.x-cronos May 18, 2023
mmsqe added a commit that referenced this pull request Jun 14, 2023
…kport: evmos#1773)  (#247)

* fix leveldb

for more info, syndtr/goleveldb@afa5311

* avoid channel get changed when concurrent subscribe happens

* add test

* add change doc

* update tm-db

* fix err msg due to empty version check fix

for more info, see https://github.com/cosmos/cosmos-sdk/pull/13355/files
mmsqe added a commit that referenced this pull request Jun 14, 2023
…kport: evmos#1773) (#274)

* fix: avoid channel get changed when concurrent subscribe happens (backport: evmos#1773)  (#247)

* fix leveldb

for more info, syndtr/goleveldb@afa5311

* avoid channel get changed when concurrent subscribe happens

* add test

* add change doc

* update tm-db

* fix err msg due to empty version check fix

for more info, see https://github.com/cosmos/cosmos-sdk/pull/13355/files

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants