Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP39 passphrase keyboard is missing some basic punctiation #128

Closed
stevenroose opened this issue Mar 18, 2021 · 2 comments
Closed

BIP39 passphrase keyboard is missing some basic punctiation #128

stevenroose opened this issue Mar 18, 2021 · 2 comments

Comments

@stevenroose
Copy link
Contributor

I was testing the DIY today (really cool device, I love the smartcard feature!) and noticed that the BIP39 passphrase prompt was missing come basic punctuation characters like a dash or a dot.

@bitcoinheiro
Copy link
Contributor

bitcoinheiro commented Mar 18, 2021

Agree. Would be great to have all chars from the ASCII table. Noticed the following missing:
37 %
46 .
60 <
61 =
62 >
94 ^
96 `
123 {
124 |
125 }
126 ~

From Trezor documentation, for example:
image

https://ascii.cl/

@stepansnigirev
Copy link
Collaborator

Good catch! Fixed in 04246ce
Release with this fix is out already:
https://github.com/cryptoadvance/specter-diy/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants