Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octal literals have no scope applied to them #40

Open
faultyserver opened this issue Apr 1, 2018 · 1 comment
Open

Octal literals have no scope applied to them #40

faultyserver opened this issue Apr 1, 2018 · 1 comment
Labels

Comments

@faultyserver
Copy link
Contributor

screen shot 2018-04-01 at 3 12 39 pm

Unlike Ruby, which just uses a prefix 0 to denote octal literals, Crystal uses 0o (which I really like). However, this difference is not handled in the current syntax highlighter, meaning octal literals have no scope applied to them, and thus can't be highlighted.

To match other numeric literals, octal literals should get the scope constant.numeric.crystal.

@faultyserver
Copy link
Contributor Author

Support for octal numbers is already part of the syntax. I'm not sure why this particular case wasn't highlighting before, but I went back to it and it is now. This issue can probably be closed unless someone else has a way of reproducing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants