From 2e8715d67a568ad4d4ea3d703fd8a0bbf2fe5434 Mon Sep 17 00:00:00 2001
From: Quinton Miller <nicetas.c@gmail.com>
Date: Thu, 24 Oct 2024 05:27:02 +0800
Subject: [PATCH] Disable specs that break on MinGW-w64 (#15116)

These specs do not have straightforward workarounds when run under MSYS2.
---
 spec/compiler/codegen/pointer_spec.cr      | 53 ++++++++++++----------
 spec/compiler/codegen/thread_local_spec.cr |  2 +-
 spec/std/kernel_spec.cr                    |  8 ++++
 3 files changed, 38 insertions(+), 25 deletions(-)

diff --git a/spec/compiler/codegen/pointer_spec.cr b/spec/compiler/codegen/pointer_spec.cr
index 1230d80cb5f6..da132cdee406 100644
--- a/spec/compiler/codegen/pointer_spec.cr
+++ b/spec/compiler/codegen/pointer_spec.cr
@@ -492,28 +492,33 @@ describe "Code gen: pointer" do
       )).to_b.should be_true
   end
 
-  it "takes pointerof lib external var" do
-    test_c(
-      %(
-        int external_var = 0;
-      ),
-      %(
-        lib LibFoo
-          $external_var : Int32
-        end
-
-        LibFoo.external_var = 1
-
-        ptr = pointerof(LibFoo.external_var)
-        x = ptr.value
-
-        ptr.value = 10
-        y = ptr.value
-
-        ptr.value = 100
-        z = LibFoo.external_var
-
-        x + y + z
-      ), &.to_i.should eq(111))
-  end
+  # FIXME: `$external_var` implies __declspec(dllimport), but we only have an
+  # object file, so MinGW-w64 fails linking (actually MSVC also emits an
+  # LNK4217 linker warning)
+  {% unless flag?(:win32) && flag?(:gnu) %}
+    it "takes pointerof lib external var" do
+      test_c(
+        %(
+          int external_var = 0;
+        ),
+        %(
+          lib LibFoo
+            $external_var : Int32
+          end
+
+          LibFoo.external_var = 1
+
+          ptr = pointerof(LibFoo.external_var)
+          x = ptr.value
+
+          ptr.value = 10
+          y = ptr.value
+
+          ptr.value = 100
+          z = LibFoo.external_var
+
+          x + y + z
+        ), &.to_i.should eq(111))
+    end
+  {% end %}
 end
diff --git a/spec/compiler/codegen/thread_local_spec.cr b/spec/compiler/codegen/thread_local_spec.cr
index 694cb430b8c1..386043f2c5fd 100644
--- a/spec/compiler/codegen/thread_local_spec.cr
+++ b/spec/compiler/codegen/thread_local_spec.cr
@@ -1,4 +1,4 @@
-{% skip_file if flag?(:openbsd) %}
+{% skip_file if flag?(:openbsd) || (flag?(:win32) && flag?(:gnu)) %}
 
 require "../../spec_helper"
 
diff --git a/spec/std/kernel_spec.cr b/spec/std/kernel_spec.cr
index 7f3c39d9e9ec..f8e4ff1e8ae2 100644
--- a/spec/std/kernel_spec.cr
+++ b/spec/std/kernel_spec.cr
@@ -8,6 +8,14 @@ describe "PROGRAM_NAME" do
         pending! "Example is broken in Nix shell (#12332)"
       end
 
+      # MSYS2: gcc/ld doesn't support unicode paths
+      # https://github.com/msys2/MINGW-packages/issues/17812
+      {% if flag?(:windows) %}
+        if ENV["MSYSTEM"]?
+          pending! "Example is broken in MSYS2 shell"
+        end
+      {% end %}
+
       File.write(source_file, "File.basename(PROGRAM_NAME).inspect(STDOUT)")
 
       compile_file(source_file, bin_name: "×‽😂") do |executable_file|