-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_macos on Github Actions is broken #10110
Comments
So I looked a bit into the setup of this job, and there seem to be a couple of problems:
|
I couldn't actually reproduce the original error on circle-ci's mac runner: static:project distiller$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin18)
Copyright (C) 2007 Free Software Foundation, Inc.
static:project distiller$ CI_NIX_SHELL=true bin/ci build
nix-shell --pure --run 'TZ=America/New_York make std_spec clean threads=1 junit_output=.junit/std_spec.xml'
Using /nix/store/n55dgnwhnc8a6m2q9qhcymvyc0lx3wkg-llvm-10.0.0/bin/llvm-config [version=10.0.0]
... But I suppose that doesn't really help anything when it still fails on GHA. |
#10480 fixes the original error (2) and moves nix initialization to Still need to figure out why the nix error didn't fail the job (1) and clarify if caching works correctly (3b). |
test_macos job clearly doesn't work as it is supposed to. It completes successfully even on a broken commit where every other job fails: https://github.com/straight-shoota/crystal/runs/1583371708
I'm not sure what exactly is happening with nix, but it surely doesn't report failure to the job runner.
The text was updated successfully, but these errors were encountered: