Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop delay-load helper and CRYSTAL_LIBRARY_RPATH #14556

Closed
straight-shoota opened this issue May 3, 2024 · 0 comments · Fixed by #14598
Closed

Drop delay-load helper and CRYSTAL_LIBRARY_RPATH #14556

straight-shoota opened this issue May 3, 2024 · 0 comments · Fixed by #14598
Labels
breaking-change kind:chore platform:windows Windows support based on the MSVC toolchain / Win32 API

Comments

@straight-shoota
Copy link
Member

These features were added as an attempt to implement dynamic loading on Windows but were not fruitful.
We have since migrated to a more robust mechanism (#13858).
The remnants of the original approach should be dropped as they are no longer useful.

This essentially means reverting #13499, #13436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change kind:chore platform:windows Windows support based on the MSVC toolchain / Win32 API
Projects
Windows Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CRYSTAL_LIBRARY_RPATH and delay-load helper HertzDevil/crystal
1 participant
@straight-shoota