-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined method '%' for BigDecimal #9782
Labels
help wanted
This issue is generally accepted and needs someone to pick it up
kind:feature
topic:stdlib:numeric
Comments
asterite
added
the
help wanted
This issue is generally accepted and needs someone to pick it up
label
Sep 30, 2020
Thanks! Unfortunately none of the core team members wrote BigDecimal so I don't understand how the code works to fix it. |
Ok, good to know. With Hacktoberfest starting tomorrow I might try and look at the code and see if I can fix it myself and PR. |
ghost
mentioned this issue
Oct 1, 2020
Should be fixed by #9784. |
ghost
closed this as completed
Oct 1, 2020
Issues are automatically closed when PRs merge |
Thanks for filing and fixing, I hit this one too. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
help wanted
This issue is generally accepted and needs someone to pick it up
kind:feature
topic:stdlib:numeric
The
BigDecimal
class, inbig/big_decimal.cr
, has no%
method, making it impossible to modulo aBigDecimal
. This can be seen in this code:Expected output:
1
Actual output:
Error: undefined method % for BigDecimal
This can be seen on Carcin.
The text was updated successfully, but these errors were encountered: