Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help for determining performance. We keep track of gas consumption after each transaction call, rather than after each instruction: hevm handles the bookkeeping at the instruction level. Should have a very minimal effect on performance, since hevm already keeps track of gas consumption strictly:
burned :: !(Gas t)
(hevm/src/EVM/Types.hs:620).I'm unsure whether we should be keeping track of totalGas as an Int or as hevm's native Gas type. One way or another we need to cast to a different type to display it onscreen. In any case this choice is only a minor issue