Refactor and simplify code to not use Data.Has #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrieco-tob
reviewed
Jan 12, 2023
| @@ -40,7 +40,7 @@ mutator Deletion = deleteRandList | |||
| selectAndMutate :: MonadRandom m | |||
| => ([Tx] -> m [Tx]) -> Corpus -> m [Tx] | |||
| selectAndMutate f ctxs = do | |||
| rtxs <- weighted $ map (\(i, txs) -> (txs, fromInteger i)) $ DS.toDescList ctxs | |||
| rtxs <- weighted $ map (\(i, txs) -> (txs, fromIntegral i)) $ DS.toDescList ctxs | |||
There was a problem hiding this comment.
I changed Integer to Int in the Corpus type type Corpus = Set (Int, [Tx]) as we don't need an unbounded Integer there.
ggrieco-tob
reviewed
Jan 12, 2023
lib/Echidna/Transaction.hs
Outdated
| return a | ||
|
|
||
| -- | Transform an EVM action from HEVM to our MonadState VM | ||
| fromEVM :: MonadState VM m => EVM a -> m a |
There was a problem hiding this comment.
Should we move this to a different file?
There was a problem hiding this comment.
what about moving it to Echidna.Types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using
Data.Hasextensively and it's been a significant pattern in our code. While it allows for more abstract code to be written, it's not a commonly used library and it comes at a cost of substantial mental load as it was often hard to understand what the code is doing.This PR removes all
Data.Hasfrom our code and replaces it with more common patterns, in the hope to improve the project's maintenance and development.I also enabled the
OverloadedRecordDotextension that comes with GHC 9.2 that somewhat fixes the records so they can be accessed like in "normal" languages 😄.