Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Candidate]: Phi-node print missing 'f' in f-string #1109

Closed
hbrodin opened this issue Mar 15, 2022 · 1 comment · Fixed by #1110
Closed

[Bug-Candidate]: Phi-node print missing 'f' in f-string #1109

hbrodin opened this issue Mar 15, 2022 · 1 comment · Fixed by #1110
Labels
bug-candidate Bugs reports that are not yet confirmed

Comments

@hbrodin
Copy link
Contributor

hbrodin commented Mar 15, 2022

Describe the issue:

When printing a Phi-node the string is not formatted.
There seems to be a 'f' missing ahead of the str in https://github.com/crytic/slither/blob/dev/slither/slithir/operations/phi.py#L36

Code example to reproduce the issue:

slither tests/complex_func.sol --print slithir-ssa

Version:

dev-branch dd91f77

Relevant log output:

Contract Increment
        Function Increment.increaseBy1()
                IRs:
                        {self.lvalue}({self.lvalue.type}) := ϕ({[str(v) for v in self._rvalues]})
                Expression: i += 1
@hbrodin hbrodin added the bug-candidate Bugs reports that are not yet confirmed label Mar 15, 2022
@Boyan-MILANOV
Copy link
Contributor

Closed by #1110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-candidate Bugs reports that are not yet confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants