From 733012d15cce834aae0d56f8b96d202f285a9608 Mon Sep 17 00:00:00 2001 From: Judy Wu Date: Fri, 8 Sep 2023 21:40:58 -0400 Subject: [PATCH 1/3] issue #2083: add exceptions for i_ and s_ in the naming-conventions detector --- .../naming_convention/naming_convention.py | 22 +++++++++++++- ...ention_0_4_25_naming_convention_sol__0.txt | 12 ++++---- ...ention_0_5_16_naming_convention_sol__0.txt | 12 ++++---- ...ention_0_6_11_naming_convention_sol__0.txt | 28 +++++++++--------- ...vention_0_7_6_naming_convention_sol__0.txt | 28 +++++++++--------- .../0.4.25/naming_convention.sol | 3 +- .../0.4.25/naming_convention.sol-0.4.25.zip | Bin 3659 -> 3801 bytes ...arning_for_public_constants.sol-0.4.25.zip | Bin 1380 -> 1380 bytes .../0.5.16/naming_convention.sol | 3 +- .../0.5.16/naming_convention.sol-0.5.16.zip | Bin 3671 -> 3804 bytes ...arning_for_public_constants.sol-0.5.16.zip | Bin 1387 -> 1387 bytes .../0.6.11/naming_convention.sol | 5 +++- .../0.6.11/naming_convention.sol-0.6.11.zip | Bin 3688 -> 3930 bytes ...arning_for_public_constants.sol-0.6.11.zip | Bin 1409 -> 1409 bytes .../0.7.6/naming_convention.sol | 5 +++- .../0.7.6/naming_convention.sol-0.7.6.zip | Bin 3605 -> 3852 bytes ...warning_for_public_constants.sol-0.7.6.zip | Bin 1367 -> 1367 bytes 17 files changed, 73 insertions(+), 45 deletions(-) diff --git a/slither/detectors/naming_convention/naming_convention.py b/slither/detectors/naming_convention/naming_convention.py index 0633799e56..904b57eacf 100644 --- a/slither/detectors/naming_convention/naming_convention.py +++ b/slither/detectors/naming_convention/naming_convention.py @@ -45,6 +45,14 @@ class NamingConvention(AbstractDetector): def is_cap_words(name: str) -> bool: return re.search("^[A-Z]([A-Za-z0-9]+)?_?$", name) is not None + @staticmethod + def is_immutable_naming(name: str) -> bool: + return re.search("^i_[a-z]([A-Za-z0-9]+)?_?$", name) is not None + + @staticmethod + def is_state_naming(name: str) -> bool: + return re.search("^s_[a-z]([A-Za-z0-9]+)?_?$", name) is not None + @staticmethod def is_mixed_case(name: str) -> bool: return re.search("^[a-z]([A-Za-z0-9]+)?_?$", name) is not None @@ -167,10 +175,22 @@ def _detect(self) -> List[Output]: results.append(res) else: - if var.visibility in ["private", "internal"]: + # first priority: check for immutable variable naming conventions + if var.is_immutable: + correct_naming = self.is_immutable_naming(var.name) + + # second priority: check for state variable naming conventions + elif self.is_state_naming(var.name): + correct_naming = True + + # third priority: check if visibility is private or internal and check for underscore mixed case + elif var.visibility in ["private", "internal"]: correct_naming = self.is_mixed_case_with_underscore(var.name) + + # fourth priority: check for mixed case naming conventions else: correct_naming = self.is_mixed_case(var.name) + if not correct_naming: info = ["Variable ", var, " is not in mixedCase\n"] diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt index e4a643678d..2c05a3c403 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt @@ -1,10 +1,10 @@ Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#14-16) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#70) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#71) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#70) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#71) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#69) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#70) is not in mixedCase Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#11) is not in mixedCase @@ -14,11 +14,11 @@ Contract naming (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_c Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#60) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#61) is not in mixedCase Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#57) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#69) is single letter l, O, or I, which should not be used +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#70) is single letter l, O, or I, which should not be used Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#23) is not in CapWords @@ -26,7 +26,7 @@ Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.4.25 Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#30-33) is not in mixedCase -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#68) is single letter l, O, or I, which should not be used +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#69) is single letter l, O, or I, which should not be used Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#35) is not in mixedCase diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt index 96f6aab3c6..494253c357 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt @@ -1,10 +1,10 @@ Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#14-16) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#70) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#71) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#70) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#71) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#69) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#70) is not in mixedCase Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#11) is not in mixedCase @@ -14,11 +14,11 @@ Contract naming (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_c Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#60) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#61) is not in mixedCase Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#57) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#69) is single letter l, O, or I, which should not be used +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#70) is single letter l, O, or I, which should not be used Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#23) is not in CapWords @@ -26,7 +26,7 @@ Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.5.16 Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#30-33) is not in mixedCase -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#68) is single letter l, O, or I, which should not be used +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#69) is single letter l, O, or I, which should not be used Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#35) is not in mixedCase diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt index f1986fb781..e6e431fcce 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt @@ -1,32 +1,32 @@ -Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#14-16) is not in CapWords +Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#16-18) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#70) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#73) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#70) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#73) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#69) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#72) is not in mixedCase -Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#11) is not in mixedCase +Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#13) is not in mixedCase Constant naming.MY_other_CONSTANT (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#9) is not in UPPER_CASE_WITH_UNDERSCORES -Contract naming (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#3-48) is not in CapWords +Contract naming (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#3-50) is not in CapWords Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#60) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#63) is not in mixedCase -Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#57) is not in mixedCase +Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#59) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#69) is single letter l, O, or I, which should not be used +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#72) is single letter l, O, or I, which should not be used -Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#23) is not in CapWords +Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#25) is not in CapWords -Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#41-43) is not in mixedCase +Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#43-45) is not in mixedCase -Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#30-33) is not in mixedCase +Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#32-35) is not in mixedCase -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#68) is single letter l, O, or I, which should not be used +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#71) is single letter l, O, or I, which should not be used -Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#35) is not in mixedCase +Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#37) is not in mixedCase diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt index b471cbfa2f..d033db260e 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt @@ -1,32 +1,32 @@ -Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#14-16) is not in CapWords +Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#16-18) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#70) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#73) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#70) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#73) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#69) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#72) is not in mixedCase -Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#11) is not in mixedCase +Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#13) is not in mixedCase Constant naming.MY_other_CONSTANT (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#9) is not in UPPER_CASE_WITH_UNDERSCORES -Contract naming (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#3-48) is not in CapWords +Contract naming (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#3-50) is not in CapWords Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#60) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#63) is not in mixedCase -Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#57) is not in mixedCase +Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#59) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#69) is single letter l, O, or I, which should not be used +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#72) is single letter l, O, or I, which should not be used -Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#23) is not in CapWords +Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#25) is not in CapWords -Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#41-43) is not in mixedCase +Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#43-45) is not in mixedCase -Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#30-33) is not in mixedCase +Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#32-35) is not in mixedCase -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#68) is single letter l, O, or I, which should not be used +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#71) is single letter l, O, or I, which should not be used -Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#35) is not in mixedCase +Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#37) is not in mixedCase diff --git a/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol b/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol index add7867e07..3cc7197e5d 100644 --- a/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol +++ b/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol @@ -55,7 +55,8 @@ contract T { uint private _myPrivateVar; uint internal _myInternalVar; uint public _myPublicVar; - + uint public s_myStateVar; + uint public myPublicVar; function test(uint _unused, uint _used) public returns(uint){ return _used;} diff --git a/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol-0.4.25.zip b/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol-0.4.25.zip index fe35f0c006f2a1526c143d8def79ef54a25e15c3..a448234c6efc12d56a6f8f3b0795d137c6097df9 100644 GIT binary patch delta 3511 zcmV;o4M_6K9N8ThP)h>@KL7#%4gi&`C|4s@f2So5006*)kr@7enL!#YlCI)PsZogn zOqgg13X{h;KnG9`0(<2}XSAbb-ToGH_ZYMv9L|MDa1d#WZ_n!m83{d~g=wo6qufqp zU)(rKjazni{Z%wgXZ2$2n}h^^@y$N^*N*a9f5>2dOUO@iN#oKaOIa5A+gn}a@bpjXrmO=z1R5qz z8UNjgi)X!)R9&=4wS4MZaDJqJGYI|E0wDks@WZmJFH!^Q+0dNrQc1f7283Z_BB2}r5bE_R5|P5f&`0}H|~`Kct13?K*}w?<-g3E@$J-% z6|#9!^45xffKI*9a4OPWQt@i`qqT}QwmVx3s*fXhVplcLPqNkI8z2&mCo}PNFewCQ znp$x3s~m0&+!2}Ct;l0zgZwF{nx}EbWnx4 z$!w$5-_hg;4c2i7m_}>VM)Rpf{RixBc;Fjq3zGZH8}WFELg~=tp2-w4Nz;7mapP{R z7ZbF9h94(gs>ZJV$3Z-zPKkLQdL1;lSke?#C~r#BMMW?I;LvxRWZ@;*lrJ)q5iNhN z_02>`K{p9aAxFoB2n$iNvwjMp>WKbW;d$_y9BUMuFo^uWdGXDxJ*VXIn2lr#&_1vk ziLK$`A0om`d_@ohdU&;;IOhb0oEjddWEMVu7}`~;F($QDY?=SWi?#VJwFi^+c6>JF+8wQZ_5YpXyxtaW7E8Xb!TU!3_vv`D2Es~XZ#sJZ-6)OKKLnEGDu3fg~ zWEuqYYDasC0Vr{svVI#h_s2z7$fp991g>bB)MpCJA}NlX5zB(M)RIr!;1uYLrDe<3 zc?&%O?GbbX6~N6kar`o8hx^=B3cqB3$r}tM4tcn<7QKp9Z?+}QivWk~0cnpcwSxNF zYYXHtEhDJ`ZGuNHNkZ^vdV2W(KG$%NP})lFnp6{B15nQrXU>h|c9P&h$A2dUB+Vn@ z_FkK2#nhWglX%MX>^hk7y!IC*tnPD|D0(K~#R`{||67Kg2*S>BbrafC{(4dH-QzWGQso+3c}6()&`|#%>_RfnB6V; zu*x904#+Ve#q3R?r$$9nemymRU}g(NBP|qL*8VULD0+q+FmeUeIy9outfXhJ-T`0w zoiaYr#D|7LFc;(W-Q;eI&x1_H95Z%zr{4+J_6AQ{^{b$~XOMJ}#99tGuK!jT0Tj#x zC4DY02K}LKk{8!8;Wz>Og}zJV&i{aJVTwGu1Zvz*z~T#b+!1QBjk7d=^J-L;{kLe( z++J#3f#7~_h~%z>0DfE5D67rZ&avL~P<i$=y&i~VTcsGf2PEB-sV0PnQEkpbMy2TG&(1EFY99S zEejky=SawXkKUCy6yY;};zx8EK0^{*<`4}zkN-zQNh@r?vWVj?qp~jI$tU3&Ejk1p zQ5|Wd|JRh^*MP;D(Vl!#2X>z##3KU*dOIG2P{#S|Ie!=s_bBd}69}Jf1wJLFY+Vyp zxtDQcQ?2tbpriTcK{MwS3J;S2j_i!3M3t{Akz!0U)UHK$>2F4VW7H_5BFyt$0%Q9S z{Rz!mHWb`ud-6ef=BJY;3?Y3Ot&64mCizJqoj^3%2+tbvi!;?`KJSYV&}P z9S-B^vjktUp1YK=F?43;G!Z2P2_zlMBCcUxr{OFU8WHJBdjVntL~N|YT1h#3(-6hY z$rPHJm0-h+i_=hl)EizAy|Djw@fGjLCsW7RT}g2P(bL`l7|_w!5grbJ0HXv~)P^rx z?r2q32}VS!XB0N=5E4j+n)dhB3nIDj^|Vs?KxB#syyO%&VjtIm3918oGl#R~-Itbb zC@MuZsF_5B3_fSDyHM$uVOmua-)sEQ($S17FvVPyU~}PrbUrdgXDf7&kWAl#dSygvx-iB+P4NYRVtZ|TYAb{6potQr*XCYV9W7WNZWji!(=HHd-4Tb1 zK&TA8(Yy42)KOd=4{nhLY>6#raxP|v`UxOIz7D~w%yhWxi)zL}7;I^IHr=&X-n%|( z+c}J4{f&g8VXNt|>|tk6&R}t6^nZ6m%?W@EM-ZY)BU)hJ0%**eb}PVLuTb!-wp>kd zwrf1ji989D@DHGW5Blhd2L_S7fj(|hX#~hx>-G}c zFfx>~E8nu+7o!5$DboiosGXXuBQUJXnElssP>6EugwO;hc6E4wx0UX4knVb%Op&~Y zUo;oy+Gw$F4!gn^45FV!CmwD6%4bF*NvU{ewAbUoh~2eYAFNa0WDR z5sIRJ^mDTu)X&rq5B&xxBP5K;7&Pko3_1Qn{S;%M1zn`>kwE5&l+GvM{apwQ9j2Jo zaGbEMfn&^-^#JJv&1*t-zxk<1%Aq;07g!2xIEduHuniUGtpBoX?yF$Z`ji-AQ}obR zvq~3#{FVK)?EpmCEiy>AP0k~xmjM?FBpDWeG@X$2i02vdQzCc`S9Snwwsch!M@R<@ zRFoA`BTNYM3p%izk8LD(fGe5!%XK2KIcR1<(yyit8B-SPa?*>LXz5vy9e%U(a9cgG z$`E4stbR$(#D~gaX4M1}lMHz9pC;f;VD5RH`W50^l->M5+O$EWMz1$RzM5D-0sO>& z;(6;>ta+r}8@8XoETC{8S8&9Gysu28ED zWgxCgunVc!1rLtF8p{!v4mXp^72P=k3iH1bH(J5HXxk)&5;u_P~I=b{Zoo0OI0pSiUH&SBDTr7t?otG1tmw zpx0BSAt*57QGUJn$2m-$=edguo3l0eFYSKc(3~6N74M@Z+B%w{FSHbn!CfqFPukOh zzuPwYlX||_Oqyrxd8B#hWL>D@1-J1Nj*VK(nu^MDwvp9Qf09nJL2zk2QgP zXBCIO%+NOwRmyvPd`CHIm=U3nKkT_#^9WSU%KjFeoz)$XbNr2)Fk?kqgR(scsH<>|*7D}U9Po0&jV(-+NuI{qu0r@{x7+%*b(7O)npp%=aD!cRg@DQ;DhdeEqDZ~zHKmv*}4}^ zK^DH(y7#>rygdJ*o28h4k{z_S1|_4IDl1EJ9oBK_qNUTjGewKSQcf&5L>b`LOCe=; z0&$aIkbFod##5rv(PavP^VaB7v1a!4c|(OR@AY~jHe;E`6PA?~_&AsUCB%9FP)h*< lKL9@f0ssyGm8>WWS0hz_rzH*m0KkKj_zg`4Yz_bb001w6nos}$ delta 3371 zcmV+`4b<}49m^aTP)h>@KL7#%4ghDFCs&x_8Zws+0078)kr@7ebWBNPuRJ|HbImW6 zd_oImZoQ&qs`GS_FGvmLVF-_sBWn*-RRP}q9Tjdgp;|x)qXflqN7c8Jz2{<|zC30q z37tqyFMQ|aC+Of6$w#p7ajUej)K-xG((Vy86u@+^ozSWf`qw&#ww zF?YCFQ3rr8h7VkSV^R2v7p&APK}?v*Is^0y6_PJb(q3L{0f=#$6XNrbzz(Ft2OiZ@ zP~Lf8E|RII=CKMY+n+2ZFY4)r_w|U!3ZDvFR<}(L-1+IV!qWl1IN|Uf@OcOJWo;|J z+b{dixnG1~A!CXbD>V^a}}hr=xkqJW53y z);;uw(9)3sK1a8U)a`5SjuK=ggi0eP`eU5nMK}}A=0WpTn`Rx_ilT*((0OsUq7>_z zEelOuFRqvzI{K4rEyR)O&S!D1+O4ys)GY<k&h+rVS(i0`$a-&;_EdB$0e>K+F~=MV zx$(1q#WN!iU|PM3pwUyqAS5aXHe<62Oh=NxmHKqFiR$&vNxSoL;7S6Z7CmVV{2n7` zu4pu~YQ}lR5+K1*hp?fbFt|`g!{-<7f51;*nK+K&lNdnuL9|4~lO|A=S|+ zD8cc+l&guw`K`Np8+t{Lzvd;~wHDt7{$K(oxkhd5b}K;ZYZj3yqTfrl`5`MgKpN6| zs+8{*h2|3CTT|G#%Ja~$y>5CBCbR|+1IlA1!iN*19ko7R&Llz!?6ymzxsm54%d}HgC4_@g^ZWO}!&# ztg515^*o||)mfFpvKusrsm`3Abs^e+3r)awhgM_9`{-91hEfL);(`yw4IYSoGO*u% zrfJ)>A$MT^u@i&SN7oF#Fzzi#cn1U}7@tw-#Yc3@pl(-Lu;X%%qMo3j&szB6O>JAfZA+^Lg))2mCz zT4<0}qiYW+#GTNA;_gBG1HTY%BSnh+?_g{22sZ@ZtMD<0RyRQl-6xHyjd2-|*NLB= zqU(C5W!c8!QNTkCCNs|br~3EFUTeD)eL-TzQDWB|OmgY=M(hhRmn2jn<9y)T1$D!R zgN>trl;b6T$4EQ90)eodey4a7jW%w*||z-w}Mnj>!(**G}!Gb zX%XcX95^?cMdPin8q}w2qKm#JLe8B*?CFfILdQ;<#fY({87;r9Z1hhJFUPiuhcVG? z%dY>wg5QJ`V>gu3L6e{@nFwm@3mfl_d5`v&3N9*DWgXr8Bvz#DcjPR8xx~$ET63{_ z8W4K&H}puWHW>Al1AAgoCUhPWCW)*zIsgow(-2QN*6$1$&n%^wo3>D}%K1#^A>egU zHZQif!~mxc9k5`dTBSr@qCG%mqmkfDuL~dyuGh1~SGGn&jod7E7lyiGe+=qqNJH|8 z1Yp-O|3E@b1k?CN_E(O74v!`T8d@K9VDL`QrEE*>b)U{Wki4}jt6?7e-;tPIf@Rz0 zBAP=V=iUTHXzo^IC=XXt*Wfboq93;4Xh&3FSZ9{UoGDE!ol#Q;i|olhQ}OFA-8^V;@qGXB4P^7gEx%#W35p4S;pBBtRJ#^fqSx%! zH$#Zv8&?kWSNhg0bmBC`5J>95$smDJJ)dam@`pXgbk5LJMC2JSE4qG6HLzyb+Wv20 z#r-6d%*zb7(IYeBjfu{4Nrtzd#UtUmD*RTw$#-ONFEm6Xmhp6)7m1!t3%Xoig`Ia& z8MYkbiTR>&NEldukB-e}^)oNX@l5li6(8-8oV?6c>0H?G*4(5wzRewMyk*P=uI9SV zOoBl+v~w1yJzt1SYNo{zQnjoQQw~(_Rkafx(&d2)4||OX6Q;x`pX4ik4$8vI)zON}_|?u4QNaL82;W4hiEoa4 zY;&s%Rge}^W`3y*cMS<&d|_~PswlkkOO9Iph$IDcE>|q%o?XK? zwb{E=KMX|`gd(fvaMylOzf+{BT&M{4EgTH~DyH~=O|j?-DUJPu9_#tYYZQ}w zR?!ztua>d3mtRYnub)4HmTxV=ejFdLU0+HR0*F&-Uf5GefSWb(X*$mpR?!@PbP>P5 zeZ7r;z`Rw2I3ZB~W@HEQ|0QOK+D4=&G7<_O#`v#Qqsc?vLaX?$It^msUSR3AiGZ=H zLhCB|zm>OHP@v+PJhB%5Csyfyc{cRXs+Q+9BNxoZD#i|5)@CTM5}=1eEd`0wd3dm!z3?VVDqxN=|VLUoyc z4JdSc`4BBIIVdn@K^ipHPB3XeOF0@YUVasahZF4Y(|T-j+->0Z>TMIggfkvgKv)yg z8#5bohP^6@A2u*4U6UwPWMXIS>J{Ebg8kT<-Wtf&sv94K>SF4q(+Cx`JT#9n8dYw3 zS8t@@f@Ejy8{HhCF0Tq^NH!%^j$c53xY|}hL22iBKohX>i|XB~{*->cbEs-E1Epxa zk@@itorKc^58K8WF3^E98Iwel@UQ~A5jJ-L0Tjgum}GJtMfvE1(^Ib2L2G#_dA&6B z^-@(;UR)OrBP>Rjh>8)k1Q1C&w}pCMK1>VKilU5ljJ|Zo4rP@bx$j;-Vrbugs8cvj zT@D~RLkDZ8CuuYHu+7Tr)hS%U*mQSl05bk2!e?L}ZCXa8B1i5wpxSDuGtlFLA2XD+ zEN>)mx^dyz`tJVt=cQnAt9nbrV!uRF0&1w8?$=E}fp=23);WvDgtGO1Aoob;5e{a# zN`J9MEG1yH35af93A1`9!F@b`bO=F+ibWpJWcSWsN)K~)^Nco4{({UWPT z$X+7^Z7|h02%E2oN-8If>MDj`&4RHLqeRdId$e diff --git a/tests/e2e/detectors/test_data/naming-convention/0.4.25/no_warning_for_public_constants.sol-0.4.25.zip b/tests/e2e/detectors/test_data/naming-convention/0.4.25/no_warning_for_public_constants.sol-0.4.25.zip index b8c6c58c1d0b2579589ca860a0704718ac875347..10aff7711e99be35362fb893bf8c6fb9d4c08ef6 100644 GIT binary patch delta 30 kcmaFD^@NKzz?+%Ho`H#hk73msjg7o7SeSwI@KL7#%4gi&`C|4zw8f+*I006#%kr@7enL!#YlCI)PsY~Zo zn1*9nxgDQ0N;m=&CdA>%Ocjep*Wc`wX=#uwn8Us!9AX+5VsDCP|KS$DDu|@ccMc5N zOxv7+O@;bU;a2*Wj>9J?g}3O#X!N`Q6e!8lKfQ#8uZW3ME_a-G7*Xq3biER&TGloo ziN3|mTIiapbbncYN9>uhfe}^T0pTk)7`^-dZ%j%|&dR{~=oACHru++%3voW2_{zPA zTl*SWDEF52AwY4+iwnjwzD?_AfCokNuI4T#Gs`Z?d-gD|eWxNJA2B4){CZDmoWeHw z!l_W#HLp~HS*lS}5YV-d8lh@4Tyf-;h$0H85z$l_V#B6?5UB}3=<|olyYJO4n5B)A zbyH1Cn)~)5j~t+fn;|LpGP)3_C+{X-q>1hG;BOM_YDFV9TmTMDfQwbzD58Z= z40@N;4{LxTPjB_@-W18mHd9kgGXm5ANM@a{tFdr@u;Z$`>_K$5T?M80qEtRt;yVpc zmwxgx_d0k~cTW_^hk>RmX)L7AZ!IKT3($^hEHoEQL*Vel{kj3z#iBduib^sh;OC~$ z2g0y9DlWvZOaT1^J0qzN+`MFd&l7Uyd4&C>kfd*qQ~|=rETaj1l#eBd_5kh35Yf+E zqh$wwc9SSF)LmKe$5}8@(y3reTmnd|5&~2PR$uZa*I*;O=9vqjX-(3855`Cs0??ALXZ~N5-TF{ULxoNyu5eD)cy?|+0ZPfGz9YTRa94j=< zJ{A(cxJiF%Fb0}Oj5PLx_z8HPsPz!3M(2os#1LligoQhwimAQ81g5&>>lvHClN-HX zJV{~oW#f`WF>kx%0i|A^6&3luy6CL*w)kHsh@B6t>qVy2cE?3H?Es>(3dcL<**&dy zYN!V~6;jB)TeO_6+EGtWj0!aeP6y&Q>L@S`;^5Amp7E4z+Qy8ed=3%Ba}4Rj3#!b2 z*US!gv|b#RrdVRNZlwmycEi>R1XYu6W>G$}z>nCwU*UX*^DNe6^ohQ=>JPuG!2Mwk z=|u`UZUo_sPoKY$p{9H|S0g%Ow^3$>0}U8k4(X>WJW95XvQCIo;@JL#Cld%zcoqOF z;EJcpNpo#V?!L-(;u}fGiDAAg-=Mh@7`d{9gM&D3b5_Yet z({U*1KA6=ldGU)BenDlC(dRSN)Fk`_x(pRvCr|bg!iyE}&s_FfFc1O1K-npOY8xJ+ zuV_%??c37AZNE+z${Mm#LQU7xy_-T`^oOvM=}@TJR*#R50*P}{3W~|ehf3k*lsrc` z5gKkL)VBLLQjtWU(MPSXPfLq4x6&3woAkuySHh-S!2m*ULE@Pf;SLl+$eiJ(<|**N zBF-=NGJ)t!4y%9xrsM9*Xet7Kfl;uG6Gpy*DbBMbSmQ7tfzLmwN&5{_Y05gDrTAq> z9}7)t9rOPJ&$#(lEDR>2qF|`+k10k821$~T;QnBK)w*gMh{Lqy(Xf)|^Lj*%Cf`K( z(|{hsfS)%4J=uwyw1ZsT<@npV`q~%ppFE4R$>T6us07NJ;mYlutF2&vg_<)P-XLxn zWKOMxvAba%!3(b{7PGu+czg>HzXQmXr=seAC;HBqgfnRHU|zGzNc6YE;viC=hRHMj&Je?=QIMCJ+E(R(l zZue0(%lG?`9Zyu%fh0Jwe%}}6t3`+GV+jmo$#b#60@=JV%0+FN=T7u5XN=0UPKVxm zQ%Vzz#2D~zpI|E0$&phd1L zq=&U1GudtNoXKtA!d9E^@n(lk*D**r=cBxAJN z->)WsgsFh>;{ZZQ31_JoFl4p^)+tCvyza~b-%RcM?AJ?t`Uiv3TMf8IyOc;+6qEzK zhDmr;fZM@I3$2fT7Z5m|V(jdPQfL!UbB1u-#mVo|^NZgqS(DlT0=D!Ku*M?kGmsm& zr&3nD^nqcYR4s6Qi^Dx`fK|T}^kofsFtHZ1CoE@7&_}aybtHgWIg8_&`g*i|{;ot9 z6cS}NI9J)A%+RGJnE~`WfL4geswkiS&z;XF`CI6+AUZpLjP-HnoB$4X*h!p!#l}rD zo}ePjzPnv%&ee<3tiQm(hTgm3OZ1jdM|&L^MKa_k}E zmM`HZQuZx#FQ;uonbQO-EQweD0nH;L6zdi^BahvGk1@&iN^z0;{4cg0)DP^4UeOiC zi_dEqHg|W=rZ+r_w!h}-W)4k*h4h)k7MMx8P(bzC&RjmJvAfX#U$I9}bU@p~?;4W1Hyxl@sEY5j1S(dJvL1S0yNzn-2@OqtFs9|M&%e*4fbUJP%z5Z}gcegSE<*n6OoEzVToH zjH0nhV<FgziW0f9i6%@ZFe%`^gyYOc6af&T$9?CDu(0!@&z=S0f~Rc0fiDTc#a{&caD zI$fhvAEz%vv>rkZY23?_bik1a9nyAxBKlPnPvWYH2`02OX44E9l1fTyi~TzSKw9sn z+oZ_{)}w63;6C|g!#GlTE_F- z2TYeUKgDsEys?DjM6Uo|(K^0ZCu>njbr-Y+H5&#|-AhIg;g=8EEYnvY{QZ)D7QkiU zONqlu)2$}k(2g+e`RXxX%gZ*Hs7S#`2I->08*wCB&}?hC&DH!J@T8$Fq%{y`h$fbC zV-0KQCfZ#4i!}7PH#Sa%{isv?UN_y)+I6yV7 z_{B9&d;Ju!k{EkFl~vJw4~y0}4(n z;cAU>;>bSb$PhzTaRYBhCJRrUxCL5{pZ~?SMra-Xg?j=eZULeW5XLW&Ty0H>MUKb( z8X$dtL<`#LJS?-?mIG0L%+&_fJvwUa=|8#h8E>)@`jInUE_JU85O1~`O)05@ap!9( zPR)p>U{bmpQ#@S!M5~U{)|@{d?ia2;7%WE&AE_$G>S*)KXkC6mW^9{>B)ur;lIR0d zs#fDgB>fz^kfJnBJb(_8qDZJmmdaDGNX2t?;R(=kiSU+8qWvF#Kq!iG`oqP0SF_mz zbI~H2))0lvV}*%SwvX}=hs%RoVNfTSKZ_M3CZ$W^>H&GZV1fa?@g-!hLby*V-_pqc zMaXNC6yX%C=LJszJikk4owDc4gdfE0EpJHT>t<8 delta 3380 zcmV-44a@S}9oHNfP)h>@KL7#%4ghDFCs#icUk{@V0023Akr@7ebWIo-1IEP96*B=1 zO5Y?bN)eiJiXb-7GY4fQ?Y#7N2~=8*IPZ5;W+6j=Vb~0(Gn3^6b~Q|~I+?s2II!%m z)8gKda6FUP!6NVLVB5))ELIk? zG$C(5c@K){wWqi=ql-89M6T050m=C=wYcP4Vaq3_k5R{eY{U>k=vyy>gtj2t8@E+3 zfq2_51hDw4ieM`T>GxVum0OYe*9X!q!)xrq;eY=VZ7Dj;?9w+mu@X2D?C66y*bB^c zyHhXK9*_SF6qX4M^~{BFRdK^zbJT4R%+x2SxO@F%-e%1ez?pQV zqT`@4tp|EGTI{byHYgN9nzE#}KKR{-|EvmsSBR7Pdg?o}&~KgQ?Em$~o18)g#ikOh za6D)Ld!OCsyn5OP(ld3}=O$?my@Ecf?UBhHo4Ox=%>C_($dGRE4G9duB)*0U+~~*c zU?}6KE{H+80@M;%Pi3)?D$|VAF0BezU31%AlXmX$4d_yzxM;X%7GtiFK$@TLS^Wfp~oO%;ovg(Z1&CKn9CTVuO(>ZNFT%p%<_Y^U_#u6!Q!DeNW_Dzi?k=mYc zbRKnSekXeO(hwr%Cq%uyhy-2b^h1cr)k(J-{L@yqDYH;2%A6~0lEdg8+p$(0V!$v8 z$g7cFFaQb~SZrj?C9xz?a&0FuaHLFFS1Me8!<9~=v*;Rlsc2LuTB22rR5O{^i$zEp zJzNsdPeg}%FmLeg%>IgG={Ow*eQnyt<@Cc19{68i_6;gCujgu|COQCX&;+))213dU zYg>BJUUYo+Y&e?#wg%}=hX=?TW}CvxG3w$iTnPQf?RDFmS*ir8`(aP2>SiHl0>xi{ zVa&XCisw0IPo-hOs__4s%YZHgs1I7faVL*UniY7UmDx~BXVw^3MF%gYeaiP5=LeZG z?+^_WKbq~o;{v(TmEh89|NeF8%~RO}dohQ9cBqvr_>0i4gallqeR9vJ51cw;SF1@% z4-*xE$9e@7hIvuN5jkc=dTI3H~Rz?#r#c*Y}@+ zZqAVlBE*K-2qJl~%{#;k2N}MbSm&VC8clE zo0MRjcaGv_3w6$>!4P~jC!uFXFnU3CZ>wevHlN3CCrqxv4$;j)KNV{7Wuz7hpY zR}Tmjeu5%zZAbqP z@8KMCCi%T`zHa@P-^ZhCWt8ovZaom>Eubk(YR1BBn)nM(ya%RNVmU2T5agY%;s!a6 zS4fA-!3$yYSZ4jz1_{pfL9N)-Jg@@7b8QS{BBU)aq#*yS&3?MM6m0l^A7Ju<7c=!& zm8B%!D9{iW@4(!|I{^!GfV1EJIdmcyh2rb9i+<)4eB@|7M9kX-%Zpxjpii>)hB2^K zTTnFY`Z;g=6i8S_J{$Gpp9*IbkZls-z0#W%jDd?$i>!sKPVaK^ zD>{yb+V#4hrj_G1chqH{r21M(Ew;mOAH}xr63**Jbhu~lft~w*sUT4^^f{)foXkfb zl-;;jc>wC0Xq-SW8O%SDl4W}|(UsUyH`W^G!m(|V()MWrt-oFxbNFd}c4+Wc*2_~R z6*QT&PDzrAJxZnV940?W^Ui>|A-W|UZ;!gCATh)E9(I6lrzfWeOP-}>WsaK{_p=o7 zrqAG-`fCdgZ6e%%&DcNi7J|gu$f%5p#)!f_IUK}fbu2JYoZ6~LudVj|MSpN+tZbPK z80P+ebjdIAC)&fjCWdo!q+EGM%Vz@J!TqC?dvT6?GbX-nRaS_^_AslV1@I<+2+NYLsDKqx!-)uXBlok z=TC|ZCIQn2@A}yEELal>?G7i>+Ru|UWi#st)%$>deFY-YC|vI;nwgY=DV~r;=FWDw z0Kz(*Db|J$%CBAjg##D&XK{SbW7VIQktT>an``eyy2z3s1nq+eZ_g{_wU$G+R$^Y$ z#9gnAoPrQlh8jZlgGuv!efsN@nP@XiL8zE}<}VG{1CC%|Y!p0Tzv(BoviI(C7L*^* zRkRy_f-HlW)8;Y6#Jkc!-w49RpWsO{Mtg|4wty4FF6oZln ze`V7Xae4$;l^Yij%-z|(A3Yklhb=C~(bragEv)i|T3~n(=DRb}p=v|$vCUl}h+5Ud ztLY`yEMT09*pj_0o6A4R)6D!-E=e9BYKZ1TmNpP+MPuZ@GGgUyff^*Ugk@{rjm#JI zCF8(O-ssJ*u?gprsojT89)O@Am&Rk_-c+G)L!$-04cIH*`DQ{Pgs7BkkO~afjS}U5 z%?7f4-GQ4>MOX~;SqzN)>=3)6wK9i4Wwb_`a78O;Na}OL+1c*~QAJ7fHkRC+aGYPH zS@Uf4JkZLkxq-D=M2klIpxZ4v!^A$YLYguVs(2ZWL(QP2*{_|NO_)jvRe4NeR21ss zCwiQ&q2MW;l5`#Ex|3zvJrnj$F5x?WfCq0%e8`)&%7e;rjc8@@^}>Hbiq73y`@dIc zxbqNr*`R6oRZs*5@Gqli*0B>X=DKKP@MmggypBH-YGM_vdr|NXxl#mWfB2JXkaTKe z@bNNbh=o+(pT*3P-L$5`sN^xN)aK2pdCC-<3VYhv)aC~$$^;x$3Bk6cPBR^UruA)U zDk?}rl=ON3h;VuE-B>(HK|7(!^z670i~QBY+t7MhY8JZ+IcQ7nO;eG39g%-dWC@cK z!)2GVHHE&fM*?X{#o+_6${4jy2Bb7OO&-Y}k!amZ9XFyGViwzcAsO(kg>J>-c>^K@ zGOeKXbj-VfBWrmC+;M~H1c26mT7Gc24WkHN0-B6pK8Go9S*#;I^c>0D#>}^hm+KO= z+2B}Rz_6g|0{zHKRS+Q`Warw1+K?V#8m3G-PsOOtTCYlM6e=wTlPvxmnv}#*#xM?i zp)|SOr1yYW$lS1+oDO|M?U^f3(b>ZWKw=j4wU(t1Mu?}=Pyq-Oqk?UJyx%_2dH|et z<9CU^>elF;OOcth&=5_Mr(vUTeFQ72Ne$S>@t7ydx(@F^aoksc^cC{$2+) zU)|y0{2OS4m^UAcCkCE>9$2@^Z)Ee6+Pp2+9&WNQKiey^a&y7~R*D`n$<}33Dtn{}tpw08mQ-0zUvh00ICG0B4yeS3eU7Uk{@V0023AlZg&Z K2I>s}0000^frvx^ diff --git a/tests/e2e/detectors/test_data/naming-convention/0.5.16/no_warning_for_public_constants.sol-0.5.16.zip b/tests/e2e/detectors/test_data/naming-convention/0.5.16/no_warning_for_public_constants.sol-0.5.16.zip index 600f68386baae0809a4bfb8d720ea31aa7fef8bc..c1cc97460a84a0700770d8195d9284b6ee5a0399 100644 GIT binary patch delta 30 kcmaFO^_q(}z?+%Ho`H#hk73msjg7qTS(t(J@KL7#%4gjgFC|C2CR}H2P008KWkr@7elL3YgQ8G*61AG7w zygq@#rIM6|H@uKw$C(CYoZfZD;|wTPRjSAv55AbK%CwVf)>U2Zm;ye=Nd`b-W*B%< z(Mo4ipY5!<=Ej-7r?{>&5uQjh9HLB8$%vmI^7YwqZ+?CczW3~6MtFD`XNBoSHxHo`9SNCBE1Dc%BvX)mP8I| z4w?!`PuU^0x+gFomCnmPLpM`9+ix1QWzcK2ocds)39Piw4=yo@{!fC+C}~~p42kn;FH&yaWq<2 zfro@OY>ib5b9QXK?b@^Pe@UpbM|}wtK2S;m1WhzTS0=TWPZBeRweH&dQ_-f85{<43Zg-O;f&=?`UzwIDa1i%j_8GVr5wIh zV1aHqSD$$*(eKYRims8Fg;;k;hF$O2$mo233oV6G@q6rFE`YcJ2uT|ELe#1Q{#-x| zJqi-=M-wjk9+U5Xuk1N6Mj@yLGkIAo zm&hi6zP;0uWYE53wMcuPhYGWQ8BiEC6H5Qz@f&E#5taO9w@GBc=;$`)R3iV=Pd$yZ z;&5&k45{X!t1IXPWf?Gf{X6VsoJ%iUAPtcGYzRmKG-0v(x7^UADn_kp(n+9C!?|Tz zl>uP$<~|6vy?T8S`eoFmavY9@>DS1`8~u8J!liJeI(vfThSI8aq1FM8%~$uD#%4}T zX5j`S59QNbCy9)k9lIad5QHxZCE=NBOrru}Zbt9oVYqpym7#l#AHN*pL758;SagJj<^+pk_#T1J4hon?FYx-4P^M2{YK1N_3|IXSy#|U_9aEn^d*1hgJL1nV$EW{u=Rw(o5FCtw- z7ht*!=N&0HAn{-&@x1YxVhTwOa-D2{g-0k}c8E6MX+&#K1Et=18<^vo2OojOAv!b3~pQ*^_C*MDmfmf!5_D( z@kMZY@26qYa)n_Ph^=C#B%&=@(a}^1{aBl~5n)Lo3yB1zO9cfa5|xA)nYjXgV2pwE zXzFk0BcA;lpzFkfG2XL%o?BzcCUF86J&=okHv}=XbeayP91Hy;lJ`4}x_$gkZtiL6 zzWd_{Wp4~}ISys~dVvgNn>73=fx3*$y4^{Pt@kl4naZeZg?_!Y2fgCxrQ{f7mkBI; z0B$uM=dxp<%O^pf4vaN}95~B=WIo(aq%B~-?a*%+j; zJSxCt4XeOmfyZ8kvcFO)arU^9Edbt){2Zs#gW?p>Z;THAm!>NU@4upQ>C#WI`F+!B z9I@*5>u}M>qaG2#`}xP z&M=9XyZ#Llt%~!F+;GT$ozq*JT%A9H(){Bx@M%FGl7*zRLyB=l#c#4m{LAB?Kil&F zXSy^HaEnHrCfjxp`GF<^`autQR#jDty&l&vo^FYM`bw53gzthhrfq${nr&W2eX%!s zTga*6FI8JQN3mR%Owq{**kcM3lHEA^ZmNbG2D+p!E0fjhm@E$MEp+9UZrnqm7!=D3|Ie zbe^43$Xo8%7+rCHB49K31s^rGX^27LH4_dTZ+(SWGp%O6<*N--ybe9W+dV4c0b+R8 zk?JxWKeK`|cy-D(n09~$L}&L8ak;!PeT^XB|FCdDA5U8Uo;p$aB3)O6clQ`lC;2jY z;EHo#`dv2!-~NMrcg=z6JM4nyS+d$i1|S6I#$X7n9vy9emNEvebf#LfLQ{(_*%3I} zI>@P84!GXo?-sc8Nk%zts7NxSMqU_=n>}dP|6&;J7Y$pQ%Qk6=bp0(G81fXu4-e_B zl-_BL30t{O^<2w}dX7qichhdo%WdMWhNsbO5i;0 zwo@7|HeM}x^&#*D^r%niqRgj(t|KT|BaaF^G4Ev!V@T;-3NC3y7kFhh9UN?l!MeLP z7DGzp?B@1ax4Z5c6XnwZFwvkQS8>t*s#zMMC&#RR%irKFy*LoTs59!tX?f4xga==s z--oSEYVd2td!8{$eoQWk`#5WNX=o@CmqGQ+C*;Jz9mGKnH>%rmUIn$3uYY(|lu&Eu zVRQC>H6GRgKYlvk#4iP|7yQT6tR|Pz!h0p1J{p4t?h`kXq99DGg!!_vkB|443ui2gR9HHcB{yP- z#qu~f`{#uo+C-n6{oT6=S*|Z+V42R$QPE%h7(nv zl*SOdWMJ)S?cQ(|1gz?Dl4%LSbQ$i5tdw7b%v6+33o;57PdP|2BqtSx?l|ey*05Ek z+H)xqvlfJ`ch9(BH^*r6BjVqfN-I3SfH%1couO(h*LUU=<$gdQo`vH9?_+ttOyf^~ zjQ8(|_EE8FKAeO3N$`pLwCMtym_k6Mef-g6!v)h7J6RIkeH} zavPz(nExN>`59!?W!Ga=ymiRB>fW#U-kl=NuBltM+;*j(4gb$KDf@Jdg7_dH3(21_ zlGuY@Uw6el-#k`@z@0<9p6L}=c;y6t=eHz0vB=kn*A!J~SXINR7oq&OOL^q z9pa(-Nz6OfUxF2Uu=Z!2e zreeS%Fr0H^^2<(Y-Qq}C?QD}zUU!*rhwjYbXVnD*!c+~^u;wdIu>0gr)Ha!giV(R8TdUFiT<6?Ba(^KngG;F ziNz~b6A|2{@AbX6`)3o zHKe@Odm*Pum~uYNvE}@wUGFUbKsA2LHs@4@te+lLXn(aoy~iy>{z?T%X&hyAq zz$Pnt8UA`eaG-!#Wr2KXiJJla%7`dpGJnP`!ZQ&3Q8|nfz-w#)A)gI(Fe)l;FvWYr zF+Cx=K*es~`13(u==T z)BG^f_MczC#mb+MOxSUM9u@$x7B(5R$D#VBwJySZQD0)f*hPUdv@RZ)^hW0uIeG@0 za=qtFQOz;~jNOWKuc8l@@;nMb_A|~M6wxC3qA1k1PJxq0pjgj^g~P5uKujRY5M@eN zsSexxoB+7s5w{$_7%RfeL#Y%mgPEkE+K(h?wyE_RSnxNuks~dC#k~mAZ}fMt-7cNv zy2{pv?&Nsoj#Cvhkir4h{Pm|{VsO^{zrF4$(Gm4=7%a~rCWa~RP17e+due#dBIQ@z z93ulhnvUWw>QMLshtR>tbvMC1vik!S&ye0u4ui?xD4Y1fLc@44n&8RGR}mz2y}>76 z8{_7ZTFwJbj*Y>8)z}DBGPQ)3I%s7@M#(ck_^-{=$h#v13jbow-Q0VIrpA;nQ`DfK z5xovwO+v)GC~6{%I)6a>XIK!Y;?ri__Ri?3>7;-4mZ93pp{Gelhu?h0?c@El-P8e? zny-bIEncaL02iZ%{xXok7yt9^bK+1-0Rle&KL7#%4gjeQtSDFWm{$#^4gdh?jFS}( LO$O}_00000ZEgC& delta 3397 zcmV-L4Z8B$9_SnxP)h>@KL7#%4ghGGCs)c;ElIQu008}dkr@7el5^V3sL~_w%CYiz z0QvhIw|Ji}{Sr|ghMk55mrmw>H|JKPSg6-erCRjE^9QjLI)m6P-$jc8Mv8Vi7+z#p z%s`^_kVeojN>@u z;afeXnwb?|oB(_)i<=^%8<60JX#Am$uLwO)!tw0d0xIDr=fV`lv~i!jIJ9qnZZwI8iY9&1%Kfxv3ucn0 zKnsOHy-7#1qaURH8b!{PdBbhqV@9f6HfN<&>M^?FN2vsx5!p=PImGTR+DhP#W7jlM z59aULPVB)h%BXcP?4h|)sZ&e#cZ!5k4>YXN4W2llY6hSR#E~F!YO9os((-@rlGk1( zehT+j(YtSd7$yW4s$W&_%G_*2BiMQH*J-)0Iy)f6!{%u+uxo*_U|k0*n1rnxVlLv( zd4nzUWal9VBLCU)6 zo{5e9(yG;&)=c$x=I~ziW)Bo z{`bczClUFChfON&o=}msH=kz9PwS_J^|S|{>*I4y@#H&7V|jf7QCrWXb8(r>B z+8Pe7)}M^B&L1iQNi!TaslH088sw_`a8TfXNuh``sXwmc$QqV{V6qx{@X^l|o0nB4 z6)DRgj?rt=IB^V3YsA1GENn1wrHRI#^;<~(IrR?#QCS#PQeD`wL|KE1K4ZhFKibe? z_jbMP@NL`w{nZ=cUEF`QvWq^GQbOnYm37cn@5~p_Eyls!@%1;1JIStS{8GP}x_h>N zM)nhnZJsEY-2EIN);Yp3&{6 z+e;m$R3<+Troz3YuRT@N`$u1N-(e1{CufKx`XBm+7Tc3!`W}znGE$%2l4;dMVVH>n zGdY|1P;TuA+EZ1)R7h~$E>tyf^W5csvf9=#FCe=G$El^dWzkpvQ>3txxNSLhN5s*c zPr7!zMz8(ymNC}UJ+Ah(q{JtaL_9{fiH%)wT%Dr|3KNh%30?MCQ@7MPbBg$fI$oBM z=J|_`V5-;Z>HEBPIPynz-T`ziSu`pfAP8m{{n;q)0j_Vu+V zaTyS8SQkHty7wEral~#m*Tv*>jzXJ%oepJh{)8AA!r?OaXfvZ-k^lR&z;7iFTuew{ z2;81Zo$(T?$kXDM|BR>i5dB-HtIUr1>MWSLI0dBxcZ8ESfdZa{8(^A$BR&FVfs4M} z=RBzNx*j8+4h=$#Ab^N2^9rk(vArpb{*ho+{bqHfbgUmoT>At1Rfu-4*e);e&y6vE zy{nl1uC5@VVu$fdbQzBJ48++C#t-BDQIwT9g@haZg`XCx=>h*3kNwkR;4c+eZ|RwC z9<`(Zsc*U#F3F`Bd#U1o<_=e>g@ptT{fh|D@shOu%lwywM#wGiezrHEfPjoF@bnun zLb+-e6~1*-Bo4Yp=rSaliW@*ICkvMyxmcAIlo*PX{kTJJLeBC0kYhu4k^S!~X={dmb&OknbS*T}X9b?V z!=)T!X6hDua64bNB!j>+}zu^&ri!*ASD!GA-PbixPsAD|Ga0$~lS|vAU z`4v5LH}ac1ShL~7@mp}gpz6lf8M?45JZdic!^Y(GI`Yay?cN0Xi^~*jA~B&& z8y|?6sMs%Z16r|vR5F~QBI|vD<#(s>tzqsz92-fzNxyIX)n@$#*NTR0zIi3r3Uc=S z)*+YkWH7p#aO7?cNhuxge_L(K^9aMD=ZtL7vprhURFUQ6ITOAFmp7se0}|hE0;X}D zMGz~H<+ejU*|7)yRb`)x6rS5~%)o-Zn=GNF9U`o5m;2#=JvQ1W_A`zqeaTM$yixDu zlg0mwYb}B6_JsjLEC7p0qKC7!%Cdg=7h_}PK{Z;b3sudm&Kz61(|pYi_ zp$N@Bh!^WhR)CbBC zKfM)dw0@wmuw%J3Ogyq{BL2pH`dn87ygT|t7)qyh%Y_0|?v^izw&!M>D;{>Uv*kmy ze!&7)$j&WoRm{lLVY^ZX{ylN%cKwLAt155_ke8HyprkvpjS@%u7~IS_+HS2JCCa*x z{~~H-o>@fX_kwzj4&L4vvK1zYihP;o^a5B5_#VG@iWE&GxkI>kWym`A_PPwvgt6smPI4-o67656oC{8zih7 z5kp^pJ*B@_*}S!clDUfX=J8%(n37U`$v^exBmhNwC`7d|Qsn}JUo1$`zPhL8M7s!2 z5%g1L=xiUM*10?_X#_u#zPw3g_;F>tP6ISS>O9lx`37bJ&}CR^;KMdgIvaI zm!UDSb=I*%C0t-b;mEZDG3>0Cue`139F+&gsii&P(_{4CTmt<2RotKS2->qaou_11K36KUuQiR!3^vz0s|64}aAOOVgB99Cg z5T!JFxK=b17sho}G3>L1YtE)oJ_1Jlgy88&^AcHI&{xX#9fW^Cp37MXh$(Y_bE~2( zEaagAlV?6A4$Hz%C&+G>zrGtath}r zy#%7sY+toREGz>n6F*_mzm!mad*GBIYi3_j`0r5F)#Z0>qM{l50^sgnO{0HRg|y7L zp&)db!TVbO3Z_%FNekFZN2(OecNPjnKySe!zU8Q0FB^#~wo4vrFB~oi?pPsP^`kRA z)p@+(jv!DcZn02(D)l7H;w*m#fOv>BCjQQdM~eT|K|M#PS=`g_zQFZ=;h99m9(d7P zI^&86nr5A7#Bj+T#PRIr1BDKNAUsTw3aA)jL^tM-P;O(XlPk8?Vso619J&+Aq<$Qt z!UMLJ=QfJTvi(`L+;PD1ev^j9!w%|!8fNX65KqWr^6GG1@067ox5|D*$#)}5P#|Q= z#uFwrxe5n&9$wexJr4VSvMa3J9ps?4mtU=4KTCO3JZG;=?mTcsPDItA1#0Fh`8Dp9 zbUtkKTB2Jr!=)E8YqLG27X0a)AY3C8ohP|4Y3u8P)@`^3#?2LIdXpBkNZ(Vm*Tqzh zLmPdPu##?G4qedi%9WFL(5|PeMH(jPZfOpJIOuEXtY#0Ack8_W%F@ delta 30 kcmZqVZsg_-@MdPQXJBIBW5}GTzLA%el^IA+7G=!=09w%oO#lD@ diff --git a/tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol b/tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol index add7867e07..94125ab787 100644 --- a/tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol +++ b/tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol @@ -8,6 +8,8 @@ contract naming { uint constant MY_CONSTANT = 1; uint constant MY_other_CONSTANT = 2; + uint public immutable i_myImutableVar = 1; + uint Var_One = 1; uint varTwo = 2; @@ -55,7 +57,8 @@ contract T { uint private _myPrivateVar; uint internal _myInternalVar; uint public _myPublicVar; - + uint public s_myStateVar; + uint public myPublicVar; function test(uint _unused, uint _used) public returns(uint){ return _used;} diff --git a/tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol-0.7.6.zip b/tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol-0.7.6.zip index f1e3a8ad558be3b1d4b75b1143c720adfa1d83f2..51df40aa3d627da03687b841b413540f346ead22 100644 GIT binary patch delta 3562 zcmV@KL7#%4gjgFC|Bw+PBmB#006gzkr@7e^5w{RkP!|8hhN_Z z-_xu=$9p)Mf>y1py=efO|C@)>NOSQ*eg%}xN=0+5w-`GG)oxa&J4#nCeZ|C$B=%Hr zuB~V-GaWs$K*C%Lz)X#(r)hSyF-$n%+bp`qtUzeCE&v40X7~c-l|xZ>(K@AO87Em2 zHe4v%f~KP2ylhN=4VY#yLq*v_oAkRef+qb&N|Lq@*=8yyy~Izgw7c~c%L)Qfc_#-k z-2-^d1g_L%2}TCXC73&7p11uQfl=LxBs;AQf>T^$bv8S)w-H##(9{H_b0^P$ryjwp zC3boX9;16K)?$E0phY3NIgWpEmIoY;q9jPIl6P)+x?u2sGkbQX3N!c`%_a_yceIcC zKD2QXLtlj(W7&FH=e7o~*9*^tDXI0ceBFr@+x5P6Z>MU+dS;O#Nm;ngvuuxWz&YU+fHkw;Dn(lEXvLogFI0W?AcYl-s-&TEOk7#C_j zLcfoR2a5m+>^wqSI>$X$3h#&(aOei@DYE*`+7D2Fou!g)lv-N#RhzPPdW&D4P}J7h z@t8)5DDa4FrnEv8r7SQ81l#3dHoCqB`kGmzMmMEQRbn|Ut!4xy(ke-|OuIS1xqtKp z+lz_jS{mk_Qu%{OFG~pj07y;oz4y=WyKr+#Q$XE^OhKXMzD_ z`ps&8TWJPKP~dIt=ws$#)E!+q0&nMG|03B}T_&0QN_2iyzkl7ZSl}d&mM7q`54m|} z2>^3dFNyUaX)ofk7vjkY869c&_(6KQH4-@+y-;(uV#b~rR-K?z_RMDa z%QTrT?ceamaDwg^rBF?d%lZ(8Ue~iGzW_#msd>ppN$j^aLgT)nxYZ(uPKIu5_ygoq z2es_rC-_9Qy`}>_G4g-+YPC&4&s}OtqC9U`HL=ia;BALcSdIx}nu({{!Dj6(8&crW zNBFC?b=F>W8ALF9Y&T7584Oa_(H^$yqdLma?ODS?4}xS0EWB0==+nt$6k0mqZ|bXm z(Gg_}xK1dl$YD8N^6*HsD&jK17pil^!y6D~0xz_CFPTXUgn%wK8`AvFOY8;ZtD`3h zIkk$0buY&Da4{KT?THs(PkYV*YAcz;5)P4zNSj-_QpN{d*Yy=Fva0UU7>kkkoG0T^ zjw!!m=Tyk~`+O4VagDav&+}nd3!a64vt}p8F$(>e4^E?9z`G%ayEv#n+4(m%*e$KZ zd5zuKV=30U;#3u`mlc3C=0!X3RWEgIrstn{i{D31y1hpy7#gq<p|9$`+BCaDA&1$?efA2JthY;s zhx&KP;T?Dq1XQm!Z|Y&Ov>oELSYmThRpBBEuf`-DW+9JH{DPT@0J2dB_ye7-A1$~C z(cOTutoQLrXa|gt$_gZmr4rD8zOw$kIO<5{@^NIK3!9ehLv6I+O{m$QNaQWO>THls@B> zG_rt&Lc8Cs(QmO2SNes}cOk3_aaWEzc)T_oc}5ZFyTs^33-9Z>f1DOP0iOTUN1$CV z>fq@qr)Wqm2^}j#%`G2r^)NE(cc9s|%10#11vF<+lhHNyq5+@Ilg<*g;5U@BVSnEQ zPm`P9qvui)lL)&Vt4!aNZ5&Q^scC88n zYIE%}Tz>fgO`H`Rk#e^E83(@zzU*+;Y0$4QL2FtZ?70|Cq+xS^&k~G$g^advrr|S2 zz=SO>A)jZtDT;lUr#aihM9|SX)j}9&=pli^F^%loHL{RwZ8bjHWg< z2Wg`FHPGIH9fM@{0mFHBdzi&GNVi5fkKu>j=Vyf zcD7VP3jK_d(c245uZjG=x@ubhz*KR2s;)TOpm?OLi;RGO*z{TtootSosUcxS$_w7c zB)a*UUgFFRR(5+6O-t-Rr_tzkLmGXU?a5@`{RLSE{OdMA_LC*4y(s_##djbmb->7H zI03@4kqY8Y_-VR4El`4#9@6L&WL(vXl6||pE}{t4b*vLvVyc4_28}p$6Se3}D}Qy1 zb}5+<2+K%+f1evIFAzmKB|cn6Q0a>pF@PfqT5x3<>dVr|t#LKPPZyLzv9ufi1LY{A zQq$8;{}x|lB8JMTRB%->JpJ@IW+R_0a=!4`rdr$LKDISEQt`qJ7UtdZ!~;K2ona&| z@}@>pB&<8`1jfIqh6&K8_XS~4Yc+jw__RDipjA764m69f`7-+u+V ze<|rZ%@0*iInrPEu8!@EmP13iwNFBa5Y7K#B)_tETsIPs0h@eKf#s2F8fxY;+{Zu( zNSTv=bl&&G6D~gu#!gJIVPHhQHMYUAWv=@Abnz4hU2f9ip`;z&XFY=;oV5F(;RT_T z3jLJAG7J&n~UJ=FNWi%XHFeor} zogzLAC#-N^R%VWFL44tj!##W627R4`-OZYRj2QtbvO6F=b~cL49d7OX+Fa$C=Esn{ z)S+Z>h@KQEo(ow&-_jJ{FA~FC8E>|lyPw~cfC-7ZUj-`AYLV!VUlz5L?H~^x3C+`+ zNI9mb_12rDjg@_Tw#hu9S1w--M9+Noo)_i3FY@YLMv?q{`WHgY(3Lv$kYG-;il8kJ+iH z#RKpli%&OS2sc-TDl6;sK-0P=$rIP zGb;-i%=)Apn@AH*zZM;c-1f1^;bUwCwUs5D;0RzLk^wqNgGVy|Vla{d@r7ycIx8^gRS z(_7!5k}K>RPj1jyh8gK$(r>SK1GVCc9#2J`m>{LtIxn{9= zt4nfcnL+Iygn()go$r-@k#|#Z7^X1M`!~3}=kL7ulXJ$Tqr2i`H4ADY3h)236m$61 z9}bAB-*)#f;(ZsY_zoJQessNWHw1}?Mu3|n7BK+*?s5zrwcr#GN?5L{Im4hq(ugsH ztF$zRz0=fVrwS^`CulClEPsudOjRxp26JITn))WNo7FHpQFp0-TpeQgMan1ofeJ}3 zIGY`#m|~#5vwvN)KqG_a0nD^idQ9zJL6{Latp`EvFlDs*>Xk*iB%O%pVmZp0GSsdK z4ibSE0$f&mh%A|o=$eAK7a=kIs;fVrj$`Jbl0+gOE038ugfAj59bgYEci1y|0#lx9 zP8CqxsMB(aUizLsuOS|vR!~b1r|us30S`|?;A4gwJdWgggUi0fcHgc4@UJ8JP)h*< kKL9@f0ssyGsjMhh>M>3=SPlRHw}q3!4NV504gdfE0OyjoGynhq delta 3313 zcmV*9+eyzP)h>@KL7#%4ghJHCs!-ntd?O7002{Xkr@7e(X5R;Y}^ZC@U|ug zspQZ?I4Xq*(r8{Afxb{KhIlUofD-aqr2+AD<8RyFfn&cFaQa}c^o0a zT8hhG1N8U}-?3E)^JU_z!G;lr%B6ieqM7ptEwhEiQK1&9KsJ>z_q5C1+eXB38>$HJY1`H)FxiYx-PqB73@5QvtX>k>X@dd`17c~vDqqMKvZ8Ze)!YU zR|PSuOC!^~%>op72FMDWfvX4_89e|74A*?_ZRTM}mz5H^(@eN*_YMmjGfbrQX`nls ztZ1RygWV3O1gohX&mw79e>~xN4GC$^9|!DFr7#C{un&oXs`JP&)42NF)Gzxe>2y;`kZ5k3 zp6y;+a-FiJCoqN+x}${U@A%)nHf^YN_QSP1=4OMqYpVjs&0^ zoNprw?Dq;+ZUDW^8^b{f47XtKoaf%_{~3cvwppDfgkFZn@D+0q8koIBC+_SgVI=R0~hHLa&yG64k;4rVr=NYEIC;glU z=NmzPBNxr^IKM8-wTdwh<6^$(7`cA86RqlVDNILc-H?ymn<>6{z&9iQmGs0;C4Q`J z8oy<&>+$O1=Kem&C?p=WEZPX6xdj`>fU1yM%9q4`M)aV_J3y7($i}vl@`o|h>bqun zFwYGZG$m@EgE6~VMikh7X{!BYR(kfH7P|d^_^s=i8luj3gzK>_f1M<^ZS1OUAkS}| z+h=W}-0dd(*9V2tPjDHZuj_a%W7UozeTAbl}NJC|S z{l-&L0o+P}Y)E|-s-_qUJR!BHm4dD4vDR$PE-zs5*S{pGFjpL7)8VT25L#RzCkZuw zU+){j_*r5e_^~}Hcbym=uW02JaP?ypa#|V`{OT`X+`-?nq$L62^oVUujfRRw^&WP} zf>V8TW|XEb1-*HgC=`Ouka%Zl43}FiM@85Wj^4u@47oWRi)we z#fV2*D+fXOPWMUR)EXVngeY1KZy}w3u@d=FTC0tDmB5q(no?_~P^8n4%nxki@xQPL z*IOtM=O72-puZMa1y#44@vF(qS5iJS)kxeFN@=(Hj3xM0eRrly&}Ecd#BApcy$P@= z`sPw_o7|hzii@(-eR7Q#|k^^cn1UZtAat1>)JOD zg>lLFRDwhMQSbr~z1Ly*TT3?n!VUrF$TRhoUO8TO8;FkRdR44wX?HQI1pLe0_#8rmn*X2-6=G*=P(NmWo`$4#^lO#c zEgM_pyM_OFM#ZZ2=Tg(GVc6lgyiGFP4S)zPqbJ=p>e;oikC3=u&?mzriDl47@ax$$ z2E&-Vn^x-%*cKMS8#jo4%QbD}bj>}(c$C#Y7FIG?G;ymaQigUYEK0R&pK1IW4+?)jFWtW@=_wFkX4!iw z=Xl-O8;P`mBlMVm!q7SntL{s*!DHF2V7Ni<^O`>#LGbs@L;(Esfc7Vmrvr)dn5$*g4n;TPp-hz&Dr{@pka}=q8GK0DtXPRDB?yfTfs#f01jEl&f8vG_sr#OFf66hmEr*{R(j2C;a5L<{o{R7qn{naFI!Wc5+} zCR5SlcTrxKzZV!qiYcmHr)yo)U>fsjlp129(ax*ML?kVfMVP!RB{D=E{6BO9!wBGe z01K9QSTxsNn#N>(1Wz3{sxH~YHL9(IP8*-xr#_LUt|Vzeor(yS{nraqZTm){*B#jY z;3;_QHg(y5J-p-K#cps%Y?<0ffp^^5DHoRDwY2DM-d0GOkjd`5Xo0}@GUSYk@HH~CLeI?8XBgFRVigltHLmz zDe3{1?Ls%Sbj12V!2<+hl-19F^y1Aipm)Fwmw!)xJ0S`)ZUTM{^Ikey_zjLNZPfB8 zq6(SAee|!~EZh&ay2U9L*1XkHf?n=?=(E7eMyjMr+|#f}cut8QvL4?gLDXM^FAT(80--!1H3XS${-f9ImMI~SSA+d&La#lzT(&X#Brz_Wn!g9Yrly&V8SndL&+BfLU`>`%BnL+r_}64jBnajcmQ@b zu{n+##PlCzJhRGr49KE5vO;OFFKA-#h?b=3GMZkak^%c;E$Qgz^3D`wt^+#dYuG!8 zh{0hoOfs?E@l#J+Hv6#4WDZWrt&V($f>6AgHtJ#~tsCtL5m5k0+=MHS;u?73K?|IJ z8j3X!#HN%XpdK;j`D6`Wu`48*O0A0bJiMI2O z-a4(Rbt~91D*0!i%aCBe0E`XMF|=usgb`~67DzyAm=_DTVHlo zMi)3VW2T`={OJv=-_RvkXs-dNKN(SGSqTA{35gFiT)QTja-0-GrsC~g>J8Pv4Z3OC z8x7u`OG?#1cxbx33%lAWv3!|-?m_n3n?up^oe_oA;i_?+NxCLmZO7_zhvJ6eXxN|w ze-FUUyR1xuEYP+=DWYDKAZ~dJOfw=55JJMKj!&csPl(BOOeDykuOA37#B4)`eY{uR z9`Xw0fS|mUf_n`gcFy?FsGGa}bDQE=ILj)qx1IviTLM{4L5~q;I5MAqK=`=b^;^WK z#B@la0Pa-38Oiv4ZY(7co+@TT_Q@?FOA<{GfXu!})wIz@U`}0NoZ^SuA*`tR^2>MT(O-HCB#+6 zN`&#mZ$N(x-(6OS8!%o)vnDySn&aQ@TKL7?g?reqwjNato(+Kt#b5g?Q7*Ntu_K delta 30 kcmcc4b)Abhz?+%Ho`H#hk0EoW`bOT{EX+W9@@tkH0C?yKp#T5? From f07d506b4a5ded16f996233cf0885090c6c8fd94 Mon Sep 17 00:00:00 2001 From: Judy Wu Date: Fri, 15 Sep 2023 20:12:48 -0400 Subject: [PATCH 2/3] Check s_ and i_ naming convention for private and internal only --- .../naming_convention/naming_convention.py | 15 +++----- ...ention_0_4_25_naming_convention_sol__0.txt | 16 +++++---- ...ention_0_5_16_naming_convention_sol__0.txt | 16 +++++---- ...ention_0_6_11_naming_convention_sol__0.txt | 32 ++++++++++-------- ...vention_0_7_6_naming_convention_sol__0.txt | 32 ++++++++++-------- .../0.4.25/naming_convention.sol | 2 ++ .../0.4.25/naming_convention.sol-0.4.25.zip | Bin 3801 -> 3818 bytes ...arning_for_public_constants.sol-0.4.25.zip | Bin 1380 -> 1378 bytes .../0.5.16/naming_convention.sol | 2 ++ .../0.5.16/naming_convention.sol-0.5.16.zip | Bin 3804 -> 3836 bytes ...arning_for_public_constants.sol-0.5.16.zip | Bin 1387 -> 1385 bytes .../0.6.11/naming_convention.sol | 3 ++ .../0.6.11/naming_convention.sol-0.6.11.zip | Bin 3930 -> 4024 bytes ...arning_for_public_constants.sol-0.6.11.zip | Bin 1409 -> 1407 bytes .../0.7.6/naming_convention.sol | 3 ++ .../0.7.6/naming_convention.sol-0.7.6.zip | Bin 3852 -> 3951 bytes ...warning_for_public_constants.sol-0.7.6.zip | Bin 1367 -> 1365 bytes 17 files changed, 68 insertions(+), 53 deletions(-) diff --git a/slither/detectors/naming_convention/naming_convention.py b/slither/detectors/naming_convention/naming_convention.py index 904b57eacf..1e10b5543c 100644 --- a/slither/detectors/naming_convention/naming_convention.py +++ b/slither/detectors/naming_convention/naming_convention.py @@ -175,19 +175,12 @@ def _detect(self) -> List[Output]: results.append(res) else: - # first priority: check for immutable variable naming conventions - if var.is_immutable: - correct_naming = self.is_immutable_naming(var.name) + if var.visibility in ["private", "internal"]: + correct_naming = self.is_mixed_case_with_underscore(var.name) or self.is_state_naming(var.name) - # second priority: check for state variable naming conventions - elif self.is_state_naming(var.name): - correct_naming = True + if not correct_naming and var.is_immutable: + correct_naming = self.is_immutable_naming(var.name) - # third priority: check if visibility is private or internal and check for underscore mixed case - elif var.visibility in ["private", "internal"]: - correct_naming = self.is_mixed_case_with_underscore(var.name) - - # fourth priority: check for mixed case naming conventions else: correct_naming = self.is_mixed_case(var.name) diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt index 2c05a3c403..2b64ccac10 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_4_25_naming_convention_sol__0.txt @@ -1,10 +1,12 @@ +Variable T.s_myStateVar (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#60) is not in mixedCase + Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#14-16) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#71) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#73) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#71) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#73) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#70) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#72) is not in mixedCase Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#11) is not in mixedCase @@ -14,11 +16,11 @@ Contract naming (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_c Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#61) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#63) is not in mixedCase -Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#57) is not in mixedCase +Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#59) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#70) is single letter l, O, or I, which should not be used +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#72) is single letter l, O, or I, which should not be used Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#23) is not in CapWords @@ -26,7 +28,7 @@ Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.4.25 Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#30-33) is not in mixedCase -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#69) is single letter l, O, or I, which should not be used +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#71) is single letter l, O, or I, which should not be used Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol#35) is not in mixedCase diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt index 494253c357..057be1d0c6 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_5_16_naming_convention_sol__0.txt @@ -1,10 +1,12 @@ +Variable T.s_myStateVar (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#60) is not in mixedCase + Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#14-16) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#71) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#73) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#71) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#73) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#70) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#72) is not in mixedCase Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#11) is not in mixedCase @@ -14,11 +16,11 @@ Contract naming (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_c Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#61) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#63) is not in mixedCase -Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#57) is not in mixedCase +Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#59) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#70) is single letter l, O, or I, which should not be used +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#72) is single letter l, O, or I, which should not be used Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#23) is not in CapWords @@ -26,7 +28,7 @@ Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.5.16 Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#30-33) is not in mixedCase -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#69) is single letter l, O, or I, which should not be used +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#71) is single letter l, O, or I, which should not be used Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol#35) is not in mixedCase diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt index e6e431fcce..035b016238 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_6_11_naming_convention_sol__0.txt @@ -1,32 +1,36 @@ -Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#16-18) is not in CapWords +Variable T.s_myStateVar (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#63) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#73) is not in mixedCase +Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#17-19) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#73) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#76) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#72) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#76) is single letter l, O, or I, which should not be used -Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#13) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#75) is not in mixedCase + +Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#14) is not in mixedCase Constant naming.MY_other_CONSTANT (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#9) is not in UPPER_CASE_WITH_UNDERSCORES -Contract naming (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#3-50) is not in CapWords +Contract naming (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#3-51) is not in CapWords Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#63) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#66) is not in mixedCase + +Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#62) is not in mixedCase -Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#59) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#75) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#72) is single letter l, O, or I, which should not be used +Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#26) is not in CapWords -Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#25) is not in CapWords +Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#44-46) is not in mixedCase -Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#43-45) is not in mixedCase +Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#33-36) is not in mixedCase -Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#32-35) is not in mixedCase +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#74) is single letter l, O, or I, which should not be used -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#71) is single letter l, O, or I, which should not be used +Variable naming.i_myImutableVar (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#11) is not in mixedCase -Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#37) is not in mixedCase +Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol#38) is not in mixedCase diff --git a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt index d033db260e..5e446f1567 100644 --- a/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt +++ b/tests/e2e/detectors/snapshots/detectors__detector_NamingConvention_0_7_6_naming_convention_sol__0.txt @@ -1,32 +1,36 @@ -Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#16-18) is not in CapWords +Variable T.s_myStateVar (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#63) is not in mixedCase -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#73) is not in mixedCase +Struct naming.test (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#17-19) is not in CapWords -Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#73) is single letter l, O, or I, which should not be used +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#76) is not in mixedCase -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#72) is not in mixedCase +Variable T.I (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#76) is single letter l, O, or I, which should not be used -Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#13) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#75) is not in mixedCase + +Variable naming.Var_One (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#14) is not in mixedCase Constant naming.MY_other_CONSTANT (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#9) is not in UPPER_CASE_WITH_UNDERSCORES -Contract naming (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#3-50) is not in CapWords +Contract naming (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#3-51) is not in CapWords Enum naming.numbers (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#6) is not in CapWords -Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#63) is not in mixedCase +Parameter T.test(uint256,uint256)._used (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#66) is not in mixedCase + +Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#62) is not in mixedCase -Variable T._myPublicVar (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#59) is not in mixedCase +Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#75) is single letter l, O, or I, which should not be used -Variable T.O (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#72) is single letter l, O, or I, which should not be used +Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#26) is not in CapWords -Event naming.event_(uint256) (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#25) is not in CapWords +Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#44-46) is not in mixedCase -Modifier naming.CantDo() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#43-45) is not in mixedCase +Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#33-36) is not in mixedCase -Function naming.GetOne() (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#32-35) is not in mixedCase +Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#74) is single letter l, O, or I, which should not be used -Variable T.l (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#71) is single letter l, O, or I, which should not be used +Variable naming.i_myImutableVar (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#11) is not in mixedCase -Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#37) is not in mixedCase +Parameter naming.setInt(uint256,uint256).Number2 (tests/e2e/detectors/test_data/naming-convention/0.7.6/naming_convention.sol#38) is not in mixedCase diff --git a/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol b/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol index 3cc7197e5d..4dcfb17607 100644 --- a/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol +++ b/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol @@ -53,7 +53,9 @@ contract Test { contract T { uint private _myPrivateVar; + uint private s_myPrivateVar; uint internal _myInternalVar; + uint internal s_myInternalVar; uint public _myPublicVar; uint public s_myStateVar; uint public myPublicVar; diff --git a/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol-0.4.25.zip b/tests/e2e/detectors/test_data/naming-convention/0.4.25/naming_convention.sol-0.4.25.zip index a448234c6efc12d56a6f8f3b0795d137c6097df9..be41a722754565bfd8472ecda649c8023fe1c9b0 100644 GIT binary patch delta 3528 zcmV;(4L9=H9qJtzP)h>@KL7#%4gf8oFITVAc)Yd)~qtGE5U-_$rN+% zJOKUmQlEz!)E1Y2{n0M%=z(jv&L}YSOM7B;{6jdUi_K^VB0^u)`zKD3`;v;bTNvr~ ztuRW66(9lQx#lnAuM5s4jHz}cUf zktdHmO)G84#>Q5LTFmY?7^y3 z^DMcCsGQv^MS4m*7q@!tG9uHjui>v-B9-Z^uuFYL5kR_@#|2sJ=v*kj8Kw(a`uabl=lZ2Uka+AH3uHMEnMr9wxLTG^1S^z z<26wUj|{5x_;5^QUKPlL#}3M=)R=S?;uIY^smL0CyH(UDR9!q&jg0JwmIlE8G-7$~ zSFAx*ha)1p-6mZuVjQpKncx&CD9f&wtvNaC?z1VG&w^G-U?$xYI6@GA224*Z;h6P% zlZ3MRX4$i7Y%%*2#287w5ltf+!dXiM%Vswd4}(T;>;X|lY00f+S6i#D3@n!a2V2Zx zaFkeoMw(Lv1XE2(W;ca8;cXEXaGEcjD$X#b|FS6!a6lV6r9SnaS2RtEL62yj2uzn z(KOv&TMpJZg5c>9o;q^OSkKG<`VjBvsXnfg-Pj{xM|#!FG%E2zir0&b;iWw3nL~5W z%~vM`lJiNQl!yaTFGc6$+DT~2TlS$TKIX%!1U)KvsTIx77QGDzh29EJ7E4|_0sbq0 zzTs%r77qNkw1uUgk~GtQPgO_@iA{7TmJT|Z-9kTtwrCs z?mVikcfVz42bkc9Ikm34c|(a$aQcvhoR_mg8dV7=u&t=bJj{`2K>}q&sIi_wFBqZ*Kd&;s}j#IRz5o~B!`2`cvH zvnHX?N8F6YR%KYu5{)H(O74d;Y8e;V@_#dN9z{%J-h~90JlmX{X``LUrAAzT(E@d2 zg@oQ%p$Yltk;WsvHl0>~HWL_czm|m%obz{B3koMUV0tor@6bijqTqmp<2x zUt-sZO+UHajPSv%!d0_Wb!nX#t*AFT2d#tnY|4lopLPwvOHYn=>onvWcVB5)$KU5{ zcfGH2;yt#w$zogF3=apnch$YbcQFNBvK#SIEazZDn-$?D7tU`k?D?yIbk6w=6_7Se zdEbuaHMy*p7UxMKY|%bak6U?!vsE+ba+dv9d3Rk|u-gUb)H2fMEzH}kV1q`-m8xz`iI{07p|{i5_H zs?eoDyh##G-J&uSasz_guTv8JmInAae#~#lUih(yjEuBqhMGTrv)d4FGL6XOoMe@9 zIE!>M8A9LFM(_o%2uEu}zbXhetpjne%Mfv&0_Ac>kJ+W3(^1b-cnv8`lI3jwayEDj7YkzLE2Fua)!4u7n8Gc(0Pmn%uh7hW?y~7U#5B`pSbA=bfZtT#0JWO}}fDZyV z5+?(mC6J_v%mS4o!L*dqMlc`AM2=OFy~4M_bU?q_mzXP**kPR7a2sre@?p(jxt7?7 z8WFo!=AtFUx}#cXc-kNOyT)*U&hlVa6T!5D@Sw`;7W|LPc`bRcbVnZXyJaxS)bl7j za9k2#>E*J2K6xL;pF+c^X5{!o=yyC)$24-h9w22{1Q;M>Y~ttmrMyHEyeFwcoR%9t zigdO&ynQkwf+WX#w42y0or_J&p1%@oW%qV8D3;(^eE-P!^mu2sEz-r(!-`~2>Y?bV zSnBFt0%h9GQn%B`M{zY+&fs2i_Z(9u6c}w$-^5OT3FN~FdUpXMk8J+2Qz1rwyze3p{|_HDD;!WZb^wyY=WLXM*()A2 z-!LB)RU5VUB@^BjQCSt1)lfP0-8koF{#x~f+Y>eV?qMBEfo=So=F_~S z%j*GSTZyPltx7&1883xq1UIZbVtZ2P$^%AMkqLUJl<3;c3;qsF6zh4zuC)9S>Annq zMRJKOS@_~?@=F{gAuQG(tf7=U@ANANmT^!hlqG6P4LsM}1{JdoI9%-wl^1Iv(L$#> zo(@MFS3z|b_FESHrxe^s3gVgP_n%EWN0yPALgCI9w^&j7ynm2z2WyqA9Vy?p7nxN9 z|6Sc7G7SlrwL*1jL)<){Qx2se{)O(nbI^ERw$?L`YLxqL`g>XeU+j(*M#IXn@Njqh&aMsYPS{ zRpS^+AT9_=ByKaaiHvSM@=JjN+T!B80RWl4{*3I5pI>E=KpA~yPjwB`A_)B616l`| zin{7@-PUi&5nu{4fUcd`|J`;=?&E^07>gAf9&xkqG^}6N=i+m%y1`r^6^Qi*%7c{= zWJ@YNd!%0Zl0qrQ*EZ4QM6%0&zcI_&pWD!IcvNP1oG!_ z{HG0mclGRZnMLDj*l*o`BIGO(BK**5HaH=-qVg+x54JcY`8HjdccG!RtrlVo;|N2o zD8+54;`oCX%ORM8i_cgz9g8bI$}4j6>Uc7U`aOTU4Ih;vQ6}Anwv(TN}YeMev{v zXKSF8WCUfi|Mkoq@G?+K0Rle&KL7#%4gf8oFITVAc@KL7#%4gi&`C|4s@f2So5006*)kr@7enL!#YlCI)PsZogn zOqgg13X{h;KnG9`0(<2}XSAbb-ToGH_ZYMv9L|MDa1d#WZ_n!m83{d~g=wo6qufqp zU)(rKjazni{Z%wgXZ2$2n}h^^@y$N^*N*a9f5>2dOUO@iN#oKaOIa5A+gn}a@bpjXrmO=z1R5qz z8UNjgi)X!)R9&=4wS4MZaDJqJGYI|E0wDks@WZmJFH!^Q+0dNrQc1f7283Z_BB2}r5bE_R5|P5f&`0}H|~`Kct13?K*}w?<-g3E@$J-% z6|#9!^45xffKI*9a4OPWQt@i`qqT}QwmVx3s*fXhVplcLPqNkI8z2&mCo}PNFewCQ znp$x3s~m0&+!2}Ct;l0zgZwF{nx}EbWnx4 z$!w$5-_hg;4c2i7m_}>VM)Rpf{RixBc;Fjq3zGZH8}WFELg~=tp2-w4Nz;7mapP{R z7ZbF9h94(gs>ZJV$3Z-zPKkLQdL1;lSke?#C~r#BMMW?I;LvxRWZ@;*lrJ)q5iNhN z_02>`K{p9aAxFoB2n$iNvwjMp>WKbW;d$_y9BUMuFo^uWdGXDxJ*VXIn2lr#&_1vk ziLK$`A0om`d_@ohdU&;;IOhb0oEjddWEMVu7}`~;F($QDY?=SWi?#VJwFi^+c6>JF+8wQZ_5YpXyxtaW7E8Xb!TU!3_vv`D2Es~XZ#sJZ-6)OKKLnEGDu3fg~ zWEuqYYDasC0Vr{svVI#h_s2z7$fp991g>bB)MpCJA}NlX5zB(M)RIr!;1uYLrDe<3 zc?&%O?GbbX6~N6kar`o8hx^=B3cqB3$r}tM4tcn<7QKp9Z?+}QivWk~0cnpcwSxNF zYYXHtEhDJ`ZGuNHNkZ^vdV2W(KG$%NP})lFnp6{B15nQrXU>h|c9P&h$A2dUB+Vn@ z_FkK2#nhWglX%MX>^hk7y!IC*tnPD|D0(K~#R`{||67Kg2*S>BbrafC{(4dH-QzWGQso+3c}6()&`|#%>_RfnB6V; zu*x904#+Ve#q3R?r$$9nemymRU}g(NBP|qL*8VULD0+q+FmeUeIy9outfXhJ-T`0w zoiaYr#D|7LFc;(W-Q;eI&x1_H95Z%zr{4+J_6AQ{^{b$~XOMJ}#99tGuK!jT0Tj#x zC4DY02K}LKk{8!8;Wz>Og}zJV&i{aJVTwGu1Zvz*z~T#b+!1QBjk7d=^J-L;{kLe( z++J#3f#7~_h~%z>0DfE5D67rZ&avL~P<i$=y&i~VTcsGf2PEB-sV0PnQEkpbMy2TG&(1EFY99S zEejky=SawXkKUCy6yY;};zx8EK0^{*<`4}zkN-zQNh@r?vWVj?qp~jI$tU3&Ejk1p zQ5|Wd|JRh^*MP;D(Vl!#2X>z##3KU*dOIG2P{#S|Ie!=s_bBd}69}Jf1wJLFY+Vyp zxtDQcQ?2tbpriTcK{MwS3J;S2j_i!3M3t{Akz!0U)UHK$>2F4VW7H_5BFyt$0%Q9S z{Rz!mHWb`ud-6ef=BJY;3?Y3Ot&64mCizJqoj^3%2+tbvi!;?`KJSYV&}P z9S-B^vjktUp1YK=F?43;G!Z2P2_zlMBCcUxr{OFU8WHJBdjVntL~N|YT1h#3(-6hY z$rPHJm0-h+i_=hl)EizAy|Djw@fGjLCsW7RT}g2P(bL`l7|_w!5grbJ0HXv~)P^rx z?r2q32}VS!XB0N=5E4j+n)dhB3nIDj^|Vs?KxB#syyO%&VjtIm3918oGl#R~-Itbb zC@MuZsF_5B3_fSDyHM$uVOmua-)sEQ($S17FvVPyU~}PrbUrdgXDf7&kWAl#dSygvx-iB+P4NYRVtZ|TYAb{6potQr*XCYV9W7WNZWji!(=HHd-4Tb1 zK&TA8(Yy42)KOd=4{nhLY>6#raxP|v`UxOIz7D~w%yhWxi)zL}7;I^IHr=&X-n%|( z+c}J4{f&g8VXNt|>|tk6&R}t6^nZ6m%?W@EM-ZY)BU)hJ0%**eb}PVLuTb!-wp>kd zwrf1ji989D@DHGW5Blhd2L_S7fj(|hX#~hx>-G}c zFfx>~E8nu+7o!5$DboiosGXXuBQUJXnElssP>6EugwO;hc6E4wx0UX4knVb%Op&~Y zUo;oy+Gw$F4!gn^45FV!CmwD6%4bF*NvU{ewAbUoh~2eYAFNa0WDR z5sIRJ^mDTu)X&rq5B&xxBP5K;7&Pko3_1Qn{S;%M1zn`>kwE5&l+GvM{apwQ9j2Jo zaGbEMfn&^-^#JJv&1*t-zxk<1%Aq;07g!2xIEduHuniUGtpBoX?yF$Z`ji-AQ}obR zvq~3#{FVK)?EpmCEiy>AP0k~xmjM?FBpDWeG@X$2i02vdQzCc`S9Snwwsch!M@R<@ zRFoA`BTNYM3p%izk8LD(fGe5!%XK2KIcR1<(yyit8B-SPa?*>LXz5vy9e%U(a9cgG z$`E4stbR$(#D~gaX4M1}lMHz9pC;f;VD5RH`W50^l->M5+O$EWMz1$RzM5D-0sO>& z;(6;>ta+r}8@8XoETC{8S8&9Gysu28ED zWgxCgunVc!1rLtF8p{!v4mXp^72P=k3iH1bH(J5HXxk)&5;u_P~I=b{Zoo0OI0pSiUH&SBDTr7t?otG1tmw zpx0BSAt*57QGUJn$2m-$=edguo3l0eFYSKc(3~6N74M@Z+B%w{FSHbn!CfqFPukOh zzuPwYlX||_Oqyrxd8B#hWL>D@1-J1Nj*VK(nu^MDwvp9Qf09nJL2zk2QgP zXBCIO%+NOwRmyvPd`CHIm=U3nKkT_#^9WSU%KjFeoz)$XbNr2)Fk?kqgR(scsH<>|*7D}U9Po0&jV(-+NuI{qu0r@{x7+%*b(7O)npp%=aD!cRg@DQ;DhdeEqDZ~zHKmv*}4}^ zK^DH(y7#>rygdJ*o28h4k{z_S1|_4IDl1EJ9oBK_qNUTjGewKSQcf&5L>b`LOCe=; z0&$aIkbFod##5rv(PavP^VaB7v1a!4c|(OR@AY~jHe;E`6PA?~_&AsUCB%9FP)h*< lKL9@f0ssyGm8>WWS0hz_rzH*m0KkKjmkvz^Yz_bb0082ynh*d0 diff --git a/tests/e2e/detectors/test_data/naming-convention/0.4.25/no_warning_for_public_constants.sol-0.4.25.zip b/tests/e2e/detectors/test_data/naming-convention/0.4.25/no_warning_for_public_constants.sol-0.4.25.zip index 10aff7711e99be35362fb893bf8c6fb9d4c08ef6..75ba539c315119154831fbb974dc2bcf50938fd9 100644 GIT binary patch delta 139 zcmaFD^@vM2z?+%Ho`H#hkHKJ}e)x0w61hnmh1*z?BYN!wcXs9+?OuQT!xILTuKzQC zikV~_w$EyBJ)eAcLZ-{-!_^5-S4%nBUbm}?-R;}f{b2dGjLlI}ZNHdGe3M@nbuDBQ-9s>yfw`Gq@+4q4xb_^o~Z_m(w5&kDtTpK3+(>(V-M=YW8!{UE+V@LvESCB7dLj3E`xl~| j-#AQiO25Sazwn{$K!7(RlRX2PO_TqyB(S|?VE_UE!lOG` diff --git a/tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol b/tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol index 3cc7197e5d..4dcfb17607 100644 --- a/tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol +++ b/tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol @@ -53,7 +53,9 @@ contract Test { contract T { uint private _myPrivateVar; + uint private s_myPrivateVar; uint internal _myInternalVar; + uint internal s_myInternalVar; uint public _myPublicVar; uint public s_myStateVar; uint public myPublicVar; diff --git a/tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol-0.5.16.zip b/tests/e2e/detectors/test_data/naming-convention/0.5.16/naming_convention.sol-0.5.16.zip index 44c8707eeb2b417fac50f9a367eccfe2de96d252..52071feef049d2b5719a80688a54f9a794935c77 100644 GIT binary patch delta 3546 zcmV<04JGp29sC^_P)h>@KL7#%4gf8oFIUi)8b?SD006y)kr@7ebiVgG`PWtQtj-{$ z43fX_hdG&*YV6N@_f+z}HlM^x*THKLB2zc|@1GmZD;Fu=7NTOfP~TQ%t3Xo7KQ=2; z_7>S1@o9gIl}@c$!j$hOkf3PD$D#C7vbbZuv|}X<6qfIwZ^t+|vJR5Y3+Z$jpb3Yt zYUvcx<^9bDC=?WbZ*uQHv`N1RKXyqKLHm8)WNl#y^}}R?gAZsWS!AtCZH-J^w<>(Z((sXVEzp;gJ{2&%SP`DSz(OGwlrABAi$3$f zDNyiz6dmfc9#1I@(D|&8VBIhwyj}@}Zl@0npzg-R67chXHn;#F)FoX?VWyG3=Sbf3 zn7Q-Iqqg}WXL^-sjekBD{|2i#xDh@|j#5AL0uy6IcAFdmQ_eOXU6B=~=q&04M{>67n<*b@3!Hm5Sc&6Gh0)qzmxg7fmJgecZM z)yg3Xs~aW@huKqzEU_mL{2a52OXL2=OjAwf}OuQoaU zLrpEIvPiJ;0X2ff*`~h!Zvz`O)DwprSHK>w0>k*ZLq$I<-R?H6cfNH3lPP>lIj0j2pC%UXWIFO|o)+TCYYAwcRgp zoR3dbCA5J&g;Gx0XKgJSf`&0XJ%~=-`=m+zXJil96C0;s`_HD(@G=fM8X(#xdAL6{ zCo3KFj|i?2AD1#Y5}NLB_*ciR6^;r_>fB)tu>rdxabhDkH+{m;HIn#>i0oyG`sUt$ zk>Yr;8cL*~8n7vI=<#Bbk_FutH=LGpbBxKbA;-3d;f1TI_o43;2h`*AN%&DTkh4haKp_)P zG8ol(2nO;6U#w@po0WN*SyHYLv{xFJw5F~8H&rcQwn$8cLAJoitHlWmk}!nE2rR#=SbMMu)wvXaX3C`Vkp{|8x**U9TnPDp=c5O4BFM zma@1QG&@8R^VQ6?&4M%50I#_M>B&-!&7#{>h&VEeEhN`_;yG&B+w4dAqb)aDgyMX&!m|kbxtHWYw2bOH?js{Rr>{)kznh7k2`-FMblx zB(ivzmo&%FUGxP^?Y>gdx+n+;jdHk_#;d=bUUkxa0j*OtXjPHV=0i2LV_lg*WpEbF z3Vyt%g%$7&JY8TcsNB(l)a1_o>$IdgVhGsoP#nbE6{61MZW9Xw=ty?llwM3q|1^pCtjcd>RMxW$Qd0^i6bn3sx{8uGoxO=~6RG(yZ2L6r6A1 z2C$_Kc5R%*#rxOJdMp<2L7e_;t8l;Pp%VWL8Q~3E&?SRfN>`~9kERA_20~(-I zW-Y(7^h33bd41hnatiIP*ZSC_OekxA-^bWD&BRu3g>sEEbhCgC}MPbS0lYj1b|hida>++r%+ zk59y`$5tAP0x=X%%9RUKD{u&$2+@hvT0=M@laZ zvFLYs=a_+RDT%RJWL*JOEf5S&Uqf6pbyHKiWDz@ANZ{)_(e(>`)6EGTR@KzhxSxnv zt9S_;buZR`!vstodCWNRnI#6PzJebxHHx;AOwTvg=phJ!u;asLJsudY6Wm)&wY2gm zB#P4_IS!@u4mKcd({CkvnSckP5*HE-fe@th?!w=F^QQ&ECnOkcJ-yL$xqt~B`{f+` zL5SO?_d!-{k1+l{)<-MY$hM~9iMb%CYj^g}Zd4I}<7+UfeQgqtt*HNd+MAuU&38>P zPZSAY9)~IAm%b&0<;j&4W9l3365tHNNnZ6JzJ-EX5_cdV@z*c(fQ!QQV@Ra-z^1@s zAJJtoXLtIc4V4V};ocFJ9Wsk;4`j(cj!Ac+T$NN-U>I^M3%zGY97Ly>-w7GAxmXTq zImQ|filJAT4DhH*uXr0+3isp`Szke)c$7Go)@A8+vkY> zw^e}*o-3w?u2eJjsPWtE{C2%+)boe&b2a28GIeASUy+x zEQD`FeYdF!dCw)9Z<ZgKNj94k`=b@i{m_j26e_#$%ya6vb zh+^PVVjQ~wnBWZ+8KzB8omc{Z2Z&~g#?*8vmTx-wX`Y4b<0e62K9Zk_yAUEssv7-) zDSFWJjHFmTQVJp8C;%jjDB*8=V#Sn>i;1#)=uhGQX`5X9sc`{hgVSMVO#z4o+?AQA zXql}tG{TGzF631E>wHPB3?kxxvoL2W7NWAI5f0(*Mf;PT51Oxo2=i*GV6e(e>TPuv z*ZyhL4!8WB;;=6_kN>PTde#{$88#SLl&>!Q%Fii0Fcu`Z5BpGQkfRI@r8!g?3F3S3 z%?DARHr$Z%@T&h~CC&G2h;&5(#6|fHX)8!{vC2e@6A1Qyc)rFvT$AK_c7)h7??p{VF+t%}=H^EqprHZ^ z;NmcmoZmIwfG{An96!KZQ+EVdOcJ7+TQ~hJhClNxBbH&-w6;g-C{{lGMx<}|InkE$ zUx<-p8t@;ly%#!e7%hx{_9X-n0_Ai#j1{^MSN~)+LI4r{av<0V_S_?`i*&A86m@kz zEtD%C7vp0M!R-PCd9VN&|5vM?4;Yn4C|(Rc^#f?SGo9Wa>$+#oH5O)j$MXyzJIO{B zV?mQLD-Rc$DKPpw!7m4K?~M{FWDaxU$QW^KO-BJ*=GP^E$WaJ?lnNRYtNx09S<|&s`(*aK2pZNKB!c7d|3*Va=wB#0gn$)lI>9GS%w3v|v(WOWD^T?^P zYY}q46Kak!>dK2QXKxkc=ujdDoNX_JXOg)v{^w9SP)h*@KL7#%4gi&`C|4zw8f+*I006#%kr@7enL!#YlCI)PsY~Zo zn1*9nxgDQ0N;m=&CdA>%Ocjep*Wc`wX=#uwn8Us!9AX+5VsDCP|KS$DDu|@ccMc5N zOxv7+O@;bU;a2*Wj>9J?g}3O#X!N`Q6e!8lKfQ#8uZW3ME_a-G7*Xq3biER&TGloo ziN3|mTIiapbbncYN9>uhfe}^T0pTk)7`^-dZ%j%|&dR{~=oACHru++%3voW2_{zPA zTl*SWDEF52AwY4+iwnjwzD?_AfCokNuI4T#Gs`Z?d-gD|eWxNJA2B4){CZDmoWeHw z!l_W#HLp~HS*lS}5YV-d8lh@4Tyf-;h$0H85z$l_V#B6?5UB}3=<|olyYJO4n5B)A zbyH1Cn)~)5j~t+fn;|LpGP)3_C+{X-q>1hG;BOM_YDFV9TmTMDfQwbzD58Z= z40@N;4{LxTPjB_@-W18mHd9kgGXm5ANM@a{tFdr@u;Z$`>_K$5T?M80qEtRt;yVpc zmwxgx_d0k~cTW_^hk>RmX)L7AZ!IKT3($^hEHoEQL*Vel{kj3z#iBduib^sh;OC~$ z2g0y9DlWvZOaT1^J0qzN+`MFd&l7Uyd4&C>kfd*qQ~|=rETaj1l#eBd_5kh35Yf+E zqh$wwc9SSF)LmKe$5}8@(y3reTmnd|5&~2PR$uZa*I*;O=9vqjX-(3855`Cs0??ALXZ~N5-TF{ULxoNyu5eD)cy?|+0ZPfGz9YTRa94j=< zJ{A(cxJiF%Fb0}Oj5PLx_z8HPsPz!3M(2os#1LligoQhwimAQ81g5&>>lvHClN-HX zJV{~oW#f`WF>kx%0i|A^6&3luy6CL*w)kHsh@B6t>qVy2cE?3H?Es>(3dcL<**&dy zYN!V~6;jB)TeO_6+EGtWj0!aeP6y&Q>L@S`;^5Amp7E4z+Qy8ed=3%Ba}4Rj3#!b2 z*US!gv|b#RrdVRNZlwmycEi>R1XYu6W>G$}z>nCwU*UX*^DNe6^ohQ=>JPuG!2Mwk z=|u`UZUo_sPoKY$p{9H|S0g%Ow^3$>0}U8k4(X>WJW95XvQCIo;@JL#Cld%zcoqOF z;EJcpNpo#V?!L-(;u}fGiDAAg-=Mh@7`d{9gM&D3b5_Yet z({U*1KA6=ldGU)BenDlC(dRSN)Fk`_x(pRvCr|bg!iyE}&s_FfFc1O1K-npOY8xJ+ zuV_%??c37AZNE+z${Mm#LQU7xy_-T`^oOvM=}@TJR*#R50*P}{3W~|ehf3k*lsrc` z5gKkL)VBLLQjtWU(MPSXPfLq4x6&3woAkuySHh-S!2m*ULE@Pf;SLl+$eiJ(<|**N zBF-=NGJ)t!4y%9xrsM9*Xet7Kfl;uG6Gpy*DbBMbSmQ7tfzLmwN&5{_Y05gDrTAq> z9}7)t9rOPJ&$#(lEDR>2qF|`+k10k821$~T;QnBK)w*gMh{Lqy(Xf)|^Lj*%Cf`K( z(|{hsfS)%4J=uwyw1ZsT<@npV`q~%ppFE4R$>T6us07NJ;mYlutF2&vg_<)P-XLxn zWKOMxvAba%!3(b{7PGu+czg>HzXQmXr=seAC;HBqgfnRHU|zGzNc6YE;viC=hRHMj&Je?=QIMCJ+E(R(l zZue0(%lG?`9Zyu%fh0Jwe%}}6t3`+GV+jmo$#b#60@=JV%0+FN=T7u5XN=0UPKVxm zQ%Vzz#2D~zpI|E0$&phd1L zq=&U1GudtNoXKtA!d9E^@n(lk*D**r=cBxAJN z->)WsgsFh>;{ZZQ31_JoFl4p^)+tCvyza~b-%RcM?AJ?t`Uiv3TMf8IyOc;+6qEzK zhDmr;fZM@I3$2fT7Z5m|V(jdPQfL!UbB1u-#mVo|^NZgqS(DlT0=D!Ku*M?kGmsm& zr&3nD^nqcYR4s6Qi^Dx`fK|T}^kofsFtHZ1CoE@7&_}aybtHgWIg8_&`g*i|{;ot9 z6cS}NI9J)A%+RGJnE~`WfL4geswkiS&z;XF`CI6+AUZpLjP-HnoB$4X*h!p!#l}rD zo}ePjzPnv%&ee<3tiQm(hTgm3OZ1jdM|&L^MKa_k}E zmM`HZQuZx#FQ;uonbQO-EQweD0nH;L6zdi^BahvGk1@&iN^z0;{4cg0)DP^4UeOiC zi_dEqHg|W=rZ+r_w!h}-W)4k*h4h)k7MMx8P(bzC&RjmJvAfX#U$I9}bU@p~?;4W1Hyxl@sEY5j1S(dJvL1S0yNzn-2@OqtFs9|M&%e*4fbUJP%z5Z}gcegSE<*n6OoEzVToH zjH0nhV<FgziW0f9i6%@ZFe%`^gyYOc6af&T$9?CDu(0!@&z=S0f~Rc0fiDTc#a{&caD zI$fhvAEz%vv>rkZY23?_bik1a9nyAxBKlPnPvWYH2`02OX44E9l1fTyi~TzSKw9sn z+oZ_{)}w63;6C|g!#GlTE_F- z2TYeUKgDsEys?DjM6Uo|(K^0ZCu>njbr-Y+H5&#|-AhIg;g=8EEYnvY{QZ)D7QkiU zONqlu)2$}k(2g+e`RXxX%gZ*Hs7S#`2I->08*wCB&}?hC&DH!J@T8$Fq%{y`h$fbC zV-0KQCfZ#4i!}7PH#Sa%{isv?UN_y)+I6yV7 z_{B9&d;Ju!k{EkFl~vJw4~y0}4(n z;cAU>;>bSb$PhzTaRYBhCJRrUxCL5{pZ~?SMra-Xg?j=eZULeW5XLW&Ty0H>MUKb( z8X$dtL<`#LJS?-?mIG0L%+&_fJvwUa=|8#h8E>)@`jInUE_JU85O1~`O)05@ap!9( zPR)p>U{bmpQ#@S!M5~U{)|@{d?ia2;7%WE&AE_$G>S*)KXkC6mW^9{>B)ur;lIR0d zs#fDgB>fz^kfJnBJb(_8qDZJmmdaDGNX2t?;R(=kiSU+8qWvF#Kq!iG`oqP0SF_mz zbI~H2))0lvV}*%SwvX}=hs%RoVNfTSKZ_M3CZ$W^>H&GZV1fa?@g-!hLby*V-_pqc zMaXNC6yX%C=LJszJimf4owDc4gdfE0GR=@C;$Ke diff --git a/tests/e2e/detectors/test_data/naming-convention/0.5.16/no_warning_for_public_constants.sol-0.5.16.zip b/tests/e2e/detectors/test_data/naming-convention/0.5.16/no_warning_for_public_constants.sol-0.5.16.zip index c1cc97460a84a0700770d8195d9284b6ee5a0399..adf409d405ecfee66965b3152b71955dd5e8a3c8 100644 GIT binary patch delta 167 zcmaFO^^!|Cz?+%Ho`H#hkHKJ}et4nJ=De93g}Yhm&&0UDmyvoUcHnt{1ItcrPSz~J z{W&uh{PGA}UaPZcQ^b}BpG$YHzgDIFX7h`W>2?eMHEx;MsS!7G!`TI4u{*+E6o!Al z@^9zi?&I6%|G!ir-5=o1$YjreW)lko!(4s_26F}kXkY}f^Cru)y0N_j$}=zk0MJoA A`~Uy| delta 167 zcmaFK^_ojKz?+%Ho`H#hk73msjqt=>vu@7bDBR6bfBN5x4feMT+R_alOq67KSaQhw z&D-*AoT|T@ZrdH4`-jib&8zB=r&%^v@Djl<>__L{PMz~Z?lI5ZS_aMOKNF{VG+M>7 zX_(Em3qRHF74ZK{$(@V721~j`^7#QaAGccGlAV32nkUd$N)r0K=P?muK0KhRk A3;+NC diff --git a/tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol b/tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol index 94125ab787..7d81c39549 100644 --- a/tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol +++ b/tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol @@ -9,6 +9,7 @@ contract naming { uint constant MY_other_CONSTANT = 2; uint public immutable i_myImutableVar = 1; + uint private immutable i_myPrivateImutableVar = 1; uint Var_One = 1; uint varTwo = 2; @@ -55,7 +56,9 @@ contract Test { contract T { uint private _myPrivateVar; + uint private s_myPrivateVar; uint internal _myInternalVar; + uint internal s_myInternalVar; uint public _myPublicVar; uint public s_myStateVar; uint public myPublicVar; diff --git a/tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol-0.6.11.zip b/tests/e2e/detectors/test_data/naming-convention/0.6.11/naming_convention.sol-0.6.11.zip index 86ce8485c735b311c8de39cc2663f7500ea34900..d46a8569c0593a4ec0a50b693c66f7c8af729d14 100644 GIT binary patch delta 3755 zcmV;c4pi~l9=IPEP)h>@KL7#%4gfEqFIS+lfl&kx008lnkr@AfkD0P`LbB;;&mx_L zgm-ZteEh?cCR52GYph&9oC|m>OWof^Nnq-_dah6KEp^YM7?nQd#5AVtxom8qps+804s%=4zRv z`do?A#+bF7OrCast+i~_AgqC{4N`=W*6~Opj>Had8uuaaJI$skevL|Cz$;R(F(_Q) z5RqKCJSNh$EptvrpGVH4wvw+N`Vvffh29F1t!nqq&kngXq$rQNL)hl;p=ZYSzh`|DQ4N!Ky`tB~OC zKXmYSNnRCAibO)umU0dzNUblyXG~C|>?C2hd+^G%qMy!D+*1SFfME*q2rGua)xht{ z{JT$C)*e974;{xrP^=0I(#x`R?RY`%Rje+$L~lGVqgxDvPiHFq`OPbOSy zi?73N+^-bBUgzOi#T8@x0wWv^Q{iz*~y^liQpnU5djS@7`IZN)kc;(0-6luU8ZF2L-{`r zYGIEl-Rz&=y`WcG##mV6%28B7762z;GcQxj>p?kdWe7!pS(84g0kwY*-FV}qAY$e? zC`HJBSmRaV+0?MztuguJ=wiL`TOm1)$gONFw~0!(SIGP2OofXES4CJ}@<&Mep0V!f zR|4Z|iZ-{2L3X)1iT36?#u-0%L;RM^GXerfSS`g3;T{POSfSR15g1+61X50su?xHS zY{z3Cv&D)~;L&6Em*gek_7j?3^W5g9jX>6a!+AzR(6tv}>aJkd>{e-J{UxVzYGFKpRB8tQqm+-WYl#pd`0YtJCnkw=6GQfx!F1>6=(hZrG zr6YO~wcohZF4Mxn2mzBB-fzsRv8s_lBha&@Z?+eO1E z2H;~QTqW@!r4>-9Tuev>bAALrs)R#lKPS-J-57TEh;1js`F<6RPuB7rGYB(4XhQ6{ z?JVuIZS$|9+S-M$2Q?Tk!cr)IEponp9_L%l!Qk1ktZ_{?DA2nC=|TS&MY8nyjE!#G z$AHzcLu8CK3B1wH5OwNvx_}Iumln+*j14W44V}Md51M4~bOGAy;7)(D$n>C`K^GB0 zfhSQ!I`fYgC1^#09d`DRx6eV=eSZqQkCCyZI(|?E9r@~v8Y}y|_ErXcD73(TmcIu5 z?K{Jsx_GFN?Cl&wcbss}ccHfQS4Iw9vwHk!?Gr`Ai6AnzPsG4uC%ur5V)~gWqf{E! z{k$30P2i*4@YB&Yy%5;-28*A8+cW$6k7V%Ysp=dS{ek4ju5eYfn$vV_G+YODB8QFmpS%fZh~J!tm-{~QI)uT>JY(VKb?NT^R9tcg(BKdG@*oo&FGJroqy$9 ztM)KxIDudieXgOf$g;pMu`f`f&8EvDgad`+wb3x59jSI2NGBS#+vbpf)aFC>oBI9f zQFG%3o<~Suigm!&1x*xB1lP&??+yd33K@r)hWq++d0Jb$!*c(WoJGICK0TymcM zBzNO$?#TJVoH1o&zG&!RtxXUdz0ko&nbOxJ?MjZSo5`-nt4WJ@V3qh_V}U(!{hWB3 zH_N1UDt8G|t0Bk=5?536C~lx+=)FlFt+6x+YaD9-Aj55nw*FQSUqp}jw?%#s(kVST z@YNwQsi4o+j=Tzg7thkhE_EG~tUei}(d2M7eKo4uNUo-n>5FPY20^7%NMF87e!8=qT+VH$`3;8HsHV9gLKDAG}DT<vAv|eU0L=h@ z1unUkbN~gGQqEZ`SLh`X*p8!sD+=ejbK+BLGNpX%GeXSj{tzqg0BOekgeBsWI|1iL zaVHy7Nrqp0N&|d2bxYMEIxv=R>(A=?J80)u?*p;yi#LOQ{JK1{58+3z5zqoSEj)VJ zxHUO{uz1jQF0%`Z_IG0HtzL1EYBLI*pB(^Y7ozBAhBIpj*u|277neUnnJ!QtnURdZ z-5Uk$j3#WX^H0Chyz+$ba92>+r0$1AWJ)ECFdgj%s3r47#G#{Qo`wsrujereMY)!; z)y^5hcH!Wbi|smV^Qqi!zqg3&1dJFl&#~}-(#GBq)Qdlijz^J-p=>)bi09;R_7eNF zcbl-&z|7~qPnXy`P**BQu)`ARPHb*2Fk{r9MjF(96i>1`zB=S3d!cXXms}~}}g3|S63Z~BG z79E}|w69Zox+T}tPZxSsNr!>87Y_J^r&tGVnHW}C}@TN_0IVSzM15RV8-C+y5O+0Vc@HC0&d-BHJr zVgiG@#3bGA$A#f?EJ$nQ`;D%D8gkLkk23uQ^d8G2x}l<8;rxQ{I6t?J^>dWj|A|c} zczTBZC^hLlwxr}uiAcCd%aCI?C*Hrt9v6T2rT0&gkH=}n*|Dg-PM&N7~Ubi4;qJrvC`%$!xh!;BQwK=??b-t4*`=Y zFI*iHPKhHjmacVwm^UIU4jPl~7X$>7S+6{ohF{EkW;p+%ixpBDUBgsj;^9vlPlO z6CA0Fj`R-#hS&9ihhp70aH3MK3JhvT2^|Mhge7RSy~_MR#|F<>E$&3G6jb_fq)nN+ zezIv_eOBN9=Nq5TP)h*@KL7#%4gjgFC|C2CR}H2P008KWkr@Af0frAzGE3nDd;k!< zK7qoel9YuvypUkWnFeK?-gU;~3@BDrs>mA;zL>4bw3BPrRbB3w0zSq`20&tF7#ll0(MT@u(t7(VP*#8?ygKMYG+I}I zhlDk3ja3VCc5J=v+OzS0NvN|&eF+rgFMBdJh&)4yS&(xz%0ko8Syd{9`=P+#fsX$h z48+wVWAa{)F8f$$8+-GtB24NjEWV#78n>bKgf0t++Nlh1){ci~3Rw>E1H-V4if|wk zTjGDMm1ZrLQrcfp5GPA~2~OCe@+L$vTZAV}40;yWDWsG9RlnE1Az_v6hbegBCf@7HU}P z7K~+;W!1r3L4v4ce!AaQCGRYHRH$4T90qd=qCw$*jO9)G31j~$#6f3{=!JKs9KKax zfo?fhpLr_L@6R-fu92CASa(QfVcq&NgDS;)T#siTtEyx z3KH-~6E6B5lkb19>smNXHr%MqTlEBVJvm4uHxnyCk(3|*OQo{w3KCOBA*cm2d08x% z$R@sjz0;Cp(7t4~NPC}$3bTJ1P#856O8?*S8)(T9mHcJ5No2t2=r-n5BLCA*J&m*C zaBde2spg@pE9eAe88CYNJM3kgOD|j?4Uqh72uK1nVX^zS+|Z;dMy+bnNuW=|xn)|F z0bujyJ_xqGdVLZ4Wz?l|9FB$Q*T}^i{d&TGrEsJ=dxGSK(yDc#)&Y*qSNEF6W=>3I z;RYiQ<i%da`0W=N!+z>!6p(-F5!WhtdRDAHLf4ln^fl6s{?M1zTs1Fbmf zYQsQ>q*OU;`c+-?e(A+NMqnQQ&e}c42zYC7i(1guz3w_eWwPch#2`6VDD&qpB3(ll zV7d(F9Vs{<@n9wKyz!c13P}xeoot1FM<`x)h&JG9L~Bq5&XTl;Gp8Xo2>%@XF-m`t4TVu#3aRL`Tkc)pe1TnO9nhvHM3;iRK_dAWcef&;t?rG`1 z`{M{@Zwzud4rTm$fed7uH2f%mx{S=a-ARnC_c1M*%BX9Fe!aB^z2fMlsMRK||k7^Ja0 zD!^q8tH5D_$6kiAzfvl3_PCNQ0N#!K9H-NR;uO$tj1K>orYj2XzoK&K(oeAYebZ_l zvVu5;Vd?<^nv|H7mvBgu5Q`kYQK-P+XzOmIHX7iy+>6{Cc-$wr2-`h>gwWQNB=3Eg z6#o|_O^%##Dtv}OMfwMW_jFr%)WkKaRatVP@AKb~=Q2pKnH!aKVceET_rmoqP$u;fQ?CK*MkQ6o`-{rX zFo~GE{tXhXit~-!aLAp1(_5Qdoj-!o{Npn4X+a;7g`~4Xig887Z?Z`I%j2Iv+w%Zt zx-<}Qi$TN|q;t?}9X@ZGFF*ZC*xwu{U~K z$f@ElRa-hov0Ro+(a8wdV+sGD=c)i|M~v68Jt(sv)sT?J7K&|5fFt$(6Ylc3If57Yv(ad5XpFrVtCe( z>M|TZvw|{sb;>oEc7O&%XZH_rxx6ubjUeCuuy8>iPg?(;I#Kx|T~~y6_ZU(q`7(Ln zigRH4T{i^Z{)2sY&4KAV?1JW5vf4!kAOz>eUG6t@6rdqQ?Q;ROy5jfg9 z$f;WnxZdIK7P#|CMmcV%NHU{FUKov=J!seeVi@fg4O^PaHff1;{Vf|9@)W}l59zIx z-f4{qTe(m5T+51jj!J`f({9bnZQ`zmr_pT@GWgXa16f%elP?;NGqqbBos@rm21+|o~e|S}tP;2L5 zbM}8V9@YRqemda9F9og_{KwR+CYRE}dnKJd8iNMz6E~8gAWW--`LeQ)kPgU)x@44~ zqq9GMik?Oc1zX@*7lP z2x#?swP?S``tb2nqhYk>MRBx@fCY@ANAGZ^>Fp?p22LeZggqPUY<^QzSUQv?H)4pz z@;EsA=Y<~HM4z1f-Ma``&)%o@6`iQnoc&9GK{{AND19?s0gg7>?>NH97naI~6IGv- z#t^$?VC`w`-f$HJtm<)+X$iq}8SaRzlwX9*RFq8%G71$>IY==iCl!V6IO)~auvMno zb14$D7KE&K&$wVW$7u5-;@_A`D?Gn|H@OO(p=vDGcjgr3en23eh2sJ5V|l+!<4=r# z_wR`IQL$=1oP+sE@QM4h=>nUWLO`W`{Ly5?1=AJeajkoU(RGnm1&uYEHczBEw9)8t z8==0K{~zf28D!LD*JD(?b;!Ev-mm%Iog&Sysav<)cBP*U|Iarm`*e+h_#hw)$)7Ni z*n?hQcf~#5JXVFkokP5y=@nOadphLNl@17q$Nr8#WgoN7F{Q&W}B3RO_v85_&pVg{+-Yxl8Mxs0Mtr} z#%lOEid95T>cJ41J?wZodF!%>Mv~MU4plu&TxoW_*<(S-M9lz`*eXb~-c==JCAqF#Q{B;89}8GtV6{3P^qSe%*u*stytphk-| zq`cO9A*V^0az4$m<@}{x?=1j8HGa!B=TwEPpB`0cf3-io$1!!d_`ox(?96m#!@3|1 zTg3@U&L;Od!e-WlC46 z4%_^k0Jz{0w;aD1E5gh}sT41RnWUlGk0fZesr4FI@He-SBQ3>$y$I89^mnk`E}i7M z%GQVO7;K|BY5hQiJ!6#oE zq<{66q1wu!r%6YL-+adHH1Ot diff --git a/tests/e2e/detectors/test_data/naming-convention/0.6.11/no_warning_for_public_constants.sol-0.6.11.zip b/tests/e2e/detectors/test_data/naming-convention/0.6.11/no_warning_for_public_constants.sol-0.6.11.zip index 9cf6fe45063f87430f0ad7a12f9b030453f68d1a..bed78289e56ef3f5908f4435662a4a36bc1e0d75 100644 GIT binary patch delta 152 zcmZqV{?8>H;LXfp&%ngM$6&BfKm6JDr`qdT7#Mc&GccG>He|Kh7@EM6GDUlq+o2gh zm#?)=-02%wex$nIeVM!5(!~n7Z+Ue@jkYITC@M=mx#Y{%Nv4J6C#LSu5@Rvwb<1Qr u@K8|Bk-c4NYSGR`rm|u delta 154 zcmey*)yOR!;LXfp&%ngM$FORRM))_!GjlewFfi=kXJ9a&tj}t-F*JcCt@n38vysE& ze6CBEe5R^(ZM`?6^y}BzA>pCQf#r{k&UQsHbzWurv|wrNw5=rzEID7Z6dv5-pA|Dh x>-zHYl7pEi7ye*7cT;Be`#mw5PS5`|&(#R@KL7#%4gfEqFIT%R`s%w50023Skr@4dZW2|06fF7j2u9d2 zjv~j>(*bgFh6-zA`SM-I+UupG%F-RNrrlkHVQh+WzI{|q(qSq=O{t)5%QH9T|Fwx? z`$5zM$mR8eQdDx0mKkA8%8c}U$zM<~vq849ehwF?e$Q+I&&N1>R_LIu1mq4vtq+-T z)a`oedV#PlAVoQU@=tI0&rH;2{~%y#_%tJchy#^mWgVT(|$i;nA#q#%UXMoYE_&mH2UE{ zLyythewc!ol2|if(+q`+9N3A8z@gjcrEUK9fwba(uN!FF0%xmcDojJQw6peM zvQ=_#4+xbg*k$E7GLkdeVHbwR92wyo*v~`M zAxV;MvN}X))9$+HC`|~XQmuT=&ABCrG)87skv<^p8%5^O^8xQctcCMYWaeq^kck-) zvR?2j@`nC@Z;t2g=K`v(O1^@8);k9-wJ6Oyp?BZL7PBo3CJ=dP)Oa|eJ=QFPDq%gM zrARuS)J(VH6D$NQX?L*~pf7v7B5s668K=o*v!WGIM~fRk_C?RFLj$UiF+qiq8q_yV zbCgh(lmJbljhAvrO*0ZrEYXPSo73%I)JJf|&Zz2tqjD45%mDqbY6?wxc z?UF-(B+JonAFEEkoZ_+C6s}Si1*dkQGL2a3EJ|rXq~eU4VE`R zvfHM*8z2tNBz%y>+P{kWBmk97i@=FSyMT*-%tjk0d*do=u=+&JG>9)l_-xbOtC=t7 z&@l+fHbs$io}2eD-)?u_JaJ5D$@B-o{GO&!n1x}ka!+hOcOBPoWJEhJ;$5+DO$^t6 zEvwC7mQ&P>#51;HjjiNE^-mZZp|dz3`M1HZVmHfwmsE)Otf33Kc?ZV;A;>oIR;}&9 znzXP)W8c z9XaBglL(&e;^pTcn32v!+Ra!Gd%l=|Tm#%V7$p<^8_Des6@+OXwy=3UXcRw@Nn^kN z4P+9#n2k{=#m_h=TmP3YPmCdyX~AqrYp}aEtJKtM_nF#ny9SD#r?ZL><#5#K-SLaE zU3gb;tj9vIGsN#_R$q1&e?xg2L#qCcIWrhEKAdKgpMA_MuqMVqtUIcJ%68v>dhwP# zDg>_?XDhXGBBGrC;R#mj$*a>AenB>PLoJ4vCnt-^9nHlbd+dJHwvHrwcGy!S#XiI< zfHLNd*WP2?u;r7Hjd4PQh;_b^K})|_Pt zJ)`qS-v|%2`Y4n0%%Qn|KrZfo;74JUJHp}WM&aE)z%~{nUYhHvttvi8U<^VI@o>-T z1s%7{>lWvYjF|KZ$kP*(S6BWMQdD)b`Ns!+qiI0*iONA1Nj73xAVJME8N`F4I5`31M4s`$B`-#jZ zM&FqQEVJY%EBWeauE={p;bx)bH)GE(v>9|Po7`ALFZDBpos4@U0wHKY5(0(JVQeKg zAP+SnqO32Bbf_|ga0x?y@~R|@xoOpbHClim+LOtkEkg_=jy2CWRHhga9*ZG!qey!I zdtJ%ej(JBTy57M-+(-+xgJWQjK7 zgJ5-ED8fu>rFz7=@#v86-<$7*zg!4`!N4E@o%nqFA~F6jFi+@zd1u`!zCfgJ#D%`| zb+i!kH{a!n=T+x`l+v~tf`Q)Kx$}`x!7bJ(HhxdkNP`vT9kU(4>7}d?(rFBNwEaAT zQZh6p3>L9Ad${{vtE`$^!aY0#*Ooj2dW`rSgb2v@bReZ{%GK3AZ;A^Fdt6c1F6p*3 zv+m0Y$6=!@hrGmFS}%zN#Q`50Dz(yd)gK{AlSZDyZp zwM%rBTgcZ0F>S!KI$TcbNLGVLCg#y&HHHEdp=f^Fsz%CDj}L%D*eUwlxn4?4i1J_ePGWk{Z+w1`h;mylD@0Fc}mMS_ZVR*oZSk8YCU%QJy?FMsztjDEtDH$zwg4!|EMU3=Tj5D5Ms34C+5A2x|l* zM*s6_ab{IvcJcKn%^jv>#Ke^tWjs_ZN~;k@m20wpz)1qE8t%>gO2bP3s#sRq$H(a` z#p?qCHysntBb^8~F-?Jn3yt`v2HBUlD-U?YT^rGa|B>jIe6m)X^k`+x_c#Om z3`ucdaDh1+l&`ZYR~R1tpVs`5p|Z#k<@d&VYzt45F?ku%^TMiI7QVZQK6_-BrT1#I z;$U!pa(?TqgG3ZGg6EAZ*$t&>`MgI)Z5Q%QSr~q

`SzWTGfhTHsW5sLi>79FwcE zRZ3MV!e~F#-jfmbuVP3z&S_+M8-}NMImsoDz{GZyCoZgAduOL8VHC#$!+ZI~j=|iV zxlM89hqotV!M0G+0Q-S**+JoZrDi1@$KHE?0tF1*CxPeLk}VzldAklb@eT}4W{Z;$ zAACM-5)T$q{XH$gFas6mv@r6lskB@HW@RtFVkfnV(arzTT{jJ!N?al`+k|9DS-azU zeB+swb7BbZ&)cYki-Kix!sKITtCuV6Lz#};-=1W?#X1vIVe<&2okWR&>-IuUQ?Xuu zmfu>+jxVwQ^6*WgQnTsgPKL`+wU7QRdK#z<(Uh|=oMnH)Ud1qqqL zs#E7dj_@r0H0ebWl3loaCcHd}Y)Ko8mw7I`21MA0+UE z2o~@TevKw9TT4J&Hk7X^Kk~|1DKHq;IUaRqG2A&m*|i>r8{ZQ2jrS9w0-pl91j-2j zURr=NHl17H$HE+>#fF@~wkgf}H5_*Cu$4oNzgo5E7Fc38Z8qQ(#uae=OM@f_5 z{gFDPJKl#*LK8u+Vj?kEBTCn)F))s^J*Lp3mz4rRe_z&a!g4o)vg3#@e~4wtTt$HiOFM<4~D#m&soo)(VGa`x4A`+;dIb!VSa!Ls{*U)j8<(mFU; zQ_HV6@++r9-{h`frk3aRm>N4LJt8upC{4&u*lOiZsRkggxY$b+DKA@ zt(8ISxZ`gMFhs@(HYh(Qr8#c}u0^r+Em z7$KDd;eeN`+x8%TqGy6j#G+t9j{8+4DG&xF6dNa(bwS?@^?W;keoJ%SGTmh0Z`HuO zdKy8$4dd>uDjX-Fn;?OQz(il5>V8eeZ!fZ=@5RbZtg-0V_SVjeFN4Vp~;G|G=}Z=uk@m0zUvh h00ICG05730SGz9y>bnjA06C45xeiSR0uKNH008g*{DlAj delta 3570 zcmV@KL7#%4gjgFC|Bw+PBmB#006gz001eIEe|Y_N6vq3^5w{R zkP!|8hhN_Z-_xu=$9p)Mf>y1py=efO|C@)>NOSQ*eg%}xN=0+5w-`GG)oxa&J4#nC zeZ|C$B=%HruB~V-GaWs$K*C%Lz)X#(r)hSyF-$n%+bp`qtUzeCE&v40X7~c-l|xZ> z(K@AO87Em2He4v%f~KP2ylj6=4VY#yLq*v_oAkRef+qb&N|Lq@*=8yyy~Izgw7c~c z%L)Qfc_#-k-2-^d1g_L%2}TCXC73&7p11uQfl=LxBs;AQf>T^$bv8S)w-H##(9{H_ zb0^P$ryjwpC3boX9;16K)?$E0phY3NIgWpEmIoY;q9jPIl6P)+x?q3sGkbQX3N!c` z%_a_yceIcCKD2QXLtlj(W7&FH=e7o~*9*^tDXI0ceBFr@+x5P6Z>MU+dS;O#Nm;ngvuuxWz&YU+fHkw;Dn(lEXvLogFI0W?AcYl-s- z&TEOk7#C_jLcfoR2a5m+>^wqSI>$X$3h#&(aOei@DYE*`+7EwFou!g)lv-N#RhzPP zdW&D4P}J7h@t8)5DDa4FrnEv8r7SQ81l#3dHoCqB`kGmzMmMEQRbn|Ut!4xy(ke-| zOuIS1xqtKp+lz_jS{mk_Qu%{OFG~pj07y;oz4y=WyKr+#Q$X zE^OhKXMzD_`pti8TWJPKP~dIt=ws$#)E!+q0&nMG|03B}T_&0QN_2iyzkl7ZSl}d& zmM7q`54m|}2>^3dFNyUaX)ofk7vjkY869c&_(6KQH4-@+y-;(uV#b~rR-K?z_RMDa%QTrT?ceamaDwg^rBF?d%lZ(8Ue~iGzW{$msd>ppN$j^aLgT)nxYZ(u zPKIu5_ygoq2es_rC-_9Qy`}>_G4g-+YPC&4&s}OtqC9U`HL=ia;BALcSdIx}nu({{ z!Dj6(8&crWNBFC?b=F>W8ALF9Y&T7584Oa_(H^$yqdLma?ODS?4}xS0EWB0==+nt$ z6k0mqZ|Z-m(Gg_}xK1dl$YD8N^6*HsD&jK17pil^!y6D~0xz_CFPTXUgn%wK8`AvF zOY8;ZtD`3hIkk$0buY&Da4{KT?THs(PkYV*YAcz;5)P4zNSj-_QpN{d*Yy=Fva0UU z7>kkkoG0T^jw!!m=Tyk~`+O4VagDav&+}nd3!Z<4vt}p8F$(>e4^E?9z`G%ayEv#n z+4(m%*e$KZd5zuKV=30U;#3u`mlc3C=0!X3RWEgIrstn{i{D31y1hpy7#gq<p|9$`+BCaDA&1$? zefA2JthY;shx&KP;T?Dq1XQm!Z|Y&Ov>oELSYmThRpBBEuf`-DW+9JH{DPT@0J2dB z_ye7-A1$~C(cOTutoQLrXa|gt$_gZmr4oP8zOw$kIO<5{@^NIK3!9ehLv6I+O{m$QOTQ zWO>THls@B>G_rt&Lc8Cs(QmO2SNes}cOk3_aaWEzc)T_oc}5ZFyTs^33-9Z>f1DOP z0iOTUN1$CV>fq@qr)Wqm2^}j#%`G2r^)NE(cc9s|%10#11vF<+lhHNyq5+@Ilg<*g z;5U@BVSnEQPm`P9qvui)lL)&Vt4!aNZ z5&Q^scC88nYIE%}Tz>fgO`H`Rk#e^E83(@zzU*+;Y0$4QL2FtZ?70|Cq+x$^&k~G$ zg^advrr|S2z=SO>A)jZtDT;lUr#aihM9|SX)j}9&=pli^F^%loHL{ zRwZ8bjHWg<2Wg`FHPGIH9fM@{0mFHBdzi&GNVi5 zfkKu>j=VyfcD7VP3jK_d(c245uZjG=x@ubhz*KR2s;)TOpm?OLi;RDO*z{TtootSo zsUcxS$_w7cB)a*UUgFFRR(5+6O-t-Rr_tzkLmGXU?a5@`{RLSE{OdMA_LC*4y(s_# z#djbmb->7HI03@4kqY8Y_-VR4El`4#9@6L&WL(vXl6||pE}{t4b*vLvVyc4_28}p$ z6Se3}D}Qy1b}5+<2+My+f1evIFAzmKB|cn6Q0a>pF@PfqT5x3<>dVr|t#LKPPZyLz zv9ufi1LY{AQq$8;{}x|lB8JMTRB%->JpJ@IW+R_0a=!4`rdr$LKDISEQt`qJ7UtdZ z!~;K2ona&|@}@>pB&<8`1jfIqh6&K8_XS~4Yc+jw__RDipjCf64m69f`7-+u+Ve<|rZ%@0*iInrPEu8!@EmP13iwNFBa5Y7K#B)_tETsIPs0h@eKf#s2F z8fxY;+{Zu(NSS|=bl&&G6D~gu#!gJIVPHhQHMYUAWv=@Abnz4hU2f9ip`;z&XFY=; zoV5F(;RT_T3jLJAG7J&n~UJ=FN zWi%XHFeor}ogzLAC#-N^R%VWFL44tj!##W627R4`-OYcRj2QtbvO6F=b~cL49d7OX z+Fa$C=Esn{)S+Z>h@KQEo(ow&-_jJ{FA~FC8E>|lyPw~cfC-7ZUj-`AYLV!VUlz5L z?H~^x3C+`+NI9mb_12rDjg@_Tw#hu9S1w--M9+Noo)_i3FY@YLMv?q{`WHgY(3Lv$kYG z-;il8kJ+iH#RKpli%&OS2sc-TDl6;sK-0P=$rIPGb;-i%=)Apn@AH*zZM;c-1f1^;bUwCwUs5D;0RzLk^wqNgGVy|Vla{d@r z7ycIx8^gRS(_7!5k}K>RPj1jyh8gK$(r>SK1GVCc9#2J`m>{LtIxn{9=t4nfcnL+Iygn()go$r5@k#|#Z7^X1M`!~3}=kL7ulXJ$Tqr2i`H4ADY z3h)236m$619}bAB-*)#f;(ZsY_zoJQessNWHw1}?Mu3|n7BK+*?s5zrwcr#GN?5L{ zIm4hq(ugsHtF$zRz0=fVrwS^`CulClEPsudOjRxp26JITn))WNo7FHpQFni-TpeQg zMan1ofeJ}3IGY`#m|~#5vwvN)KqG_a0nD^idQ9zJL6{Latp`EvFlDs*>Xk*iB%O%p zVmZp0GSsdK4ibSE0$f&mh%A|o=$eAK7a=kIs;fVrj$`Jbl0+gOE038ugfAj59bgYE zci1y|0#lx9P8CqxsMB(aUiv?tuOS|vR!~b1r|us30S`|?;A4gwJdWgggUi0fcHgc4 s@UJ8JP)h*M>3=SPlRHw}q1&4^0N24gdfE0N_ZtfB*mh diff --git a/tests/e2e/detectors/test_data/naming-convention/0.7.6/no_warning_for_public_constants.sol-0.7.6.zip b/tests/e2e/detectors/test_data/naming-convention/0.7.6/no_warning_for_public_constants.sol-0.7.6.zip index 8caf6ecf2fdd994d985c73bb4f2847eb9c71d560..e2697df8906ba02a14d43a104fff0b469ff6984d 100644 GIT binary patch delta 141 zcmcc4b(Kpvz?+%Ho`H#hkHKJ}e)vk=GQrl3!sRTf*PDOlEs}J0n4UZ*+k3ge5gph1 zm2;n0WS8sY{ZE{%`%#QjUZ?J_zHj6Q$BB!J&E;2X|2xPbYxnfSqAf@N@-_+zPL(*Q jbnLXqRN3$U&s4AG3-D%SvS&cEY4S&w1h!i&3_t(?0v|Os delta 143 zcmcc0b)8E%z?+%Ho`H#hk73msjc{v`GM@I0!sRUK=hcpglyk4no6NYbM|h9mp+$L5 z4_ti|t)|?3Oh>k7rczGBr|R|bm2Z>X_@7;p|2pTGX7v`{LjSmf46C%fZmM(CHB7D9 lpk4fO`P)+(|Npl$T2%#jGcwsTpxHI~Jxc=H9To;4005YlHlY9j From b116728bc117f0911f187556eae6c9f101218c00 Mon Sep 17 00:00:00 2001 From: Judy Wu Date: Fri, 15 Sep 2023 20:31:48 -0400 Subject: [PATCH 3/3] Follow linter --- slither/detectors/naming_convention/naming_convention.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/slither/detectors/naming_convention/naming_convention.py b/slither/detectors/naming_convention/naming_convention.py index 1e10b5543c..85e1a6a65b 100644 --- a/slither/detectors/naming_convention/naming_convention.py +++ b/slither/detectors/naming_convention/naming_convention.py @@ -176,7 +176,9 @@ def _detect(self) -> List[Output]: else: if var.visibility in ["private", "internal"]: - correct_naming = self.is_mixed_case_with_underscore(var.name) or self.is_state_naming(var.name) + correct_naming = self.is_mixed_case_with_underscore( + var.name + ) or self.is_state_naming(var.name) if not correct_naming and var.is_immutable: correct_naming = self.is_immutable_naming(var.name)